Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939419AbXHIMdW (ORCPT ); Thu, 9 Aug 2007 08:33:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933882AbXHIMdM (ORCPT ); Thu, 9 Aug 2007 08:33:12 -0400 Received: from ftp.linux-mips.org ([194.74.144.162]:58714 "EHLO ftp.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933259AbXHIMdL (ORCPT ); Thu, 9 Aug 2007 08:33:11 -0400 Date: Thu, 9 Aug 2007 13:32:41 +0100 From: Ralf Baechle To: Joe Perches Cc: linux-kernel@vger.kernel.org, Greg KH , Jeff Garzik , Russell King , Lennert Buytenhek , Bryan Wu , "H.PeterAnvin" , Greg Ungerer , Kumar Gala , Grant Grundler , Christoph Lameter Subject: Re: [PATCH] Add missing KERN_ to multiline printk(KERN_...) Message-ID: <20070809123241.GA12818@linux-mips.org> References: <1186619327.3073.57.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1186619327.3073.57.camel@localhost> User-Agent: Mutt/1.5.14 (2007-02-12) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 841 Lines: 29 On Wed, Aug 08, 2007 at 05:28:46PM -0700, Joe Perches wrote: > Some uses of printk are missing KERN_ on the second > and subsequent lines. > > For instance: > > printk(KERN_INFO "line1: %d\nline2: %d\n", val1, val2); > > Line1 is marked log_level: info > Line2 is marked log_level: unknown > > Some lines have trailing spaces after \n, removed where appropriate. > > Signed-off-by: Joe Perches For the MIPS bits. Acked-by: Ralf Baechle But not without the note that mentioned printk should be deleted because this is not Windows 95. Ralf - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/