Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1235105rwb; Wed, 16 Nov 2022 14:19:59 -0800 (PST) X-Google-Smtp-Source: AA0mqf7UtQ7gcuyC6k0h8plq8g2Q6DSjlFDn4cHRPXgdmtMxA+BYX1flWUA6WGawqYM9d940/q/3 X-Received: by 2002:a17:902:db0a:b0:17b:2d0a:65a7 with SMTP id m10-20020a170902db0a00b0017b2d0a65a7mr11027753plx.85.1668637199065; Wed, 16 Nov 2022 14:19:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668637199; cv=none; d=google.com; s=arc-20160816; b=sGIyKjFueE8JQfli2olwjW6ofO3puKVMs89x0KqTJuUvVaRLJkxSFWspq/BX3bAjek l/H3UJF+mwBC1DiTKTWdxnX0zIaek+bPw08juVaWpGMUewyjZq078FscLIj21EkYz2tK l6aVR2uky2kx0bqtvP5PsGk+PLZBSyMVZrLa5FQi7p34JjZc2Qw6uqSjCahGj/T262vv SZ4+X8pBbtZ15Jup8QCqSrRaabzaUNrE2gj2CJG6C0+1LpHmxLQvgtLk5giFoem9FWY/ mTgYMnGRypdgQ5teJEU/3CWRKeO+eAT3aVlZ30r/8W8ip67VkUhDevoLfXKh2IAM5F5l fZEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=S9tRmYl+V+Ic/aVTnCihMsrXk7Pv/8N0JeFUw79VAH4=; b=SJ2Afl7FuPWMZKXX1h33zb7XPXt8G8gj6kcDzkrvHpm/R/s/dbmfSFzALWaLx4FkON HPERYnaS/liwoQSvyvISdY8Qcnvu0Snamg1x38Q0YZfkWvUtlEtBnd89e2aSiPbxEr/5 OSvgQuLAm+krmzJ/XnZjYjAyyzU6KtzIwsu2RRkH0qThCBz5uVETm8YHyeClJxf0GyR0 1gfy7ur+xx6/4nDPFHBh6HJWQvuOxDeBgKl9emujbsD52FUtTF8uZNIsw6Ed6ZH1rMRO /R18M1jKXT+iYKDLaMpiOi+cgfKf22jQ7owqaBCjfModuEZv7+hUoDf9CeQigpNWZlsS SR3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="dGSj/nTG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q8-20020a056a00084800b00537d8aa3bc3si17411901pfk.200.2022.11.16.14.19.47; Wed, 16 Nov 2022 14:19:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="dGSj/nTG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233974AbiKPWBQ (ORCPT + 90 others); Wed, 16 Nov 2022 17:01:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229931AbiKPWBO (ORCPT ); Wed, 16 Nov 2022 17:01:14 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C023F57B56; Wed, 16 Nov 2022 14:01:13 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7B293B81D80; Wed, 16 Nov 2022 22:01:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58AF0C433D6; Wed, 16 Nov 2022 22:01:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668636071; bh=mfKrZ8tATSZA5qSJwQFPA+KqxAXPJV+e+BMQU0b5UAc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=dGSj/nTGaWRVMNLMa1SEQ7Mi2BSX8giEqei4aC/myPELxg9GvjcxuECOQYooMk5zE 99EuZeb4Qa2wnMqlP4YOOj/V1aWUKaQQkeBTGy1hta4Rlnwg+qtRbJig9Iy1fQqsev vMnzOaEM4Bd/rXB2iUaoFGBq6NzWnSlLh5lWp+BRved+6bVRjPsP3SNlMA9mRObPVW ZEXjde8GLSTc9VF5m4vbhNZiQB2nR+k9PyIiF79qRcznJq+jDDLAUCIOYUIHorBocg K1vZBVhgEFR0Jj4h4tRVKlxLVS6Ttkqwcq7YhHUMCWzq1tW67C5iY/hmOCWMJ1c+Ab DCLXAnZu3vk6Q== Date: Wed, 16 Nov 2022 23:01:09 +0100 (CET) From: Jiri Kosina To: Benjamin Tissoires cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: bpf: return non NULL data pointer when CONFIG_HID_BPF is not set In-Reply-To: <20221116103110.1746497-1-benjamin.tissoires@redhat.com> Message-ID: References: <20221116103110.1746497-1-benjamin.tissoires@redhat.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Nov 2022, Benjamin Tissoires wrote: > dispatch_hid_bpf_device_event() is supposed to return either an error, > or a valid pointer to memory containing the data. > > Returning NULL simply makes a segfault when CONFIG_HID_BPF is not set > for any processed event. > > Signed-off-by: Benjamin Tissoires I have added Fixes: 658ee5a64fcfbbf ("HID: bpf: allocate data memory for device_event BPF program") and applied on top of the HID-BPF pile. Thanks, -- Jiri Kosina SUSE Labs