Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1240183rwb; Wed, 16 Nov 2022 14:25:52 -0800 (PST) X-Google-Smtp-Source: AA0mqf5hFqxC97r7JHJVf2xbmg6+mYcRCMhyEYUdu1Gr88x4KujQRVsruIeiudDWXvvQwRKCBvw9 X-Received: by 2002:a17:906:1416:b0:78d:e869:f328 with SMTP id p22-20020a170906141600b0078de869f328mr18320920ejc.696.1668637551886; Wed, 16 Nov 2022 14:25:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668637551; cv=none; d=google.com; s=arc-20160816; b=rTKVKuNoLw/70cYcQW7OSyn0oA8WCDQo47VWdXdUQuixneJegvE1jO1Z8IZ3KRO8IH vrIzOFhFmsQiwtYkumWrcxJG4eO2YORJNrkJnZ9qxhOwsaUObz+qVRMthxJWlbsHX+S8 R53R9BTAgP562ijnsi+aUqV1ivBq5m61Q/kXWyMNleD51a8/c8VKsLDkzrvZTVO9R324 a6VtavHwB/zUhAcv1VE8ibGxUamM68R0IqIY4NXL6NkgjDGRU5GkqbOBAA3Mnj/L/aeT QQMpyda1io54rMg2XHv4Ac5ag120K0jNmmn9eNn6SF3usSAellHxz6AJZnocN4rSbqlN 1j2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=q6nojB89E1Mh3yFLSu2KzkNkZ/bHQfVswcYDYKdeZ2Q=; b=hm94EZxIJ2136bpIK+7EcLuRWiULewp8tUf7vxcWZ5g7wFhh8Bs/qPI7lm8bG0cWkh D2bGK3apYV9WOtwdeeuSwZBzlGgVq320rn0iHWgKRblz5sGB74ebKNToMc+FuDts6jjT Po1QyVIwpKoErPALVE49RWyMrhLiFbfZFhJQyPWd/p+QL8XNHMu7W2mURcXTv9ZZ7pM4 SGOI1RlPUSF/uDZMCb2UMYvcjoDMdsjtdXxVyVp8s0qG964w6Lxzv8A3F1K6bV/XPaQS HjevPMNpipWmSh1c8prVHVqEzaaTvIeMAVKMxqqr/DQo11PeXj97JTIIHWuMhsNltU+Y LrNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=h7iqGBQd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f7-20020a50ee87000000b00459a58216d8si12848017edr.504.2022.11.16.14.25.30; Wed, 16 Nov 2022 14:25:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=h7iqGBQd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231688AbiKPVxS (ORCPT + 90 others); Wed, 16 Nov 2022 16:53:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233338AbiKPVxM (ORCPT ); Wed, 16 Nov 2022 16:53:12 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 243786A6B0 for ; Wed, 16 Nov 2022 13:51:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668635461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q6nojB89E1Mh3yFLSu2KzkNkZ/bHQfVswcYDYKdeZ2Q=; b=h7iqGBQdJ+mvNY/T6Gn469LYN6B5u5PkcWRH41+jKIggGfpukiQ7eA92QT0JAaDhAB59Gl sHQMWpdeJ23cIkGtKYl7/h8+cYXC1msb2TcQU4pMEqT/kEhd3lT7s/+SD0syNBrbOFQU0m ZrvqqVHVCHHWIktm2F5R6SVh2prESj8= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-558-Eh2e_YMmOcymeG0zEcWeIw-1; Wed, 16 Nov 2022 16:51:00 -0500 X-MC-Unique: Eh2e_YMmOcymeG0zEcWeIw-1 Received: by mail-qk1-f199.google.com with SMTP id az31-20020a05620a171f00b006fa2cc1b0bfso18970097qkb.23 for ; Wed, 16 Nov 2022 13:51:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q6nojB89E1Mh3yFLSu2KzkNkZ/bHQfVswcYDYKdeZ2Q=; b=YF65UP7fBsq1XxbQ8SfKLZVW5SVCSfs5OYhGEkL7mTomZvRNFMSx870NaHQpoJNgct yes4DqRVY+qwaPvJkkmc4CcB884FCQkfdLRXEVkynnjzO+WCxpKPnpwra1DzMVFCHzGS LYHQvPbFMOTAlMmvoh7Va6rapzl89BgaCsT9GR3hVODgMPP2HG+vwv24othqrBTYcs4c yVELM5H6SKXQwlAOAX8VFpiOt0lfRmNN/r6GfppPjnYuMr0ees/AB3XcWE1K+7T+Mxo7 s5bhzbt8/kcL3lNiWQelpMBDj2DekJAQ/fI9uoWsMV03GDkAid+GkLu2PKB9EYrJdQdW yNSw== X-Gm-Message-State: ANoB5pk747HddIGe/F+7QfACoayK0v2lXIee2ivsDIdXLpbBk1o9oPoy MN/swgYl64yVhGUAhCY8YiAjjeOmI/ZzTbIUZ/eO+UyVjIQ4Uoi0kzYGjmorEEP+PbnrgYxIBkF aT3w5EQTKtOjzXyPfaeNjXtQ= X-Received: by 2002:a05:620a:c43:b0:6fa:6423:65b6 with SMTP id u3-20020a05620a0c4300b006fa642365b6mr14077828qki.324.1668635459740; Wed, 16 Nov 2022 13:50:59 -0800 (PST) X-Received: by 2002:a05:620a:c43:b0:6fa:6423:65b6 with SMTP id u3-20020a05620a0c4300b006fa642365b6mr14077821qki.324.1668635459547; Wed, 16 Nov 2022 13:50:59 -0800 (PST) Received: from localhost (pool-68-160-173-162.bstnma.fios.verizon.net. [68.160.173.162]) by smtp.gmail.com with ESMTPSA id d7-20020a05620a240700b006fba44843a5sm3063589qkn.52.2022.11.16.13.50.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 13:50:59 -0800 (PST) Date: Wed, 16 Nov 2022 16:50:58 -0500 From: Mike Snitzer To: Yu Kuai Cc: hch@lst.de, axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com Subject: Re: [PATCH v3 02/10] dm: remove free_table_devices Message-ID: References: <20221115141054.1051801-1-yukuai1@huaweicloud.com> <20221115141054.1051801-3-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221115141054.1051801-3-yukuai1@huaweicloud.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 15 2022 at 9:10P -0500, Yu Kuai wrote: > From: Christoph Hellwig > > free_table_devices just warns and frees all table_device structures when > the target removal did not remove them. This should never happen, but > if it did, just freeing the structure without deleting them from the > list or cleaning up the resources would not help at all. So just WARN on > a non-empty list instead. > > Signed-off-by: Christoph Hellwig > Signed-off-by: Yu Kuai Reviewed-by: Mike Snitzer