Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1240298rwb; Wed, 16 Nov 2022 14:25:59 -0800 (PST) X-Google-Smtp-Source: AA0mqf6OYk1Vfz19kFDAoq4ldQOkJGh6EMr+yEfvJWDMlLvgrApcT2gDl+60XsKaa8yHfPaWm/Iy X-Received: by 2002:a17:906:51a:b0:78d:b3ef:656c with SMTP id j26-20020a170906051a00b0078db3ef656cmr18116868eja.627.1668637559160; Wed, 16 Nov 2022 14:25:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668637559; cv=none; d=google.com; s=arc-20160816; b=k0lXnsnpkKDx+qZyW4sf2fJmRUxASiceJpQHqcqyAF3DGPQszSZJ5hoQVMAtGchKtZ +IFvkBzkWU5p6hIGpkyqTTsJ0Kp7XN/dU6VW4po/pf2fVenC7VVb1Mtkr010D3n/FsDy L9m+22vd9s9m4EL0cS381yzj/AhshxztlqvxN7/SRc1i/47QysP4PNMaCcawLNTl14Ek Pm88islOzMWRi7lfAERFgopz227ckyAIcO1TCaPIyhJ3pnn7bofSlKOQu0zTsEuVHms6 PyNnqhF0QLVBUQDoX9WMUcZbZHpDjO+XMPN3Apl2/6aAGNYrMcHy/sygzOq+6tN1UK/j b1mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vCYGmyLDobaOWhMO5cqt6VIfl5tBZ1SXgoRZ3UG9G7A=; b=VQ9hLzNDRYjZ00GSxsG79ZujBBHAnRnCVrBrZ8nzPT6K7aDy/8a3ShfpnRDBgk24v6 dqqr6loSNPtqbjJeZX8JMjTtJVqny8RqUfWcz97Yr+6XFl4NXSyMqydFa5KNzFk8G94+ xR0I8HTdWvmrJXpuT7UONimDSf3yAKY+JBYAAOoFm5dOAO+WFtyZKKKnWubs7GqR+aKX rryu3phNe3KsWxvGT+YesLJU7NzoSy5ouA9yGZynsnv89BmsjwYhRZRBaZ1gNR62xajy 04zpqorqiFhNex3bOHiwL4N9lVaLvu7/wECYTAHzPyIRZ8BSdCsXD3WxSMK2UcQbrAsd JOYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZU8kwq4S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mm13-20020a170906cc4d00b0078d2197d670si11723348ejb.661.2022.11.16.14.25.14; Wed, 16 Nov 2022 14:25:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZU8kwq4S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233637AbiKPVUc (ORCPT + 90 others); Wed, 16 Nov 2022 16:20:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231734AbiKPVUa (ORCPT ); Wed, 16 Nov 2022 16:20:30 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB45661BA4 for ; Wed, 16 Nov 2022 13:19:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668633567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vCYGmyLDobaOWhMO5cqt6VIfl5tBZ1SXgoRZ3UG9G7A=; b=ZU8kwq4S1DDZW7gV3OJwTIIxSyQfNA0a9Sa0ne8DYVnRicTTqkUgv73Ha6FRhzaXSJGAso gF9JhSGx/2G6G3z59Qb/uMoj1p3CmgtSOn2tCV1Hg7d2gDDn8Q3+cMQx9KEFyzIBmKu9PI bWUOPDczyL+cjVFRZozAxgzfczxVdUw= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-556-HUcaD9CDMTib4OSDJR4lQQ-1; Wed, 16 Nov 2022 16:19:25 -0500 X-MC-Unique: HUcaD9CDMTib4OSDJR4lQQ-1 Received: by mail-qt1-f197.google.com with SMTP id i13-20020ac8764d000000b003a4ec8693dcso14226208qtr.14 for ; Wed, 16 Nov 2022 13:19:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vCYGmyLDobaOWhMO5cqt6VIfl5tBZ1SXgoRZ3UG9G7A=; b=nHLcpXnNp9McIUm2YsR0uOeGAnE342TmHh3ZwFQf+ccNrWQsngOdlQ71x2RMd0MZI0 rq78remp6dKN/mpJ9KJT/2M1vGeld3ic70cbFsupAMFHqmiPbol+LuA7L/nMhkOrjnvB 4Wf4xhXPNjFMGHl/DrI+kxGdesfyEWZZzWSM2N98FGRbOiQsOhvEcqBCsJdXjFHn0ITA Z0QL0qKgpNpCfwrP+ytTGXAFyDz++Bp4/ciU3u9WDjGp4VsH7t736jFySzssa/raBTyw gjU6g6Bp7agvvWrSKkoVJe62opPxbo0zgG6zznh0FWuCqDBaEhbDU3CX7FgIVrfU9LQ2 XsRQ== X-Gm-Message-State: ANoB5pnlpLj3eHkWTrq3HMLuc5jOPmBkjdlBSIhb1Du5h+4ZrOwW9fuL 2emxE+ZUvOyGfPznxd9U5WJm9lU0jPsWJDMc2HByurw9KPKXj/RjADcYjCL6p/yMhiYrXFzMgW6 4SkBfOuzsx+Z0q2BOMub5OKM= X-Received: by 2002:ae9:e00a:0:b0:6fa:dde:394b with SMTP id m10-20020ae9e00a000000b006fa0dde394bmr20880850qkk.265.1668633565301; Wed, 16 Nov 2022 13:19:25 -0800 (PST) X-Received: by 2002:ae9:e00a:0:b0:6fa:dde:394b with SMTP id m10-20020ae9e00a000000b006fa0dde394bmr20880827qkk.265.1668633565092; Wed, 16 Nov 2022 13:19:25 -0800 (PST) Received: from localhost (pool-68-160-173-162.bstnma.fios.verizon.net. [68.160.173.162]) by smtp.gmail.com with ESMTPSA id bj17-20020a05620a191100b006cfc1d827cbsm10879419qkb.9.2022.11.16.13.19.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 13:19:24 -0800 (PST) Date: Wed, 16 Nov 2022 16:19:23 -0500 From: Mike Snitzer To: Yu Kuai Cc: hch@lst.de, axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com Subject: Re: [PATCH v3 03/10] dm: cleanup open_table_device Message-ID: References: <20221115141054.1051801-1-yukuai1@huaweicloud.com> <20221115141054.1051801-4-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221115141054.1051801-4-yukuai1@huaweicloud.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 15 2022 at 9:10P -0500, Yu Kuai wrote: > From: Christoph Hellwig > > Move all the logic for allocation the table_device and linking it into > the list into the open_table_device. This keeps the code tidy and > ensures that the table_devices only exist in fully initialized state. > > Signed-off-by: Christoph Hellwig > Signed-off-by: Yu Kuai Reviewed-by: Mike Snitzer