Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1254101rwb; Wed, 16 Nov 2022 14:40:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf7SEimQjUF7K6e2H3ybdbJjbySouFku+gelI5duF/wJKs7z3hDAg7ijlz5FweKfApWqJmCM X-Received: by 2002:a17:906:5054:b0:79b:413b:d64 with SMTP id e20-20020a170906505400b0079b413b0d64mr18780527ejk.538.1668638442696; Wed, 16 Nov 2022 14:40:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668638442; cv=none; d=google.com; s=arc-20160816; b=jRxIn+qjYuWDJzNqeHO18YXSaPHurc/+wFxbzqZTr8pFVsWxx1ZiUy+eYZbhMyxHv5 EMQuQAhSnEb05H5AkmcJlmGsjWnUaZi7KUV3UB+r8WLi/6+ftqRopXbBamexlD9p4MYm wWT3k8M2tDakpZP6uq0jXvyhnw1dE8NiFWyAn6TOSEMmXFvzqP0qZTn7P28ajw260+Ei 7AkA1hx8rmLcqwOqsJ8UwnxSw3zXjQVJHFZ0il6ueZpADOMJgDzsnZLNFg0DI8v9aEcH CUfOvJ+RAH47Ke7LYal8rCKdZ/QA276UCnOrl+ukNFgnNvR1zXu/KRvxzDsrC9hrucRZ impw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7vamPlcLskGy2JvIhU266turZK2l7Sx2cyKxaPLx7j8=; b=xDnnJJSZGjhEJJA3F/bxO7TgpR9BW3Rc7gd8Xj6v+uRzF56MEcw6C/8kekcX7NhGly 5Epcj/H0I0ws/+RsJRiGcoSdtU++lqG83niYtq9mzoA5iNP+Mi1pveAORTg1oNiTed33 P6chYw53Dox/aKQ45A7h5mx4g3fH2n1wWcsr00qU4P/vN8MpTZCtKCiUKHRtEnhNWr3A ntmoYYbNIehPjf73r8C2oIHQ2AkklZJw6IQ6mK+sblww4zb87y1hC9zkiFp109RyBM+V ACENwLPFLsgQgZpifPM3L/6ggz0sCqjYPq7WAFQX2Yeoc3xYKxlk32eBx+aQBB1Us6e1 xmEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UCl8KVLM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hp18-20020a1709073e1200b007ad95fdd21csi8562619ejc.761.2022.11.16.14.40.22; Wed, 16 Nov 2022 14:40:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UCl8KVLM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234230AbiKPWMH (ORCPT + 90 others); Wed, 16 Nov 2022 17:12:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234407AbiKPWLz (ORCPT ); Wed, 16 Nov 2022 17:11:55 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 681246A6B0 for ; Wed, 16 Nov 2022 14:10:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668636655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7vamPlcLskGy2JvIhU266turZK2l7Sx2cyKxaPLx7j8=; b=UCl8KVLM0z2MK4xQK7FM95cw1drlb8V4IZB/uL46vzdOUgVXrE0ebR9LNT07nr8UtnVr9p DWNz2yHF9E0DLt+IrF/pWSz9dLLZ/odiYGl+J8PJx+TbxbIDtEvcNjywFYupdT+YTS4rZ/ RnNOG8WjIDThScRhmU8692OIciiq6X0= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-554-ialSBMN9OgOxk9dWf5hm7g-1; Wed, 16 Nov 2022 17:10:54 -0500 X-MC-Unique: ialSBMN9OgOxk9dWf5hm7g-1 Received: by mail-qk1-f200.google.com with SMTP id bj1-20020a05620a190100b006fa12a05188so50135qkb.4 for ; Wed, 16 Nov 2022 14:10:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7vamPlcLskGy2JvIhU266turZK2l7Sx2cyKxaPLx7j8=; b=63pgw862SWro080J6qosUut+YUJM373jS97IfISImY0rmI02+OAVmLmGyR9iPhMRc8 S7oSTj9Eq1IBy4fPFHOY9giB+dJYoQcAJ1J9Ww2tHJxVSaCodvAO8q+g0c21UIX3u1ig /QkYfhB3fpP9/K6CX/6FoTDQO1F2o7bJufM658O/PyxwAh9jCC715xM72xksRqpyaXsG qsqK0Da05A/stw/UbUd/i/XTQYvxjUA+zfGD4H8rn4Rh2MNICVhu6uZWqxVbM9Qo+TY0 MDt3cP4Pgjtba1cAno6E7L1CLIwuA2GPrbOH75RPg+sYvxfCP4n3RjA+ORY07UxQ+HuW ESpg== X-Gm-Message-State: ANoB5pnqQUHNxks6zc+FBNTiZI77QdYEZaZiRZ/b8omyk5s9Gz8pcaz8 EMu2yXI4KVVixGj/7DZikk9hVEUXeeXhZGHFAy8tXri/FasAgN6CiokLXc/ZL09Ab2DVCHutL9/ IF3KS9c5GzgiNOyUD/eeqzlQ= X-Received: by 2002:a0c:f4cd:0:b0:4b1:8ec4:4464 with SMTP id o13-20020a0cf4cd000000b004b18ec44464mr173723qvm.16.1668636654006; Wed, 16 Nov 2022 14:10:54 -0800 (PST) X-Received: by 2002:a0c:f4cd:0:b0:4b1:8ec4:4464 with SMTP id o13-20020a0cf4cd000000b004b18ec44464mr173707qvm.16.1668636653766; Wed, 16 Nov 2022 14:10:53 -0800 (PST) Received: from localhost (pool-68-160-173-162.bstnma.fios.verizon.net. [68.160.173.162]) by smtp.gmail.com with ESMTPSA id bq40-20020a05620a46a800b006f7ee901674sm10691245qkb.2.2022.11.16.14.10.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 14:10:53 -0800 (PST) Date: Wed, 16 Nov 2022 17:10:52 -0500 From: Mike Snitzer To: Yu Kuai Cc: hch@lst.de, axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com Subject: Re: [PATCH v3 01/10] block: clear ->slave_dir when dropping the main slave_dir reference Message-ID: References: <20221115141054.1051801-1-yukuai1@huaweicloud.com> <20221115141054.1051801-2-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221115141054.1051801-2-yukuai1@huaweicloud.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 15 2022 at 9:10P -0500, Yu Kuai wrote: > From: Christoph Hellwig > > Zero out the pointer to ->slave_dir so that the holder code doesn't > incorrectly treat the object as alive when add_disk failed or after > del_gendisk was called. > > Fixes: 89f871af1b26 ("dm: delay registering the gendisk") > Reported-by: Yu Kuai > Signed-off-by: Christoph Hellwig > Signed-off-by: Yu Kuai Reviewed-by: Mike Snitzer