Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 20:22:19 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dave Jiang <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Ashok Raj <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>,
        "Ahmed S. Darwish" <darwi@linutronix.de>,
        Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: [patch 12/33] PCI/MSI: Add support for per device MSI[X] domains
Message-ID: <Y3V+u+h7jGbRj3cE@nvidia.com>
References: <20221111133158.196269823@linutronix.de>
 <20221111135205.951710169@linutronix.de>
 <Y3U2QFeoDB17kbIC@nvidia.com>
 <87tu2yo77n.ffs@tglx>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87tu2yo77n.ffs@tglx>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WN7LJXijHxg5GYGyeTGMHkhqQtq4wWH2KqvJ4+/KStPETzUYvTnXu+eJ8YRd?=
 =?us-ascii?Q?tJMUU4afP2EbyOVQ1rk+2IVMHINWNVQl2JiuxNjU7Zq8GKncNpB4N2r+Finv?=
 =?us-ascii?Q?CKDHhicGxUfv03l7q9UJaNu/+0shn94AG6XJXkNM3TtsAed6T3pgJgdqXcUf?=
 =?us-ascii?Q?oIJvItDuxyEqYKckJtkac+UCmSS6VQIze9z5B7YWv7d6zlh3wCybcmGLIiKb?=
 =?us-ascii?Q?5qD4VJ1lLr/EgCzyzNfM5xQ+qKY/QrW3sszH+/YKpqjs5wuTEyzs2PFdwMEc?=
 =?us-ascii?Q?M8EWgYesjMozJV1sJ/pdQstWfDBsQc5EX8o3PJqUwFq67KPHMOT1KM1e0tox?=
 =?us-ascii?Q?H2Xq+SwdGeYjD1Syvw+Jd+uhbbhXwmKPrt1x10qPJNTlgBYS9EfMpFh9DhJa?=
 =?us-ascii?Q?TG5gGqpRoeXFkarDRTPvDrRx0Q6eCbHf5j5B0pBrzk8RCJQqg+H8Iree8x8A?=
 =?us-ascii?Q?nTwqXlmTzHCFYSczsgYiutCVgztpz/4AGHUXYypl9XxsLo/FTugI5jt+/Fhs?=
 =?us-ascii?Q?gQvcuo0ZJVi8u4M+xHGkMkMIMYwU1Yt1imbQKairqV3qTZzStOtgLn4o97Fx?=
 =?us-ascii?Q?OL65AlMy49OwLTQY/vQnPL7vwVcMgxY9dIOEmj0hsjmIZBD5Q0Xn8N2SXMyJ?=
 =?us-ascii?Q?9WLRtyeHWaZ1liOfsTOhtoHoEK0hQQwnhgDJ0S956gGNdz7/4CWhfdaUsThp?=
 =?us-ascii?Q?oPa77TrTUeTIna1WDFEjiQHhgkho2uWBmwiD8uytWNTlL/O7PaJNXf4xaJ9b?=
 =?us-ascii?Q?nssYZEx97KkrzvA7U6vA0b5fRRQUR2xbgaJ7zqqVDHY0eeUWtP87WWXwAveL?=
 =?us-ascii?Q?Jt0FSAPzruhASP4LuUa8u3aouuNFyuniYLoE2dObamI5aDrLQ4FPd8RP3ipZ?=
 =?us-ascii?Q?X9AkH3QV/gT+/hpL/Qf2jH/zZ8MS8Oq2EpK6gqaAnZpXAoiHnDhZNswMgY05?=
 =?us-ascii?Q?O/AoJ+ryeBHc3yjuWMFdmBkM7Ki5thjsvIK0lLaA/bCrIItBcRRD4aZkiPKq?=
 =?us-ascii?Q?jTXd8N+lKemARgZaO60F48TGxTssBSijfrDnguG77ZRBEyCTnvprXI+Y+ZIv?=
 =?us-ascii?Q?Jdth6fsC+nJBEqAt6nHRvW3WtllRzRvzDPNBto8+atRRP1zQ8bIIrnkOe8EH?=
 =?us-ascii?Q?m/IGA+MnxyeChkfWo6gY+dCl09pTHnZWWakPqqyhKfEDqnWIJg0m6ks3MmzN?=
 =?us-ascii?Q?rn3mSLZ8bqetKv/MgvmDbN47n9JYhPbKwMrT2n/FYKeRk0UyAHJlqEFs3z8T?=
 =?us-ascii?Q?5Iy8hmebvfIMOOLMtgspPNWxJHFBM8gaJ7L5i8UlTfxEfGASGzGoymMrH4lQ?=
 =?us-ascii?Q?pX2ApZE210JsAN6HHWbIAmh1tra08xw+43KD7s+uZm37LPDkTIZCryUE0IJH?=
 =?us-ascii?Q?uDsPQkXovf/SICkXI6gkhEGxVjRjaUDxiMK4AODPczgQcbOoB+APt4z26xmG?=
 =?us-ascii?Q?C2OYrfvI/z9PSqozkpO6uTerLkxLc/kZo/wwxpGuvqgqpaBEXUpur3J9Djxi?=
 =?us-ascii?Q?8hQlh5UvH31TM+bI1yRtbz+gJa2OhGGbvvQT/tar+dYCuX77jN1DVKTzSWYG?=
 =?us-ascii?Q?su+9f6c/IqNnWGSSbbM=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2bdb01f0-54d1-4f13-3690-08dac831ca98
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 00:22:20.5365
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vBb7OVd0NOd3q8FhySgsJAeVgdTubp1qHBcwgEuPvocMPM8J8h3rt6+CeYVfCGJb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6665
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 16, 2022 at 11:38:52PM +0100, Thomas Gleixner wrote:

> >> +bool pci_setup_msi_device_domain(struct pci_dev *pdev)
> >> +{
> >> +	if (WARN_ON_ONCE(pdev->msix_enabled))
> >> +		return false;
> >> +
> >> +	if (pci_match_device_domain(pdev, DOMAIN_BUS_PCI_DEVICE_MSI))
> >> +		return true;
> >> +	if (pci_match_device_domain(pdev, DOMAIN_BUS_PCI_DEVICE_MSIX))
> >> +		msi_remove_device_irq_domain(&pdev->dev, MSI_DEFAULT_DOMAIN);
> >> +
> >> +	return pci_create_device_domain(pdev, &pci_msi_template, 1);
> >
> > Hardwired to one 1? What about multi-msi?
> 
> MSI has exactly ONE descriptor whether it's single or multi-MSI.
> 
> Multi-MSI can have several interrupts hanging off the same descriptor,
> but that's not how MSI looks at it because you write ONE message and the
> hardware does the substitution of the low bits depending on which vector
> is raised.

Okay, that is very clear, maybe this in a comment right here ?

Jason