Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 17:12:11 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ben Widawsky" <bwidawsk@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Davidlohr Bueso <dave@stgolabs.net>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH 03/11] cxl/mem: Implement Clear Event Records command
Message-ID: <Y3WKaxd4cGmdOMz4@iweiny-desk3>
References: <20221110185758.879472-1-ira.weiny@intel.com>
 <20221110185758.879472-4-ira.weiny@intel.com>
 <20221116152426.0000626b@Huawei.com>
 <20221116154543.00003c6a@Huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221116154543.00003c6a@Huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FmeO5ny3JPwlXcy7tfNaLgxHqILFPUA/RGl8EWvw2O220UYB8idSoaEJ/ziR?=
 =?us-ascii?Q?ske5z0IXSkhC5x50B8OmYz3Rt4re5XVTKJYeI3N6DO4FpXMFIqOZF2IYh47O?=
 =?us-ascii?Q?BhFSa6XwD/K4qpejusQgGFqGdZBTt1BijuhUM5u5hEMudpx6/QPHQhUvAvmx?=
 =?us-ascii?Q?J2YhFZf0Ve4bdz4/Oupv4eiut/Qc9UXH+CT4sl6j5Xpqqyi0lP81v0aUK3fX?=
 =?us-ascii?Q?v3Ppa+jTM9F+8xfoGgWLASfhKzmLAY7r2fwnoctYna4ZcmfGi/WpeKY5tSfV?=
 =?us-ascii?Q?G9OJ6SJT2QKa72MdDFXDmHpDh1nOa3XkVdLoOhPNV1bnDo5gVaYmV53qZyv6?=
 =?us-ascii?Q?2DYw4JJ/b6grcLmAgXE3UpQPv1Xe2EEgbhaZf6gGCniLiZbhEVDD3BDsuLZZ?=
 =?us-ascii?Q?rrzagKjRa+02Zf6XUHKq3s6wElBxBEWapTrOnRcgf94AqjppwULm7uDlYESq?=
 =?us-ascii?Q?ps908hF1H+gq19ZTD25Uelmvlb78V6BaA0nGeen8ickXOajsN+lVxL42M6ad?=
 =?us-ascii?Q?6n3x1XC0U6hY1IR8VAS6Uu3TPpMsijZ/ACIspZb5vLpHEA/Q0XU7M877Ayd1?=
 =?us-ascii?Q?JsuOmpADnkDy+Vb9XwKm+i9DxeUkqYPjxr7RKTcYzlb7vvbpe6hNOk5K2HsT?=
 =?us-ascii?Q?DussivFQ624dvXOKbR6OxrcTY9ipF6vglj3uVpeHDkMrjjaaLxujeDkTmsTg?=
 =?us-ascii?Q?SFeizTEh87KOfIgCsql+CbYPIl5neBHK60cabtC61V49MTOOBq40wi7pJWFx?=
 =?us-ascii?Q?XlKl0RP5kp3OfH6+gbKobBadQC6iyXDe6h/JX/QB9x/GPWxrO/YlAS7D2NGE?=
 =?us-ascii?Q?qxJoFONQ75gKMTK8G5WBUG1NoMjDSnCMkGBF1z71LO02AjCEjBIXCs7WbUg4?=
 =?us-ascii?Q?AgqdCIsBaquWBbhvK1J/Dk/gWEz3nZ33jdneMX4men3rnSWLc+C6yODsaDLa?=
 =?us-ascii?Q?WT4B4BTElvT3BE7SN8T+xhtQtof3T4Z+qFwqgGGizM22x29CZgTEqTxWtEZ/?=
 =?us-ascii?Q?9JItf6xEu0nyvCKZ49+CfHZJV7JxsWgby2ZIgiAqGxhJExvoq3UYo8VSB/CV?=
 =?us-ascii?Q?S/BbpFUEMTZ9esNmy2MXJA8/GXQqRLO1iR4DdI42Q0Hp4XbX6u/csIEBppdC?=
 =?us-ascii?Q?waaJv9rYUQoYQj8W5WaWyGoIMpxTj4c41mpLVEWq5xBlUs66lTH3HK/+Mq37?=
 =?us-ascii?Q?F4vWza2uyA3agKQHB1YCxLBnWQSqe8DqBuqPDOmHc29mW1Yd+2w1dSuEHki/?=
 =?us-ascii?Q?eYmHf52FrPBkDlTUvBxov8Gb0BEjBf7lCHNe8H/L9dMbvwjNGVZhOcoPEDsI?=
 =?us-ascii?Q?WfygJD8Fz/yF6Kj0e7RYKsuYKrWmWuscYhf8yEY9VTIHMbv6ijhRh2oCTcCA?=
 =?us-ascii?Q?SmgocmwQiLob42PVyULSa6IutW9Z6M6jQGcr4ftKa2gida8pbGj0dJPZv3vP?=
 =?us-ascii?Q?+JmNvnLsiz8Zpgm/MRVGZhLyvA/xdRj7iz+8BdZX5qHpujgQxkZReV06WC9S?=
 =?us-ascii?Q?4fXR8l/CbbHj4pVwPonPCnOznjJVzJyJKcjjn6+E+RxsCETs/pAB2FOICA5a?=
 =?us-ascii?Q?M+/zr7eaLG1ZflXX28dNBob1Lh+5boEwRzmjPZ/w?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c52671e-c459-4838-ce82-08dac838c372
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 01:12:15.0244
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TLLdqx9gQbC1y3xS7VcsRCKMRAcvhPKRKGJ+fGeCXkrXrF88PS2o0+T9YQbzNDIkVQP61853R7ocxdx4KEV8Yg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5882
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 16, 2022 at 03:45:43PM +0000, Jonathan Cameron wrote:
> On Wed, 16 Nov 2022 15:24:26 +0000
> Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:
> 

[snip]

> > 
> > 
> > > + */
> > > +struct cxl_mbox_clear_event_payload {
> > > +	u8 event_log;		/* enum cxl_event_log_type */
> > > +	u8 clear_flags;
> > > +	u8 nr_recs;		/* 1 for this struct */  
> > Nope :)  Delete the comments so they can't be wrong if this changes in future!
> Ah. You only use one. So should hard code that in the array size below.

No it can can send up to CXL_GET_EVENT_NR_RECORDS at a time : 'nr_rec'.


                        rc = cxl_clear_event_record(cxlds, type, &payload, nr_rec);


static int cxl_clear_event_record(struct cxl_dev_state *cxlds,                                                                  
                                  enum cxl_event_log_type log,                                                                  
                                  struct cxl_get_event_payload *get_pl, u16 nr)                                                 
{                                                                                                                               
        struct cxl_mbox_clear_event_payload payload = {                                                                         
                .event_log = log,                                                                                               
                .nr_recs = nr,                                                                                                  
                ^^^^^^^^^^^^^^
                Here...

        };                                                                                                                      
        int i;                                                                                                                  
                                                                                                                                
        for (i = 0; i < nr; i++) {                                                                                              
                payload.handle[i] = get_pl->record[i].hdr.handle;                                                               
                dev_dbg(cxlds->dev, "Event log '%s': Clearning %u\n",                                                           
                        cxl_event_log_type_str(log),                                                                            
                        le16_to_cpu(payload.handle[i]));                                                                        
        }                                                                                                                       
...

Ira