Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Nov 2022 17:18:19 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ben Widawsky" <bwidawsk@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Davidlohr Bueso <dave@stgolabs.net>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH 05/11] cxl/mem: Trace General Media Event Record
Message-ID: <Y3WL2+xhA/VttQt8@iweiny-desk3>
References: <20221110185758.879472-1-ira.weiny@intel.com>
 <20221110185758.879472-6-ira.weiny@intel.com>
 <20221116153106.000025d7@Huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221116153106.000025d7@Huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1ZGiV9AVQzvwI1Ou2GSBW2fh7+sGBydShwg04GRKunRmjFzIjygk1F3Yog0i?=
 =?us-ascii?Q?Z7APKtNWNosSUtj0YsJ51D8+r/o8f922haScpEe1gTl8QiXQ6iHzCfymLD1u?=
 =?us-ascii?Q?X0eWpVEpks7QK8mKtULjsGlJBQa0PuFRdcwEJop5N/83I1aNwYo2qmzs5C4P?=
 =?us-ascii?Q?O3tUwSZERtdouSyymC/NdvTSjx+Qyf6QL0oYqfUDv52xcinR5f7OSif68rQ7?=
 =?us-ascii?Q?Ev6cQuR35m3+19op+2RJ+Pu6VY74IAMD0SyskcxMIRCVnk2BJB9ipYwg1tfu?=
 =?us-ascii?Q?D+5dYgmTJYRuNr+pxHNjlbBxUVI11Dj5CfysgcXOdWUiN7T74JFksSVMZNfX?=
 =?us-ascii?Q?tpU9/P1HsG/Fwyl/vsK6tCspkmT9+0pC8zjMCKcEsIlu0U/aO7OueEZ4PjjL?=
 =?us-ascii?Q?O6mkLAkZ88YCXu/xBWyN0y3X6oAnXQgVpRMWdH4yrZb1yTthRVsMakWzLpVq?=
 =?us-ascii?Q?1UfngyKqh9fwlcQ5OlRKLak5iw81+XG2a29KYtYDCN5Moj/RKLdZqeL2Xfsu?=
 =?us-ascii?Q?ei9ZvKZJql1nrwgjtCNjQUH3nHca+drcs2QQUg9d2Wy+c8QtsHf9fddeoqoG?=
 =?us-ascii?Q?ze9tLC1SL67MzI5DGw6DX/JNje8OrfgYbtFj5oUitEOTdtpQhGiVfQDycKwe?=
 =?us-ascii?Q?D+OzpSKQt4sXu7jgZVk9gTQ2+XmTgHszNN+uvNpibZGzT6W9c1q7K7qE/jwD?=
 =?us-ascii?Q?7M1am5J2ybU6nXAaE+h2XlHcJ6nU57icrJVnwL4s5jWBzuHJ0vAPa+8PZdKF?=
 =?us-ascii?Q?JPVhs2ltdxBZLSk9Q1LoLzJCT0brGDEhDFHggcsrgs2cVifaYQvX8mVRMSuw?=
 =?us-ascii?Q?30G2vUiKslMayTgyzVsL0VCTZbxAQkPRIzYZUfRMTdgKdqFf2eDq6ZXUzetA?=
 =?us-ascii?Q?aLIldLuUqkmt978DbBD8z8fkNyguxt2PT4iMgzumhPdxPrRDQNvZYkcGslbI?=
 =?us-ascii?Q?EUU/FHoolU2Ckw6tm2joTjGhQM8STC3vzXWYoiKNQ8IwpKO34t0fD921WmRh?=
 =?us-ascii?Q?4vsECSasTxyMJZSsOESj+Nt4tZ76YC5TAqXsh0T+sw24q2ImYaEDaQV4iWJf?=
 =?us-ascii?Q?5J3uW7tr+Kwqg2acdgml+sKr5+5u8QabuEKEycq+HE5fy02OGQeDnNu0L88s?=
 =?us-ascii?Q?299USee7M4b6T1i9amO1dlZMlNs2pWuu6YbgzMDZTb81H1m+N330fvgifsg3?=
 =?us-ascii?Q?9yBHzPrTRVJnZwxYjd99kaDMEPJZY1BRDFY6k3RjBhaRt4Xl3hWymzRpEBc7?=
 =?us-ascii?Q?uyXgSb7xtVlSCTmWIq7+XC/J4MD2Ofbk9Tc44l+/hIUsj6/SGlyr7cRYjufn?=
 =?us-ascii?Q?0FIDr/T8CcuQJ8nBIBqM5Su6Je6TWP6F9SgGvLJ67rGejwNXH14VnkNtMk9p?=
 =?us-ascii?Q?kNlBWzYzX9MjypP2rvOOqTtfT6WJxGYn/bCAeehMugPLGMvk/we3/CLPzS5S?=
 =?us-ascii?Q?loas0BIayPIJv2IfQztDnUyDfkNdu4BaWE16krBDK5Baqsx9DD6x/XpjmEuW?=
 =?us-ascii?Q?F0b/TXiqkcozbpYrEv55UmrvxM5412JGcwtrcLhPnr3ewzycLBLDNh+lZDIz?=
 =?us-ascii?Q?E2XbiU4zp29bmUtRQ7dTacf5a2/RgG3swynNfk4s?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a156a55a-5faa-439a-43bb-08dac8399f00
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 01:18:23.3725
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6anwS2Esvb7t9fG+8v046ODpzpqkqd/OXu3l0UKa7mCPzSbhVkxrjL62couM4eetfY2WkO/aVQ8pyYo3h/KMsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7478
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 16, 2022 at 03:31:06PM +0000, Jonathan Cameron wrote:
> On Thu, 10 Nov 2022 10:57:52 -0800
> ira.weiny@intel.com wrote:
> 
> > From: Ira Weiny <ira.weiny@intel.com>
> > 
> > CXL rev 3.0 section 8.2.9.2.1.1 defines the General Media Event Record.
> > 
> > Determine if the event read is a general media record and if so trace
> > the record as a General Media Event Record.
> > 
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > 
> A few v2.0 references left in here that should be updated given it's new code.
> 
> With those tidied up

Fixed.

> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

And thanks!
Ira

> 
> 
> > diff --git a/include/trace/events/cxl.h b/include/trace/events/cxl.h
> > index 60dec9a84918..a0c20e110708 100644
> > --- a/include/trace/events/cxl.h
> > +++ b/include/trace/events/cxl.h
> > @@ -119,6 +119,130 @@ TRACE_EVENT(cxl_generic_event,
> >  		__print_hex(__entry->data, CXL_EVENT_RECORD_DATA_LENGTH))
> >  );
> >  
> > +/*
> > + * Physical Address field masks
> > + *
> > + * General Media Event Record
> > + * CXL v2.0 Section 8.2.9.1.1.1; Table 154
> 
> Update to CXL rev 3.0 as I think we are preferring latest
> spec references on any new code.
> 
> > + *
> > + * DRAM Event Record
> > + * CXL rev 3.0 section 8.2.9.2.1.2; Table 8-44
> > + */
> 
> > +
> > +/*
> > + * General Media Event Record - GMER
> > + * CXL v2.0 Section 8.2.9.1.1.1; Table 154
> Update ref to r3.0
> Never v or the spec folk will get irritable :)
> 
> > + */
> 
> 
>