Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 17 Nov 2022 09:46:56 +0530
From:   "Gautham R. Shenoy" <gautham.shenoy@amd.com>
To:     Perry Yuan <Perry.Yuan@amd.com>
Cc:     rafael.j.wysocki@intel.com, ray.huang@amd.com,
        viresh.kumar@linaro.org, Mario.Limonciello@amd.com,
        Nathan.Fontenot@amd.com, Alexander.Deucher@amd.com,
        Deepak.Sharma@amd.com, Shimmer.Huang@amd.com, Li.Meng@amd.com,
        Xiaojian.Du@amd.com, wyes.karny@amd.com, ananth.narayan@amd.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] Documentation: add amd-pstate kernel command line
 options
Message-ID: <Y3W1uHu/GMHu5LUY@BLR-5CG11610CF.amd.com>
References: <20221117024955.3319484-1-Perry.Yuan@amd.com>
 <20221117024955.3319484-6-Perry.Yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221117024955.3319484-6-Perry.Yuan@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hfL/OnwvGadkiFGLkFSMDQyTPlVL/vLspt7T8ASyY7Xsx5e7qMhWQi6QrEWH?=
 =?us-ascii?Q?bPqFb98rKhFoK3xMC71VRML6i+MyKQPyZbNO7H/1q0kSYvgnV6/mbLcyPhOC?=
 =?us-ascii?Q?kb5UZrM/nvl19FHJcDwpVvif8MR6LuIiSwZDlNuk9mcArMMZs1cijCS+oHTH?=
 =?us-ascii?Q?+wFARle4Ren6xM6VDUVMNxykcU/+WmciOKgsVy+fT5sbf/7zk69u+Ck3NBWn?=
 =?us-ascii?Q?T1Vos3bjkowgN6DZvw6Am79E2YfedvcJj/vh3Ra/pMJzt104wQfoafCsGY9/?=
 =?us-ascii?Q?W0hjRb0fpQL56gMa2l9m+3eDus4maBo9qcYCMsNqSeo6EaHocogn0MdXsZdV?=
 =?us-ascii?Q?5VMs4Pr1i7z5fF7q9yrJOP3UVgULqUdM/b2As0LdW/2MBIH0npmIXmMWBpiu?=
 =?us-ascii?Q?TcWefx07yQDNuqkb3Gzr57ZUkApO4nRLdNdvUI7nxtM6inAXtlpQpwGSr4mp?=
 =?us-ascii?Q?S4WTOXBJQL+qNHC5MydgUU0m8UnQCg+dL9/zNfbimqTpFcZ8rz7EqUF2eqB2?=
 =?us-ascii?Q?cIf/CVhJMWTrLk55+Q32ahEaH8NM0fw8/G8kZ7kevqWXl7VjWZClQVRP2R7E?=
 =?us-ascii?Q?JvXOkcEP3zIHEri8gCZNPoAurYl5BRTO96UUlpB/V1FNlO7Sdr6kfDtphX1Y?=
 =?us-ascii?Q?fFFYzAlC1gzXVoLuDBDfz1TnI7Ll5K4H1T1Kj+wzQwgDCDWLeRW6PDT7y/nP?=
 =?us-ascii?Q?vtEStpk+fpKX/IG87oHJbQgLtKi870r50Ixt5/GOjSMi8QYuE4HQxG+pGe26?=
 =?us-ascii?Q?SCUAYkEbRUmzZWWVl021H2iCsp6tmQBQTjDcY10B+Jj4oIkDecsuEEDQebOg?=
 =?us-ascii?Q?n3acBwPsFDMnOz/FONRGskHyZAcUmncNmnxT8K3+bN71qH+cnfyTo0UnhMv0?=
 =?us-ascii?Q?i0js/2fD/9ch7hSz/1H2jKme6PANrBM1F92XyngaCIeE36My0E+ley94O99J?=
 =?us-ascii?Q?OrewiPBNDV8AobGGJxjIp0lpcNUs9OKskGRfMc+rrit9KoDmHgTAEMkgcUV3?=
 =?us-ascii?Q?O4pxj1czYIXUIWWv128Hkd5rihu80V8Bks95ozOqK0wASu/ULXwY+bY9RD2b?=
 =?us-ascii?Q?CSPt+TauX36bb2Vv/de1/yCYsrwo/4/vmg2CZ1HPWJlau8ZYvter4lE9bGoR?=
 =?us-ascii?Q?0eg+cdCBEvjkoLwtNVQPFlvhaQDPkvGsm4gxjEltKLzfjyVjs1E8wKfdYo3N?=
 =?us-ascii?Q?lmtFTtBqd5XCK6rPJ+mietvmLgY50ujQR+S4Uml/66xumIGnVqwFgn6f7uaw?=
 =?us-ascii?Q?Oxbjyi7GLjqyp5qmLnZLJ31HUYwmwgZp1Mys2gB2/WSBx7/HyQioo8I4aQzu?=
 =?us-ascii?Q?DLLkX0BB9yPJMOx5DkJ0dmkFTHIlPW0rl5LogAOJDf6VkKONqbdKwGHT+KdQ?=
 =?us-ascii?Q?pxyCoULUpLMKoUztpIdnid/HN6efsbQWOQDQ/r/MfTpiy8Ammko88+r5FeVZ?=
 =?us-ascii?Q?HGe+gsVrPw3oJ4Ox+8PwRMIPXHmoW1O1U0hdxtNEcFNjuIXck07tj4yy1nIo?=
 =?us-ascii?Q?XOQZSV2u8GeSMqsS045KMLxGW6vCofLP1mfvnCL/Q4IMm1PHYNP+VfE9MDd6?=
 =?us-ascii?Q?qT8FvWT1Z0wJEXaZtHkLz6gRVPHdJC/csLaO3rZT?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01eceabb-d3e6-47c6-aa48-08dac85297c8
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3286.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 04:17:08.6980
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5m/q6/zsGVmSsaJonksPERb7ioIDSxkTHwy0T95H4rMbJp23dDbx27c/CFLeGJh7wo9BOijnx6h0yegXOMFu/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7078
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 17, 2022 at 10:49:55AM +0800, Perry Yuan wrote:
> Add a new amd pstate driver command line option to enable driver passive
> working mode via MSR and shared memory interface to request desired
> performance within abstract scale and the power management firmware
> (SMU) convert the perf requests into actual hardware pstates.
> 
> Also the `disable` parameter can disable the pstate driver loading by
> adding `amd_pstate=disable` to kernel command line.
> 
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>

Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>

> ---
>  Documentation/admin-guide/kernel-parameters.txt | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index a465d5242774..42af9ca0127e 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -6959,3 +6959,14 @@
>  				memory, and other data can't be written using
>  				xmon commands.
>  			off	xmon is disabled.
> +
> +	amd_pstate=	[X86]
> +			disable
> +			  Do not enable amd_pstate as the default
> +			  scaling driver for the supported processors
> +			passive
> +			  Use amd_pstate as a scaling driver, driver requests a
> +			  desired performance on this abstract scale and the power
> +			  management firmware translates the requests into actual
> +			  hardware states (core frequency, data fabric and memory
> +			  clocks etc.)
> -- 
> 2.25.1
>