Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2d6e5cdd-bcfb-1632-1458-38d506e15b82@windriver.com>
Date:   Thu, 17 Nov 2022 12:39:45 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 1/2] net: phy: Add link between phy dev and mac dev
Content-Language: en-US
To:     Florian Fainelli <f.fainelli@gmail.com>, andrew@lunn.ch,
        hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221116144305.2317573-1-xiaolei.wang@windriver.com>
 <20221116144305.2317573-2-xiaolei.wang@windriver.com>
 <980ef04d-a303-4a69-a980-0c910571c835@gmail.com>
From:   "Wang, Xiaolei" <xiaolei.wang@windriver.com>
In-Reply-To: <980ef04d-a303-4a69-a980-0c910571c835@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V29IUkczNmQ1NnE3aXB1dkFoMGJicnQ4YTBuZ0h3UEU4NDhFeHZPbEtmQUlY?=
 =?utf-8?B?OThmbExZNjl1WDJuZFJJZUNpZUhJOVcxYVBEbGFGYWR6SEdrelVYa2pUczk0?=
 =?utf-8?B?TDN6WThtaHlBWCsxd0tKVWVFTXhuQXFsWjZQdmtnRnZveUNkZC9wVDhmRG0v?=
 =?utf-8?B?WS91b0tvejNsUFdMVmR4d3ZZMEtNelZycCt5WWh4QnlWWHRvRFl5UHMrYkdC?=
 =?utf-8?B?aVJNbmlTWDR5MVJwbUVubmwwTllFcEk3cTVQZFNWMEpuRG9vYzVJWFhoSml1?=
 =?utf-8?B?OXlQRDJXK1ZMTDRFVlo1d3BtOSsyTE96bFFQQkFnK0REMEJGbFp3eVFiY25S?=
 =?utf-8?B?USsrSWRVZHdGNlRuUW1ja0h0aC9QbWNoeVZYdlRqSTBIMXczbkFBa2Q2RWpu?=
 =?utf-8?B?VDFyb0hHcmMyZWhHTS9yOWNiLzRVejVGZlc2ZkUySTNOb2ErQXVsUjlQWkQ5?=
 =?utf-8?B?YUZ4azFocVVMTU5BdHAraVV4bjFha2tRQ3ZOcm9EQXJBa2tEb2VsVEVOUmYy?=
 =?utf-8?B?eHhJYzcwNFM1S0tPVkU1aG9LVEdQYWVSUDFiclNxdWxSUVFPQTRYcjlOT055?=
 =?utf-8?B?d1BKZkZ4RTdTSU80S243RlZ3cGdIeXc2SUNrb3NBWXo3UFpBeUVwVCtFanFi?=
 =?utf-8?B?c1FxSmhURG5wWWRFaTIrY1hSNVBEb0hBMGU4U3RFWDk4UUtCMzlrRDNtZURp?=
 =?utf-8?B?R3ZNQll3UTJTVkUveFhxUitkdUdES0txR21FN0ZENlo4bzJNUE03TDJKSDA2?=
 =?utf-8?B?V0xSTGFKODY5VU51cGROK1lRWldTbjZKcGpWMmczNEt1cktVM25adEhMVkMy?=
 =?utf-8?B?dkI3a3kwWlJRbjY1bzhwUnBRdXdwU0lieWQ0aVByYjA4eUk1anJmeGprbVc0?=
 =?utf-8?B?RzY4ZlNFb0F5UjFsQnVtZndxZTlKc2RiNzJJYkhyMjlZQUVDbks1Y0Nob3U0?=
 =?utf-8?B?ZVg1VkIzWnpwRjgxV3FHalZxc3l1Z0tTT08xQnNVQklRNFd2MHNEUTU1M0Vi?=
 =?utf-8?B?VmtzcWhZU2JCMkhZeDVEU05MMlNBZVRlU3hnSXZuT3lweFRTb3dPclYyWGQ0?=
 =?utf-8?B?dEhVd3dObVRHNDRWV3hrNEZQUTJmalpIMzVQTHhpN2xMZ0ZXUWU0VVFPMlJV?=
 =?utf-8?B?dGVud1JvS21zSW9LZmgzU0w3KzhHdnFzYWliYzdWSUd6ZTBadWJPYWQrcSs1?=
 =?utf-8?B?c0NFZVBVdXBXNkhkWVRwdGtRTWNTQUxpWWRYRWY5NTlnL0ZkTnBCMEFxK3NZ?=
 =?utf-8?B?Y2hFQlA2Q3BNeWNpeWhOQlN5M0RFVm9SWE0vd21kd0hPcDk0QTV5L1k2SjBm?=
 =?utf-8?B?U3VPV3VmZDNjZ2hMcjZXeXhsTDhTcVNjSHpZQUt4WHhvbk1iMFNCaHpPeEs5?=
 =?utf-8?B?RjlsT1lhcitHK2VNdHB2Q1hRaFU0U2FqNzhvQXFTSDRaLzhTYW8yYnVQcEZz?=
 =?utf-8?B?bEwyOU5zMXhsUFBOYkphaWlnS2VDU2lyZ1dldkJpaVZWUHg4YTMreE05VGdE?=
 =?utf-8?B?SkMwbVNhTWZsL3hxNDgzYnJzYWNpaUU1S2VGZitMb0I5U1liZjZyaS9XT0Ur?=
 =?utf-8?B?RE9nYUpUb3JNMHVlSGE1Wm82b2JBY2RYejE4a2VsUC9nRmVTdWFvQ0tWYnA2?=
 =?utf-8?B?VzNkdlhKRXhtRVpkKzhlV001bUl1bWF0L25SZGh6cVB5VjI2T3Q0S3czaUcz?=
 =?utf-8?B?Tk1NUHhTc3pmVXJEWDM1YWZveU0vYk1QZVVjd0k0V1h1K1VlQ2tFdDd4d0ZO?=
 =?utf-8?B?TE5YV1gzeXpzODhNa05WNjluLzl5RkpCd1huLzJ3cDVCK2hZUjRWV0dGWlI5?=
 =?utf-8?B?eWRhQjFHSHZaRTdlb3Bvbm5sQVFpVkVFQXRzZ1UwbnZyRWUrVGdZWWVndzZp?=
 =?utf-8?B?eDZqK2YwT1dwNVd1OXFjZy9ITWJIRW8zYVpNZmhJZFl1c091RllQYUVtRjhE?=
 =?utf-8?B?SGpVWURxMDEyNzhIUk1hVzVhUlUzbzJqTTkvU2JIOEVzems4blhSVmN1SDNQ?=
 =?utf-8?B?aWoyTHJueWZwRWZmZ2o2bWpEdW9weHYzcnhvKzZUbUpIeGl0RlVpQjlUVU55?=
 =?utf-8?B?NXNMVDRiQ0JJUysxY2svNVlxVEpoeXNFUDFMcG94aU45UmFBc3ZBam5abTV2?=
 =?utf-8?B?WHg5UnlETVRlQUlpUmVodjh1YUJFNENBbXZYbDZqNkZlbTVKT1pRSTkyODlD?=
 =?utf-8?B?c1E9PQ==?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b16f26c-1ebc-4b90-1cce-08dac855c6c5
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5764.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 04:39:56.1115
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uXhia86VyoW3iAmgboxUl3D66/WqqSeCmC94nZjR8e4+GUG+NLdE6gIpdyPujz1f5gFQtVQCSwUQMwbByIIFEMa0eGzwHcvaFmr2qPn0XE4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7028
X-Proofpoint-GUID: zZF9qCndVSTQdLau22-mRJjQUmpQwS8v
X-Proofpoint-ORIG-GUID: zZF9qCndVSTQdLau22-mRJjQUmpQwS8v
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-17_02,2022-11-16_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0
 malwarescore=0 mlxscore=0 bulkscore=0 phishscore=0 clxscore=1011
 priorityscore=1501 lowpriorityscore=0 suspectscore=0 impostorscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2211170032
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/17/2022 7:22 AM, Florian Fainelli wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender 
> and know the content is safe.
>
> On 11/16/22 06:43, Xiaolei Wang wrote:
>> The external phy used by current mac interface
>> is managed by another mac interface, so we should
>> create a device link between phy dev and mac dev.
>>
>> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
>> ---
>>   drivers/net/phy/phy.c | 20 ++++++++++++++++++++
>>   include/linux/phy.h   |  1 +
>>   2 files changed, 21 insertions(+)
>>
>> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
>> index e741d8aebffe..0ef6b69026c7 100644
>> --- a/drivers/net/phy/phy.c
>> +++ b/drivers/net/phy/phy.c
>> @@ -35,6 +35,7 @@
>>   #include <net/netlink.h>
>>   #include <net/genetlink.h>
>>   #include <net/sock.h>
>> +#include <linux/of_mdio.h>
>>
>>   #define PHY_STATE_TIME      HZ
>>
>> @@ -1535,3 +1536,22 @@ int phy_ethtool_nway_reset(struct net_device 
>> *ndev)
>>       return phy_restart_aneg(phydev);
>>   }
>>   EXPORT_SYMBOL(phy_ethtool_nway_reset);
>> +
>> +/**
>> + * The external phy used by current mac interface is managed by
>> + * another mac interface, so we should create a device link between
>> + * phy dev and mac dev.
>> + */
>> +void phy_mac_link_add(struct device_node *phy_np, struct net_device 
>> *ndev)
>> +{
>> +     struct phy_device *phy_dev = of_phy_find_device(phy_np);
>> +     struct device *dev = phy_dev ? &phy_dev->mdio.dev : NULL;
>> +
>> +     if (dev && ndev->dev.parent != dev)
>> +             device_link_add(ndev->dev.parent, dev,
>> +                             DL_FLAG_PM_RUNTIME);
>
> Where is the matching device_link_del()?

Hi

Oh, what do you mean when some modules are uninstalled, should we delete 
the link?
My original idea was to wait for the dev (consumer or supplier) to be 
unregistered and automatically deleted, I read the comment of 
device_link_add, if DL_FLAG_STATELESS is not set, the caller of this 
function will completely hand over the management of the link to the 
driver core, then The link will remain until one of the devices it 
points to (consumer or provider) is unregistered.

thanks

xiaolei

> -- 
> Florian
>