Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2a5a8727-a339-8be3-5383-395033c07c12@amd.com>
Date:   Thu, 17 Nov 2022 10:33:46 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 1/5] cpufreq: amd-pstate: cpufreq: amd-pstate: reset
 MSR_AMD_PERF_CTL register at init
Content-Language: en-US
To:     Perry Yuan <Perry.Yuan@amd.com>, rafael.j.wysocki@intel.com,
        ray.huang@amd.com, viresh.kumar@linaro.org,
        Mario.Limonciello@amd.com
Cc:     Nathan.Fontenot@amd.com, Alexander.Deucher@amd.com,
        Deepak.Sharma@amd.com, Shimmer.Huang@amd.com, Li.Meng@amd.com,
        Xiaojian.Du@amd.com, gautham.shenoy@amd.com,
        ananth.narayan@amd.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
References: <20221117024955.3319484-1-Perry.Yuan@amd.com>
 <20221117024955.3319484-2-Perry.Yuan@amd.com>
From:   Wyes Karny <wyes.karny@amd.com>
In-Reply-To: <20221117024955.3319484-2-Perry.Yuan@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFY1NXhad0RlMW9IckUvNVUzNVhWWXJ0NEI3WG92ZTlPcmV4UU5QdUxueVBm?=
 =?utf-8?B?TWJDVGRETmRSMGlGVEE4N08xQTdKM1RCdW02K1FzeHJMMFBjNjVPSVNLdVlF?=
 =?utf-8?B?WkRBdEY4VWgxSjhTeTdkN2Jxc0RuTmJObFp1bEVNamsweVpjdjk1RmQ4WThX?=
 =?utf-8?B?YkpBeDdaUHl1TFFHZmtTOGtMK1kycGRMbmNmc2Y5TkZ2Vnd2TFBIakNTcGx4?=
 =?utf-8?B?YWhZV0hUaHBLRzE1ZjV6MjNMUFYxd29haUtSNnlyZFdBNzcvWmhiOEkwZXFY?=
 =?utf-8?B?bUhYZUNTY2p1QUdXRTllNEVJazUzaXl2dzVqR3lZOXRqTzRyZlFrdmRjNkp0?=
 =?utf-8?B?blhVYUc0ZmRpUll4TjZ1NzVnd1VzSmNFdGZHZlNYMEpncWg2V3l5YWo0NFhD?=
 =?utf-8?B?UkRLVTFSRDNLNjhnR1BHUERsNW1wak9wR2JUYTZLTmhqeXhuTDFsQU4yNkpB?=
 =?utf-8?B?cHUvbk9IYWpiSHUyUElWV2k3TzFQZXplWHp0L2xxQUYwTGY1MzFsUUN0ekFV?=
 =?utf-8?B?VzFyYy9NQkpjMjIrSVdCRDZheTZaWUJGenBheGQ1dEtTRXpubXRrQjE3MEFG?=
 =?utf-8?B?UnpQemlOZ29pU0p5NzhKZWZLL2dOTC9VRlVaM1FBUVRMZXNDN2NveDFReE9q?=
 =?utf-8?B?cU0vYllBaXg3QVdFTkIvKzRHeEs1b2ROM25Jc1kwZkoxZ2NnSzZ2V2tWelFR?=
 =?utf-8?B?MXZRaUFwaFJuRUdONzNLYlpYQWgzV0ZvNEd6YTlwd2FrSitINDZkSHduSkt5?=
 =?utf-8?B?TllXb09MRzk5QkhMUVpQR3VySmVub1cyM3p0ekJrNFRoaFNvVWV4YjkrOE9E?=
 =?utf-8?B?all3a08wcnVQckI5WnBJWEppSXg5WVhqSG85YkkvVUdBNnNaNjlFT1Z1S3dw?=
 =?utf-8?B?eFIzaDkwREFpUGx5M2VEdW1USldWSUxBZHpRcndXWTJrRmZ1S2dKdmY2cWRp?=
 =?utf-8?B?ZGZIcUQ2WVRqQkFRNU9JK04yTTNlYXc0ZmJIdFJBZGhDRHRMdGVDbS8raDZF?=
 =?utf-8?B?S0gwVktEVkxPZ2k1aWtMUWM3ZFRCMWtJbXRBenI1R3cxYTZNdklvOXM1VlRr?=
 =?utf-8?B?NUJxTGRCUFNhRFJrdUl6U29zWDRscTRWZDg1NlU5NDVFYmo1cnVuT2tkTWZ3?=
 =?utf-8?B?L2IwcVpnNEh0RGRzWFNJSWpSQVNrcHplTllKVzRkMGt4MHBMZW56RFZHOGVy?=
 =?utf-8?B?dUlqeEdnSDlSSUVtdHRIU3Z4Z1RCSU92ZDRQRzNoWFFFamVQclFxb1MwYy92?=
 =?utf-8?B?eG1EWFArTm5hM0R0ZW0xQU5lVUlqTGF5Wnc3VjQ4MTNSTS8wVllqbmxJUFpR?=
 =?utf-8?B?b0I1dkdSMkI4cnhrS2Z4c01FRkx3S3ZycWdRWDdNRnhiUDJKaEx1eWg3QU8r?=
 =?utf-8?B?OGkvZkNYUHpiUmxveDUwV3ZVVUgyT0FOV1hjR2FnVnc2amtvRVgwUUtvdXZp?=
 =?utf-8?B?WXpsNW1kUmFYWm9tRElFcDQzck81bzVtTU9RVnFNcldueE9lQTN3SzBWZ24y?=
 =?utf-8?B?Sk1ZeEZLN2hoMS9iWmJGNzZNbTRLSTRuWitjcU12Y0U0RXFXMTh5cGM2QnZJ?=
 =?utf-8?B?dUxBd2YxQmRiQzlja0FLeVVqNEttVUZidzB4aDBNSU1OakZIM1FHcElUa0Jw?=
 =?utf-8?B?SU1VSWgxQ0dhU1ZKaG1pc0ZpZEdOcjIwL1NGZGxxRm1SbWdPdGFNL0FFSytL?=
 =?utf-8?B?NjJ0Y3NZb3Jta1dPUmNaR01zVFQxcWZRMm92Ync5MkVwQ2ltYXdxb240REs0?=
 =?utf-8?B?U3RxVUJJZXlhWk9GUWZ1UHJCeWo2L1djRTY5UG9XU05KVTlNNmt4dGxTb2lX?=
 =?utf-8?B?MllSTmZjanUwZG1wSDdnL0RHb1pLVXE0M0VENGpGRjdPQmNQeXhoeG9YY3NV?=
 =?utf-8?B?N0dSWjI3TUJ6cS9qcmdsNnV2ajFaOWxRcDQ2ZW0rQUJUTHo1NWw3NytOZUhj?=
 =?utf-8?B?Nm5aZVo4ZDdtYUFmUTFmNS9ocEw4Mngxb0pqbjBiWnYzRm5kSjZSM2c5MVdl?=
 =?utf-8?B?Q0xUOUxUNkQydkh2S3cwdWdGR0VwaTZYV2JxdjYrUXozTWtJYTZrV3pLRDU3?=
 =?utf-8?B?N3ZxQytUK1hkb285djN3U2NlMmUzRStZcTRSVDV2Y01mVXhUMnFmc3VnYStI?=
 =?utf-8?Q?yGk3UwCYMIB+DiEZdIg2F9MTy?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa4d3013-eaed-4dc3-d5a0-08dac85921e7
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3876.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 05:03:57.6269
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fqztG5oTBfiWDmHUlGP/+pPcxih/oH254JzsGY7qWZ0mDvnYmirKdNTyj2kXvSEfeXzF89wKgsoWs25R1ya2XA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6559
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/17/2022 8:19 AM, Perry Yuan wrote:
> From: Wyes Karny <wyes.karny@amd.com>
> 
> MSR_AMD_PERF_CTL is guaranteed to be 0 on a cold boot. However, on a
> kexec boot, for instance, it may have a non-zero value (if the cpu was
> in a non-P0 Pstate).  In such cases, the cores with non-P0 Pstates at
> boot will never be pushed to P0, let alone boost frequencies.
> 
> Kexec is a common workflow for reboot on Linux and this creates a
> regression in performance. Fix it by explicitly setting the
> MSR_AMD_PERF_CTL to 0 during amd_pstate driver init.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Wyes Karny <wyes.karny@amd.com>
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>

Tested-by: Wyes Karny <wyes.karny@amd.com>

> ---
>  drivers/cpufreq/amd-pstate.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index ace7d50cf2ac..d844c6f97caf 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -424,12 +424,22 @@ static void amd_pstate_boost_init(struct amd_cpudata *cpudata)
>  	amd_pstate_driver.boost_enabled = true;
>  }
>  
> +static void amd_perf_ctl_reset(unsigned int cpu)
> +{
> +	wrmsrl_on_cpu(cpu, MSR_AMD_PERF_CTL, 0);
> +}
> +
>  static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>  {
>  	int min_freq, max_freq, nominal_freq, lowest_nonlinear_freq, ret;
>  	struct device *dev;
>  	struct amd_cpudata *cpudata;
>  
> +	/*
> +	 * Resetting PERF_CTL_MSR will put the CPU in P0 frequency,
> +	 * which is ideal for initialization process.
> +	 */
> +	amd_perf_ctl_reset(policy->cpu);
>  	dev = get_cpu_device(policy->cpu);
>  	if (!dev)
>  		return -ENODEV;

-- 
Thanks & Regards,
Wyes