Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2b004975-76d7-0db9-1ded-649c2da5a729@amd.com>
Date:   Thu, 17 Nov 2022 10:38:31 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 5/5] Documentation: add amd-pstate kernel command line
 options
Content-Language: en-US
To:     Perry Yuan <Perry.Yuan@amd.com>, rafael.j.wysocki@intel.com,
        ray.huang@amd.com, viresh.kumar@linaro.org,
        Mario.Limonciello@amd.com
Cc:     Nathan.Fontenot@amd.com, Alexander.Deucher@amd.com,
        Deepak.Sharma@amd.com, Shimmer.Huang@amd.com, Li.Meng@amd.com,
        Xiaojian.Du@amd.com, gautham.shenoy@amd.com,
        ananth.narayan@amd.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221117024955.3319484-1-Perry.Yuan@amd.com>
 <20221117024955.3319484-6-Perry.Yuan@amd.com>
From:   Wyes Karny <wyes.karny@amd.com>
In-Reply-To: <20221117024955.3319484-6-Perry.Yuan@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnBoNTFvZ1hSck5sZjg0ZlZEeExHRUs4L2dtUE5ZcjVLM1kyNTZ6cjAxU2ox?=
 =?utf-8?B?WTdRNUVzRWNmWDVsci9DN0h5TWtQakhYcjV4dnhlVVdlVlZ1bWk5TGFSUE8v?=
 =?utf-8?B?TSszODBHNy93TlZtcW9DWG0vMkJWRlVEQ0t1NDIrSmJlcVBJUU5JU1NpNXE1?=
 =?utf-8?B?bTRPcnpKWkRIYTJ5VzFZdFZBRURUL3hWN0p4alZYZEl3M3FCWFNwdW5tbWl6?=
 =?utf-8?B?d0dPeExGNzZuUk41VzJoY2xPNnpDWDY4ZUlqc0NLMnArU1JlMFNXQXhjVm5C?=
 =?utf-8?B?UzBMQ2E1SE5MRjVvSm1kVzQ3U3NacW4zWGRWWWI4bklQMWZYYmUyR2cyZU53?=
 =?utf-8?B?UHhsV0E3dEJrNXUyOWVxam45QnZ4L0Y5bU9TUmtBT3RjRlR0SEZtTXora0Nr?=
 =?utf-8?B?R1MxRnhTZGdDU2Y5ZlhlZzVxWGt5QWVrbnNrdUdaWm94UjZJVlhjTTNEWVBO?=
 =?utf-8?B?Ym5ORk1EMzNvVEFOT3hxbXA2NUxhOG1jZWRzdElnVDFMWWJpYjNSUVluUURQ?=
 =?utf-8?B?dGNQRkRYbHltK1h2c1l6THpEZU9FVUxKdHZwV090cW5wMVhvY0pkelRiUHYz?=
 =?utf-8?B?c2UxMzhyNlhZYzB0biswajVpNXQ2VC9JOEtDcDhCcmpYMTE1VTNaSVZSN1Ny?=
 =?utf-8?B?Z3hmdHhtVmdPUE1yWHNmZEtFUjVaUDhxTGY4ZzZ0QTNuYU4rTEdZNUN5U0gx?=
 =?utf-8?B?SVNCa3ZSaUV1L3dDQ1RVRERqVGpBaUtycS9oQ0cyNmZXQ1BlVDBHOTlsL3FG?=
 =?utf-8?B?cEQ0VjNJMU1scWdiNVA5SmdWamRqVHNOQWduSmVudS9kbFo5VjdDTTdWbWo2?=
 =?utf-8?B?bnBnNGhGSHpYTHRJU2pLWWF4Qlk0TW93L2VSTk5ucGNkNnA5N3pLWnZEY2Yy?=
 =?utf-8?B?NEtEN3dIV0VlWVlwcEhPYzRuMEExUXNRZ3JHVitWdkttME8xSGZTMkpoQjMy?=
 =?utf-8?B?TTMxS1BMbXBuVGppTVRDN2RJaVZwOGVObWowOHVjTnNzZXdhSUxXby9BbWdQ?=
 =?utf-8?B?dC8vWGVXWS8wU0lBRmtFU2gyVjhXbVQ1bWZQNWlrUEIyL3hSODAweXhiYnBH?=
 =?utf-8?B?a2UyOHA5VTBCNnJJdnNOQ2paV241eGxEdFRobWVqOS9GTVgyL3dOOXk3cWpM?=
 =?utf-8?B?cGg2Qnl1ck8rZng0L1ZJVTFLanpyaWxkWHBvTlo4QkZ4aGtzU1p2ZkJDb1Vy?=
 =?utf-8?B?c05mMHRHWHN5UitwaUdkM1NZaUplNUNGbFcrZHl1ckNVUFJLYlBERlVieXN5?=
 =?utf-8?B?Tm9sTS9YL1hmMzVoWWNLemR2Q0I3TUdod2xTeEJnbkc2Qk4zL1dyOHliVkF5?=
 =?utf-8?B?c1BjVTkzZXg4Q3dwRVkvQmZqQU1Ma3JOdC80ODRCNjFBQVBsM0tybjRncjFR?=
 =?utf-8?B?Uk4wS0dleUJ1bThNbGdGWFRkNzdoSDkyeHI0alMrTzAvdkJ0RkhaOVFEelhx?=
 =?utf-8?B?bStGMzJyUm9MT0RyN1VVR2Rvd25LV2tJczRGbTJLRlN3U3lBN0dzbDMzTVRr?=
 =?utf-8?B?VitqZkpMekxhaWRoNWhEWG9nekdxSU92WXZSbUZSYjdWQkNqTzRrdUF0YWJw?=
 =?utf-8?B?WHdMeEszLzNpak5SOUlQVmkvMXR4U1ZXVUVURU9UUjJSSTNYdGNPZzJEQTB3?=
 =?utf-8?B?amEyNnMrNmF3MjluVmhHaHc0dE0xcm5uR0lDVXdBeXp5em1tS0VOaGlGWUxq?=
 =?utf-8?B?dS9VcTVKTXExZDY3MlBYNDdCOElsWldRVEVQMm13dDlYZE5YTHhZZktjTk5m?=
 =?utf-8?B?YXFQQ0ZSdkpwMUxTc2RYUHV4cjZpNVVxamRTNzduaVFMN1hFdlZraTAzT0po?=
 =?utf-8?B?MW5HR253QXBMZkhucEJKZzhjTWlIYmI5M1habkRiV3UvbldUQmNEUytnbVZL?=
 =?utf-8?B?TXVoVjNLVFF4R2lDeTY2UHowOW5IaDA1czBIOEJkcU01Vm55aGhTaVlpSlBB?=
 =?utf-8?B?MnNuUTFMdFd5TTQyUEduV3QwUXlTZ2ROcGFoL0dHa1JmdTRXR3JjeGdWeHJL?=
 =?utf-8?B?aW9vRy95d3pCaDVQeU42R1FnOVBzOUtxT1VTdmd5MUlFcGkyNTMweWtPVElX?=
 =?utf-8?B?c1RYTUpySmRWbGJVcUN4SlVtZUVTR1ZmWGNtdy9BRmhnYlkzVHdVVnl0NEpp?=
 =?utf-8?Q?mwcMPDpkgoeke+HMahDGSPe4S?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 490965f4-e07b-4b92-4289-08dac859cc45
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3876.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 05:08:43.4206
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LMjNdqvRRSwJlZP9lY7lZJM+5Ixf6MgB2nxRBgXZhHMc1eeUhtRYDign0uoII7D5L4B4SSAZuPoOAdUuhnPfjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6390
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/17/2022 8:19 AM, Perry Yuan wrote:
> Add a new amd pstate driver command line option to enable driver passive
> working mode via MSR and shared memory interface to request desired
> performance within abstract scale and the power management firmware
> (SMU) convert the perf requests into actual hardware pstates.
> 
> Also the `disable` parameter can disable the pstate driver loading by
> adding `amd_pstate=disable` to kernel command line.
> 
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>

Tested-by: Wyes Karny <wyes.karny@amd.com>

> ---
>  Documentation/admin-guide/kernel-parameters.txt | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index a465d5242774..42af9ca0127e 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -6959,3 +6959,14 @@
>  				memory, and other data can't be written using
>  				xmon commands.
>  			off	xmon is disabled.
> +
> +	amd_pstate=	[X86]
> +			disable
> +			  Do not enable amd_pstate as the default
> +			  scaling driver for the supported processors
> +			passive
> +			  Use amd_pstate as a scaling driver, driver requests a
> +			  desired performance on this abstract scale and the power
> +			  management firmware translates the requests into actual
> +			  hardware states (core frequency, data fabric and memory
> +			  clocks etc.)

-- 
Thanks & Regards,
Wyes