Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1625485rwb; Wed, 16 Nov 2022 22:31:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf47U8hxXtgzrEI5Pitd2R/VWh+BAAdFMs4dEGLeRrwCcoeIbf6MzQ8wUI4F9uXZnWG/kXjV X-Received: by 2002:a17:90a:67c1:b0:212:d484:b410 with SMTP id g1-20020a17090a67c100b00212d484b410mr7391115pjm.211.1668666702874; Wed, 16 Nov 2022 22:31:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668666702; cv=none; d=google.com; s=arc-20160816; b=aqgx4pXNuHjRQ0OIQnqvODgxz5t7J4C0/DXXg+Ctkw9wlKQUxyQUB5odv3b/QOlFWj r4ADTk+1fqEuNqyEOZVC1i5+X0GtOgFxK7kCBHU0wGDWSkTetCurc02kTeY6Io4Zx6A1 G96Lgo7HlzjhDIVdT43l8wBLRlkdn05XAj1JmJkP4OWbkN/FzEHzF30eacRa27VH3cEo qj8nRqMJbgQ2zZNUj8CG8E0eOqnF6AAT7HSyPTRSISPCNAktxKr11iI1CBZdxSQiz08A wcW6A2la87htp1hEmWn9lR036GjtyCvtwgnuU4WZb5bdEje49MEa6qPWkA338T2lRy45 NoQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=oYkLvPPkUUlFvOfLMkG1YO/c1AMDYnkpSXIR9noBSbs=; b=HXklVeXXs9kQG56Rbap+KJFfJY0LRhXhMN3QhVhBb5eQDkZ5qZiIeDrlKvq6GOXRrH vHDly0dIkfDr0ug41iU5kujqnG7Kme9SfXbLPlCFhu/2FpYlLXFYYHpmK8175EFMklf4 D9mf7xHIiCVzTFZSZUCAvAbgJ88UhsbZfanlzkG+BS0SMOrIlTEBFwWWvJ9qCPx63XcO XVvriQq6y9BwPpvg39jxvqgUnR/RgAOwOIM5Vypv60PpcqEKOBeIWucjD6Xa/Vzlme90 jrEgahEL/AOToNAVQWEPJwN/XBNwWFYZAkhOGvPOOwAIByMAgdgJYRbUwpN71VFCYBRH JDYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=JERQWmzs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mi12-20020a17090b4b4c00b0021409ca96c2si113816pjb.23.2022.11.16.22.31.31; Wed, 16 Nov 2022 22:31:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=JERQWmzs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238973AbiKQF4K (ORCPT + 90 others); Thu, 17 Nov 2022 00:56:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234427AbiKQF4I (ORCPT ); Thu, 17 Nov 2022 00:56:08 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49C3B40906; Wed, 16 Nov 2022 21:56:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oYkLvPPkUUlFvOfLMkG1YO/c1AMDYnkpSXIR9noBSbs=; b=JERQWmzsatc0AhN0FUeVFlzFcz 5HN1sqTqGGj4/xDhC5WhgUofXX6ig9XC0b4tSyf5nVAYnoVHJA5zv3PobTRCPZAhOu0nYCN9cx7HQ fQsQGE9H/i5u3W/xw1oGIswcjSZU8lkmUxDbDJTLl8SKLnWUFEm5EX4yEmugDxU7p575t5fn2BN7k EcnV4UAD/OcxX0yFlDD19cba8mIQ/aMNs0WCByh571SXO7Yhp4xYK19wtmT7Mdps+AB6yyB46Up5Z ZJxbCI7bMezwxbYrN8zVQ6MBpXqo/lfwO4j4ANaw0907YtajLI4nfKv8qBYvuEZ+JyXkAV5qGiKxy BqXKL+SQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovXsR-00AZrQ-Nu; Thu, 17 Nov 2022 05:55:55 +0000 Date: Wed, 16 Nov 2022 21:55:55 -0800 From: Christoph Hellwig To: Daniel Golle Cc: Christoph Hellwig , Jens Axboe , "Martin K. Petersen" , Chaitanya Kulkarni , Wolfram Sang , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/4] init: move block device helpers from init/do_mounts.c Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 17, 2022 at 12:42:43AM +0000, Daniel Golle wrote: > In init/do_mounts.c there are helper functions devt_from_partuuid, > devt_from_partlabel and devt_from_devname. In order to make these > functions available to other users, move them to block/bdev.c. Yes, they should be moved and I have an old patch to do this a bit smarter. But that doesn't mean anyone else should call them.