Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 17 Nov 2022 14:46:50 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Yunying Sun <yunying.sun@intel.com>
CC:     <tglx@linutronix.de>, <peterz@infradead.org>, <paulmck@kernel.org>,
        <longman@redhat.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clocksource: Print clocksource name when clocksource is
 tested unstable
Message-ID: <Y3XY2shpqb3Nn9ZI@feng-clx>
References: <20221116082221.25243-1-yunying.sun@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221116082221.25243-1-yunying.sun@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sgI9/FuuRanc3yfzI2pR1cQJO7csNStgQerFRq67hC2KK3xMZKaJs/uNmPQL?=
 =?us-ascii?Q?YFZPKPvdi75YUdkRYRyXINVEKiMkVVi3uvrVePYmRKT9lRTHZMd9v/LURGn/?=
 =?us-ascii?Q?W/6G3JqT8FLzDhA4Wfm6g+33ZGI4i8UaxHjDg8qrEzPcMOwNBmdmaxsARCVG?=
 =?us-ascii?Q?Qgqzs1nCI7ll3BXdKu7DMdGMdXXtCLAxTWmtWOk702PLBR/6S1qCNxtJQxu5?=
 =?us-ascii?Q?4Rsa3LzjmfcyRCRZrX931toXLmTDSsFd7+pv6rcFCMzI2Q1aEqd+yTpGTOzT?=
 =?us-ascii?Q?T7uVevw6bWW95Q7deIxsYLIg97bm5quMZRouBXA2VXWxWXHAZM2+QUOs7g9O?=
 =?us-ascii?Q?TK/HXLplzEu0uiLKkzplSXz/OG8f1US1g8H/c2NGmqQhuiNBjBDXNAD/jFak?=
 =?us-ascii?Q?d0aKki/6vTWTNJyRswJOOZXSxyS2TOypWJvI48zsG1/u82PMXGxoiLnuJ7/V?=
 =?us-ascii?Q?AlfDRgUdW2j/YtS3Z31h/2DHbPcQiRUMXJs9ngrm8INRjjeT8WLqqcr5ghsH?=
 =?us-ascii?Q?dcjYo/bvyZovQWeVwZ4ixEsTDTeJqmfOfOs1IHi7cTVf6Z1I3d0y8dFRN3YO?=
 =?us-ascii?Q?Ulg8xwlXPV3KA5SPg02JuWU4aVsDtoHIj6Xt9TmVOv4/toH5WQdirskMg4YH?=
 =?us-ascii?Q?5w2z6FTcvuCD4jj+mRZi9TNX3EFBnqtAKdQY4zOdWF4IZFIWM5iJyBtr3mZD?=
 =?us-ascii?Q?IHKegp6Htgl72gl5UJdOcJ+4mKId5x6Uv4R8TSCASiziaxR9PAhHsDgc2p5B?=
 =?us-ascii?Q?0rExvYaFTdCa9snoH9aB98MQ8Alne5qOrwIZ3UtDDNEGqNqBDCSKzQap4lwE?=
 =?us-ascii?Q?w+3EAIgyRaMmoBI62qVvXOxv2LS+PqSvgnmi28j2P+7k7R8rD6Zmj2ORfrC7?=
 =?us-ascii?Q?4wjbnTMNuysZ0BZHvjB1TRCWavwLoAypJcaBn18dsZzpSDmmk0UtYT6dmnXh?=
 =?us-ascii?Q?kOO/Das1wsHJspnNEGi32hYWVQ4AXPIO9ZyPDcb6uTNzqPQmdGcAEVHumbT0?=
 =?us-ascii?Q?YZ/lm2TGo6a1CA6uSiF8H1MU63odavGBrvfJUPpKK8tM8PNjLc/8mDQFTHyS?=
 =?us-ascii?Q?XIzM/FqDHCu5v8rIM7p1F7Svvg1t+Cp1ja04LhjtZwYlA4hgtXqNxIwF6Yxd?=
 =?us-ascii?Q?mkEhTL+wOH8Ms2aEz03nUqru/AMPk9N3SNxXg8QsVOKrm2sZQH1wIxJ7nBle?=
 =?us-ascii?Q?ud+VWslgxyCF+MVS6TRw74ySUk8CGa9XwpBKYPa8ctymttZVk8GupyO4i+/1?=
 =?us-ascii?Q?7yPZYqEoWvw6Ug70lMxeMRcB/ASmD+QchcIvzOqktsEah+149n1jT1j2VgWy?=
 =?us-ascii?Q?ZN/nq3BNVgoBTP/ydMW6LhsetrX8mW5LzbT6lh/OQQZfAMsPBWezR6pC5toS?=
 =?us-ascii?Q?iGJB/0QFU8RZQyPRg3fK2B+bWu+iOjap6Gv9c0JeWHwVv85okv7Y1bNEnfr2?=
 =?us-ascii?Q?lJfhd7k1a1qh9lOdSAXjqd4J+pEWpURHIsvZMAIFRATHdjJ3j8EYQmWH/h2x?=
 =?us-ascii?Q?BM3wlgVpwyBkgiqFZ3fqxN1ccAPem7cyB+U5LJzcca+oqyfjM1Exz6ChvYXM?=
 =?us-ascii?Q?EqX43/QEN8VEbuN0KtZlg1/0mI/Cs6wnEHOSCKcg?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b8b0ce38-eb2d-4bb4-d2ce-08dac867f26b
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 06:50:00.1935
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x/BAfRS9R5lOLSf0DSY/fizwQzzG+/0iHYTd67ulF8XEHn3UShumNQxiDPp1w4b29AM3TsfcPK74Vq04zVV+nA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5040
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 16, 2022 at 04:22:21PM +0800, Yunying Sun wrote:
> Some "TSC fall back to HPET" cases are seen on systems that have more
> than 2 numa nodes. When this happens, in kernel log it has:

Hi Yunying,

If the system's physical sockests number <= 2, I would suggest you to
try the patch https://lore.kernel.org/lkml/20221021062131.1826810-1-feng.tang@intel.com/,
which is still under review and discussion.

Thanks,
Feng

> clocksource: timekeeping watchdog on CPU168: hpet read-back delay of 4296200ns, attempt 4, marking unstable
> 
> The "hpet" here is misleading since it prints only the name of watchdog,
> where actually it's measuring the delay of 3 reads: wd-clocksource-wd.
> 
> Signed-off-by: Yunying Sun <yunying.sun@intel.com>
> ---
>  kernel/time/clocksource.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
> index 8058bec87ace..fac8c0d90e61 100644
> --- a/kernel/time/clocksource.c
> +++ b/kernel/time/clocksource.c
> @@ -257,8 +257,8 @@ static enum wd_read_status cs_watchdog_read(struct clocksource *cs, u64 *csnow,
>  			goto skip_test;
>  	}
>  
> -	pr_warn("timekeeping watchdog on CPU%d: %s read-back delay of %lldns, attempt %d, marking unstable\n",
> -		smp_processor_id(), watchdog->name, wd_delay, nretries);
> +	pr_warn("timekeeping watchdog on CPU%d: wd-%s-wd read-back delay of %lldns, attempt %d, marking unstable\n",
> +		smp_processor_id(), cs->name, wd_delay, nretries);
>  	return WD_READ_UNSTABLE;
>  
>  skip_test:
> -- 
> 2.17.0
>