Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1655405rwb; Wed, 16 Nov 2022 23:11:18 -0800 (PST) X-Google-Smtp-Source: AA0mqf7eL1+VVXzKEvm+pZvg4QxcjtmTrODfE3SXlzKRwixOi46ATMDs07iZ/N/MVniFv5YW3kTy X-Received: by 2002:a17:90a:ad85:b0:212:e5ad:cd3a with SMTP id s5-20020a17090aad8500b00212e5adcd3amr1497751pjq.122.1668669078226; Wed, 16 Nov 2022 23:11:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668669078; cv=none; d=google.com; s=arc-20160816; b=W4NGsn8dlibjp+E2bS2Lol0XEqojXkOm+TAp7WqsVrDQ7Tmxols7SOBNR/ZjTSSM6x WZw92YTgYQ1BDmsiILc71AswcS7OVi6hV218YMkiqlP0f76V/Q3CJklbcYsV6WPcGfhv 3rTOgYLmQVixlaLQwl2L8kwGgah9S1bD5EA5XpdzhJt2NMMwSk2o6TPVMdwEe/h3mXVA jQL9So5rpYHNfznWPNCtUah13Ybvfzpx0JR2JS8UtFBgxmJSMSeo1JWeSLVdeB1zL3tl /VAM4ovNtJJ9dZA8Ci3bZWto9vviF3iTu+iypGkPx0qjd5oDTdIyzHZZLfWBispiWy8v WjXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=2WUtxmZVHazdfy48nj44/32KCdWsiltJ5vnxQYxAyfU=; b=SuhIvDa+RVLskcYahgFyey4ooJbVe51apwvcJXtB71CzWmPl9bQCKOsH1LQl4NAYx0 4uimq/NxNhQXGRjFa6J9qpQOAcXK6XVyYsaM/iAbVrG3ADuJVdBLbzBRro3xJ/brJEM0 Ok7a0IX0dhPRXaoNmp9AGcBWqHwvIz82fMoei+NTmM2CkfqUs1IJtDaYyxz9bmxXqIC0 DRvQMPlP1nhFXc/Kq0riIiXpQUvmr1N4dz12abf4it0kylLbAsdC1ww6W60Vio7FwG1P RjUWES7ueWHs0escKcB3o6VP4XAH9Qzsz8WDa4bzGqmYlkaC5Jvz70sF9wCpYwv7lUYk lAKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=AhXt1mCd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s10-20020a17090aba0a00b002180fb55c0asi3540512pjr.154.2022.11.16.23.11.05; Wed, 16 Nov 2022 23:11:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=AhXt1mCd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234421AbiKQG4E (ORCPT + 92 others); Thu, 17 Nov 2022 01:56:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbiKQG4B (ORCPT ); Thu, 17 Nov 2022 01:56:01 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A1ED5B588; Wed, 16 Nov 2022 22:56:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668668161; x=1700204161; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=0/YiAsV6EgKMRnLVAn0TpDJukNZYyLzxN/mv8BzeD5w=; b=AhXt1mCdy4MC3PGjf0pPuBI87jcL8PjH05Jw8BSeCyMlueuX3upA6M1U adOgCJkFLDePqg4+ywEsHyBlTrpVOfCRdO3+mksm+P4xCk2LeahGlZPyV 5tlY+rB2FfWlaVNfoH38BPqbRmHOBu6bLl+BHFcrbXfo1++m3DivlxNys mmGxSrGCMAbYPUeVJvpk6/VWi4dt5yENgfdeDUgIMYizPzrIHJyEWbwaL VzGR2+145uGaseaHAlECXiDxc1TbIAXmobXhzhX/jXY+axpSwcc0xxyof OQRl+Mef/MnJBMXb+VvcctkVBG/P6SAEk1ICmKWfSfyFfgtCRP/NiHw8N w==; X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="296138245" X-IronPort-AV: E=Sophos;i="5.96,171,1665471600"; d="scan'208";a="296138245" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2022 22:55:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="884738990" X-IronPort-AV: E=Sophos;i="5.96,171,1665471600"; d="scan'208";a="884738990" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 16 Nov 2022 22:55:53 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ovYoQ-00DT8H-0T; Thu, 17 Nov 2022 08:55:50 +0200 Date: Thu, 17 Nov 2022 08:55:49 +0200 From: Andy Shevchenko To: Kumaravel Thiagarajan Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com, macro@orcam.me.uk, jay.dolan@accesio.com, cang1@live.co.uk, u.kleine-koenig@pengutronix.de, wander@redhat.com, etremblay@distech-controls.com, jk@ozlabs.org, biju.das.jz@bp.renesas.com, geert+renesas@glider.be, phil.edworthy@renesas.com, lukas@wunner.de, UNGLinuxDriver@microchip.com, colin.i.king@gmail.com, Tharun Kumar P Subject: Re: [PATCH v5 tty-next 2/4] 8250: microchip: pci1xxxx: Add serial8250_pci_setup_port definition in 8250_pcilib.c Message-ID: References: <20221117050126.2966714-1-kumaravel.thiagarajan@microchip.com> <20221117050126.2966714-3-kumaravel.thiagarajan@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221117050126.2966714-3-kumaravel.thiagarajan@microchip.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 17, 2022 at 10:31:24AM +0530, Kumaravel Thiagarajan wrote: > Move implementation of setup_port API to serial8250_pci_setup_port Don't you have a dependency issue here? The subject also wrong. This should be 'serial: 8250_pci: ...'. And for your code something like 'serial: 8250_pci1xxxx: ...' in the rest of the series. -- With Best Regards, Andy Shevchenko