Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 17 Nov 2022 09:20:50 +0100
From:   Samuel Thibault <samuel.thibault@ens-lyon.org>
To:     Yureka Lilian <yuka@yuka.dev>
Cc:     gregkh@linuxfoundation.org, chris@the-brannons.com,
        linux-kernel@vger.kernel.org, speakup@linux-speakup.org,
        w.d.hubbs@gmail.com
Subject: Re: [PATCH v2] speakup: remove usage of non-standard u_char
Message-ID: <20221117082050.54uhm54udqatdlru@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Yureka Lilian <yuka@yuka.dev>, gregkh@linuxfoundation.org,
        chris@the-brannons.com, linux-kernel@vger.kernel.org,
        speakup@linux-speakup.org, w.d.hubbs@gmail.com
References: <20221117001244.212047-1-yuka@yuka.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221117001244.212047-1-yuka@yuka.dev>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
Precedence: bulk

Yureka Lilian, le jeu. 17 nov. 2022 01:12:44 +0100, a ecrit:
> This code is included in the build tools makemapdata and genmap, and it
> expects that libc exposes a definition of u_char. But u_char is not
> defined in either C or POSIX standards, and some systems don't have it.
> Namely this breaks the build on hosts using musl libc, because musl only
> exposes u_char if _GNU_SOURCE is defined.
> 
> Signed-off-by: Yureka Lilian <yuka@yuka.dev>
> Cc: stable@vger.kernel.org

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

thanks!

> ---
> Content is unchanged compared to v1, but hopefully the patch is not
> corrupted this time and I added a cc: stable
> ---
>  drivers/accessibility/speakup/utils.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
> index 4bf2ee8ac246..4ce9a12f7664 100644
> --- a/drivers/accessibility/speakup/utils.h
> +++ b/drivers/accessibility/speakup/utils.h
> @@ -54,7 +54,7 @@ static inline int oops(const char *msg, const char *info)
>  
>  static inline struct st_key *hash_name(char *name)
>  {
> -	u_char *pn = (u_char *)name;
> +	unsigned char *pn = (unsigned char *)name;
>  	int hash = 0;
>  
>  	while (*pn) {
> -- 
> 2.38.1
> 

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.