Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sun, Yunying" <yunying.sun@intel.com>
To:     "Tang, Feng" <feng.tang@intel.com>
CC:     "tglx@linutronix.de" <tglx@linutronix.de>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "paulmck@kernel.org" <paulmck@kernel.org>,
        "longman@redhat.com" <longman@redhat.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] clocksource: Print clocksource name when clocksource is
 tested unstable
Thread-Topic: [PATCH] clocksource: Print clocksource name when clocksource is
 tested unstable
Thread-Index: AQHY+ZJ1xXsis4rp9kmS/pgu4XQ8G65CrZgAgAAQ0GA=
Date:   Thu, 17 Nov 2022 08:03:07 +0000
Message-ID: <DM6PR11MB4092BD02BEB543EB4A28489FF2069@DM6PR11MB4092.namprd11.prod.outlook.com>
References: <20221116082221.25243-1-yunying.sun@intel.com>
 <Y3XY2shpqb3Nn9ZI@feng-clx>
In-Reply-To: <Y3XY2shpqb3Nn9ZI@feng-clx>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.500.17
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rIfQNa2/RE1zcm4KCbaIAFdRzZzPh14SY5G0px2XKATvB8Af3JOQCemzGrNo?=
 =?us-ascii?Q?z52L8Qk3QAStEyfXPvtgvYF9tmTWQxlL73aefn8fsP7cF01F1wMBamhdnPWd?=
 =?us-ascii?Q?vX1+UZb7JfPcVAUZnL9UjFR/P0NtRO6RQjfwyQ3otB+WNudArH8ERVuz1LqC?=
 =?us-ascii?Q?ZNUL2/9xcbZxKuU08uteU/i0mYEWL0mFw65y/WU5Zu2+AxTsqEXDP3w+S9jx?=
 =?us-ascii?Q?M9q82NMwraIu9iN35tNSNbXwOFJwXA45P+SkC6PRn+SiZmIDpq0j5X82M0Nv?=
 =?us-ascii?Q?DI7gz0vxXzOKbRn0SPeBvJvWST1E8ykMWMHSTfE0ZAv0R2PBB85hy6HXh6SE?=
 =?us-ascii?Q?jAgA6pvT/qnULgBo4KQekfA0CMPN1yMNUfLoU15dTS7fLVJCT5EvErMA1d9l?=
 =?us-ascii?Q?LS68eXy5iqj6jL3w/lTyaQskuMMOCQDiBDVCT171/JJzO7loV+FbPvuzbsru?=
 =?us-ascii?Q?kSyZxM0KCZmeJ4UeXANoHVU0FGw8cVMvxYHHn74mADrGM97iYH0KQH/XtIfx?=
 =?us-ascii?Q?g3nO+uAPVPKiLDy74wD0WnKk2JkcD56Qf5pE1mPEYHpImj6jHFI0Jes+RD+b?=
 =?us-ascii?Q?iD3na7L+Rv5Dc1/Zdb7iLjeVoRHNL1VTMVpeW5+f+et5CTNxw7ld+UJ1lVb6?=
 =?us-ascii?Q?EoshOIKd/ZdXc254Eok9ABeywGMZDgW1LcTigEh02ZxpU3O7/1yDj0frc1LQ?=
 =?us-ascii?Q?665U/CNS/MVbBHDSe1fxh/N+niEFnfqSFNmc5/kUPMwvcwnsHbBiu8UISBq2?=
 =?us-ascii?Q?lWS2tnXuALYYCUAfwnVEV6TxwUzplZt4gip1Oq69cuaD/lOs5AW1qsVNVEMA?=
 =?us-ascii?Q?Ip4qLOoJj/dXQJ8Y0xDHmFiMcT2zhX98s2K5bSfp/5zdwrNEJHRt+pPWdBZd?=
 =?us-ascii?Q?V3rp7XhUoVY5K1yI3GZsJLaEE8pBUzP0oKIdh45giwYhecnGEqzfunoou6/I?=
 =?us-ascii?Q?WonHrWZ8Cex/DXWtrQzYO+t33jKBfKykJGNpUlJmwPVi9pT6N7l15fUk5wZk?=
 =?us-ascii?Q?IzNaTGjDpsTWLwLhuYGUhjerghu4ut/Rg7iiusI6gfMjClcPfV2AzcVOAblH?=
 =?us-ascii?Q?TZw09I7sQBfVv2dywfJgiqRn6s/nZUfWRRazhoNsrIgY8GN8ryNm8PxQnLuh?=
 =?us-ascii?Q?cI1lDFSaSS2vaYbDwQc70YdPwUWjgz5LKWu1co2tewwKDKAZ7olDuQHvUqZs?=
 =?us-ascii?Q?TDJCqXpG4PJzxik1xnJqurWr0oYDqs2W17T8sbsH9q1tIWEqYlMpKT/hPIMl?=
 =?us-ascii?Q?qGunpgrAG3nxs2zciRwMHH59ZUteJNPX9MHA91wKre8tQyX577KQc6fhd26e?=
 =?us-ascii?Q?HwUJgD9fNWwZNJWaH7+0N/HiYJ8ufivVPiAejwDuNe/lGIi5F4EQ7sw4QIdU?=
 =?us-ascii?Q?EUvLEd39yGoG94/zITbnniSo793QlwTdeUWyeGs6eyLLqQje4sexWePKK9um?=
 =?us-ascii?Q?rf8H/XY9hTP5tYBG1su3bgklJ00NRKp5+vB6swp+EnTg5QUV8CUKaGHfE3np?=
 =?us-ascii?Q?g/e4u7yDiTSPqnPLjFIqxMV9Tbj1hbhcNSIEfySr59qn0UaZgS0mUJrJzOaY?=
 =?us-ascii?Q?m0ji+E/qyMQ3a63LCdz7qU5eGrUxWZBQBb7tJFEk?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4092.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 750ed92b-afa7-49a7-94a2-08dac8722977
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2022 08:03:07.3407
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iNVF3VctHL24uHq+8/TWFi3Hqwvrr1lzy/iQuw9f6X3PrzT5I4o6WPo8jcyG6vgsPoQoTH9/3lqK8wmjyHGn4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6160
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Feng,

For the "tsc fall back to hpet" issue, thanks a lot for pointing me to the =
fix proposal patch earlier:
 https://lore.kernel.org/lkml/20221021062131.1826810-1-feng.tang@intel.com/=
 .

I shared this patch set to our customer yesterday.=20
Just got feedback that customer has verified the "tsc fall back to hpet" is=
sue does not appear anymore with this patch set, after 24hrs stress test on=
 8 servers.

-Yunying

-----Original Message-----
From: Tang, Feng <feng.tang@intel.com>=20
Sent: Thursday, 17 November, 2022 14:47
To: Sun, Yunying <yunying.sun@intel.com>
Cc: tglx@linutronix.de; peterz@infradead.org; paulmck@kernel.org; longman@r=
edhat.com; x86@kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clocksource: Print clocksource name when clocksource i=
s tested unstable

On Wed, Nov 16, 2022 at 04:22:21PM +0800, Yunying Sun wrote:
> Some "TSC fall back to HPET" cases are seen on systems that have more=20
> than 2 numa nodes. When this happens, in kernel log it has:

Hi Yunying,

If the system's physical sockests number <=3D 2, I would suggest you to try=
 the patch https://lore.kernel.org/lkml/20221021062131.1826810-1-feng.tang@=
intel.com/,
which is still under review and discussion.

Thanks,
Feng

> clocksource: timekeeping watchdog on CPU168: hpet read-back delay of=20
> 4296200ns, attempt 4, marking unstable
>=20
> The "hpet" here is misleading since it prints only the name of=20
> watchdog, where actually it's measuring the delay of 3 reads: wd-clocksou=
rce-wd.
>=20
> Signed-off-by: Yunying Sun <yunying.sun@intel.com>
> ---
>  kernel/time/clocksource.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c=20
> index 8058bec87ace..fac8c0d90e61 100644
> --- a/kernel/time/clocksource.c
> +++ b/kernel/time/clocksource.c
> @@ -257,8 +257,8 @@ static enum wd_read_status cs_watchdog_read(struct cl=
ocksource *cs, u64 *csnow,
>  			goto skip_test;
>  	}
> =20
> -	pr_warn("timekeeping watchdog on CPU%d: %s read-back delay of %lldns, a=
ttempt %d, marking unstable\n",
> -		smp_processor_id(), watchdog->name, wd_delay, nretries);
> +	pr_warn("timekeeping watchdog on CPU%d: wd-%s-wd read-back delay of %ll=
dns, attempt %d, marking unstable\n",
> +		smp_processor_id(), cs->name, wd_delay, nretries);
>  	return WD_READ_UNSTABLE;
> =20
>  skip_test:
> --
> 2.17.0
>=20