Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 17 Nov 2022 16:35:43 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     "Sun, Yunying" <yunying.sun@intel.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "peterz@infradead.org" <peterz@infradead.org>,
        <dave.hansen@intel.com>
CC:     "paulmck@kernel.org" <paulmck@kernel.org>,
        "longman@redhat.com" <longman@redhat.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clocksource: Print clocksource name when clocksource is
 tested unstable
Message-ID: <Y3XyX24/kuafuqGH@feng-clx>
References: <20221116082221.25243-1-yunying.sun@intel.com>
 <Y3XY2shpqb3Nn9ZI@feng-clx>
 <DM6PR11MB4092BD02BEB543EB4A28489FF2069@DM6PR11MB4092.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <DM6PR11MB4092BD02BEB543EB4A28489FF2069@DM6PR11MB4092.namprd11.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y53bNp7XspSmXrAuUZsWNLuFHSgwIycBwn9Cpo/9NJQu/twnJA7+Ai20LZEW?=
 =?us-ascii?Q?MPG3WF1JhU7hIXpV7CV1X6ATpVfNfFtx3WiJPkj/jc/hBUN1tjjRDyRP17rW?=
 =?us-ascii?Q?Tbsb28b/UeQCy34cMk+X7ZBeUChc+HsZEH+8JfN1IUnENTGgwofM147Isuy5?=
 =?us-ascii?Q?ekLmrqt29wdtotK620G50byDfU4zfrFjhrVhipAyX952PYByAmOCQv63sTIU?=
 =?us-ascii?Q?CB84UfFNVpcM+w39w6FOlMfxi1h8iFkk7ipQApj+SXmyzTAeyAAB+N0QzHYs?=
 =?us-ascii?Q?ipkcq5CosICIBHFQJDbm4GNHRzZ9MtGvYDf3KUYJiS4Pt/DjWhWNyvRBFEHo?=
 =?us-ascii?Q?+SkvhZ6TNseGMJ80P+TtocJzty33UUthuGsmHQ7aAH6sVKCG0vRseCf81Mwo?=
 =?us-ascii?Q?trjDCUDNmDqGlZaI3RaPZCPuCTIwzSBEU8oZA28TMuDvPGJy4HcL2FhJzUE6?=
 =?us-ascii?Q?Fm8+1Z0eSCoi74Vs9aeI/MhMBo9KkAkK4TiyynARlGh8e6xLO4GtXB3dh71E?=
 =?us-ascii?Q?iXxLcV7ZtiSs2KoRKLDauM62zx4SBcm1wzmk9p8Cyh1QkWatvHm4K1OuZ/AH?=
 =?us-ascii?Q?P0GdU5QAwSvfOTn2DTXsvA5Y+msVmJdyO9FFvmkXM0/g0nDpB4nSWVjq5sk8?=
 =?us-ascii?Q?eeRMgLNC1OLzbZDXI1THfOkL9EIHOAGuxT5nY7dnr3pmc+pkuFD6nVBn+UTv?=
 =?us-ascii?Q?6/ERc2efqHecQdSeb4Y2Bhp99wuTTYu7DRZUpzfQCVP3mlMP52OLFoCdMZv/?=
 =?us-ascii?Q?tn9Y6Xs0hBMo3+UptB8tijE3Kz/ULtDHGTCPoGDCjP386MJkl9yWJuCcmSoW?=
 =?us-ascii?Q?kDtSErYUibdYw24NvbsnaYJmWA8E7LETQlT06ttj4CbLT2Xyg3y1B0ukPoPu?=
 =?us-ascii?Q?hGb7Jp9ePdJhIEvY34GikiXhYdAkNVRPInYq8dsba8bbSzzGHo5BV9Ju2Zs2?=
 =?us-ascii?Q?ZVE7D75Rij0MRMk7BqPfan7jpzQucmP1gpR7vqrlPKT7fctKUpbplGUCgUwE?=
 =?us-ascii?Q?cylvJLu8w8hyTSCQJzC3ZrHW/+Xm6wed5C/juSzbe5qJkr2LOJCiom6d4Maz?=
 =?us-ascii?Q?hNlfe1Z63Qrd2ulCKrhVthw5CqB90MqbIW75UxKGfaKVu/Hj+KXCQFZ3TJbU?=
 =?us-ascii?Q?nbbEgoN6TUt0C0EnMz/Xwmv7UrYcZZ32xIsMJTlRENBJpQJ6rdEj/cwX5Cip?=
 =?us-ascii?Q?32Hc2mD+RKugZvlvjx5JRigmkrocLFbMeLR+kkmOJG5jZcAQqIgE9lyqvj+l?=
 =?us-ascii?Q?EPzPOsqxzK7/nlZQX69YTkozA4+19Oik+lV845zpZE3UnOr+TDYVDkB6365u?=
 =?us-ascii?Q?1toFXmPERNwKtDH/dqcbaLu+frzF+B9Z/aj/phy5hTMNrOFZrZE5eqXABPJD?=
 =?us-ascii?Q?WZZP+7l7Kod1m98ulqNZuJDa/+OjVyGZiA4T0b/q62BVCxzJLeG92NWXMu54?=
 =?us-ascii?Q?oVFaQnU7tDFseLiu/uXNIMVDN5Tr1RU6h4CV3FQ6oNitOv1BcKJNBac8RzG1?=
 =?us-ascii?Q?jL3ysUwzj4u3zysAjZiTQUQyaLF6ovmac3Ye13HE8Iu/5CoDcZx0rYWGZaak?=
 =?us-ascii?Q?fQnqcmKI+i/sNjJPWf5B6Ebj3Kn40zBWnUAn5KW1?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 969fa182-8a3c-4c47-bce2-08dac8772895
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 08:38:53.7358
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kyZlwafu6d5Zpkbh7KxbQQkTyjfhVmy7O+azCUlVaK1tDxCPYgzomZoQvvkyU2xW8kjY1QJMYjRrA+HGx7kkkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4605
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 17, 2022 at 04:03:07PM +0800, Sun, Yunying wrote:
> Hi Feng,
> 
> For the "tsc fall back to hpet" issue, thanks a lot for pointing me to the fix proposal patch earlier:
>  https://lore.kernel.org/lkml/20221021062131.1826810-1-feng.tang@intel.com/ .
> 
> I shared this patch set to our customer yesterday. 
> Just got feedback that customer has verified the "tsc fall back to hpet" issue does not appear anymore with this patch set, after 24hrs stress test on 8 servers.
 
Thanks for the testing! So your case is a real case that current
'nr_online_nodes' check cannot cover, which Dave concerned about.

Thanks,
Feng

> -Yunying
> 
> -----Original Message-----
> From: Tang, Feng <feng.tang@intel.com> 
> Sent: Thursday, 17 November, 2022 14:47
> To: Sun, Yunying <yunying.sun@intel.com>
> Cc: tglx@linutronix.de; peterz@infradead.org; paulmck@kernel.org; longman@redhat.com; x86@kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] clocksource: Print clocksource name when clocksource is tested unstable
> 
> On Wed, Nov 16, 2022 at 04:22:21PM +0800, Yunying Sun wrote:
> > Some "TSC fall back to HPET" cases are seen on systems that have more 
> > than 2 numa nodes. When this happens, in kernel log it has:
> 
> Hi Yunying,
> 
> If the system's physical sockests number <= 2, I would suggest you to try the patch https://lore.kernel.org/lkml/20221021062131.1826810-1-feng.tang@intel.com/,
> which is still under review and discussion.
> 
> Thanks,
> Feng
> 
> > clocksource: timekeeping watchdog on CPU168: hpet read-back delay of 
> > 4296200ns, attempt 4, marking unstable
> > 
> > The "hpet" here is misleading since it prints only the name of 
> > watchdog, where actually it's measuring the delay of 3 reads: wd-clocksource-wd.
> > 
> > Signed-off-by: Yunying Sun <yunying.sun@intel.com>
> > ---
> >  kernel/time/clocksource.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c 
> > index 8058bec87ace..fac8c0d90e61 100644
> > --- a/kernel/time/clocksource.c
> > +++ b/kernel/time/clocksource.c
> > @@ -257,8 +257,8 @@ static enum wd_read_status cs_watchdog_read(struct clocksource *cs, u64 *csnow,
> >  			goto skip_test;
> >  	}
> >  
> > -	pr_warn("timekeeping watchdog on CPU%d: %s read-back delay of %lldns, attempt %d, marking unstable\n",
> > -		smp_processor_id(), watchdog->name, wd_delay, nretries);
> > +	pr_warn("timekeeping watchdog on CPU%d: wd-%s-wd read-back delay of %lldns, attempt %d, marking unstable\n",
> > +		smp_processor_id(), cs->name, wd_delay, nretries);
> >  	return WD_READ_UNSTABLE;
> >  
> >  skip_test:
> > --
> > 2.17.0
> >