Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7bf54a3f-07f7-5471-f6c2-88d3d9bc7a5e@amd.com>
Date:   Thu, 17 Nov 2022 16:03:54 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH] perf: Fix sys_perf_event_open() race against self
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     Peter Zijlstra <peterz@infradead.org>, nslusarek@gmx.net,
        Linus Torvalds <torvalds@linux-foundation.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20220520183806.GV2578@worktop.programming.kicks-ass.net>
 <700710fc-1ac1-1b39-0e63-eb86adb4b984@amd.com> <Y3Vkmvi2vib7fwHn@zn.tnic>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <Y3Vkmvi2vib7fwHn@zn.tnic>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUpJNUNHUWtsZXdTNWRMd2ZMY1I0M2pBcEY4UmF4OFZmemZ4T3ZWZDRKRG94?=
 =?utf-8?B?SzBlTVRrSFZjQ2ZrUWlCZ3lvL015eUIxZGtwcHEyUy9nRFNzWFVvVWR0RDRu?=
 =?utf-8?B?YXFiZW10Q0dsTGtsU3RrQ0hobjJVbXFzcXVxR3dORE9ZVElxQm1xdHFuNXMr?=
 =?utf-8?B?MW5SS2VPTWJwZ1F1YVJDOVgvWk5OWUpLeDVSN0RlNE9hL1h6TG9aUWVFc1g5?=
 =?utf-8?B?V0V4R2FSMGhmRFJoVlNXaXNnQXZlb0hpdklkVVFIc3BrUXhody8rRlhpY2Z3?=
 =?utf-8?B?blJOb0ZQSHoyTjdCdGhIdFJxMUhBSkFHeVlETW9VZEtuS1FwaTFDQytCS3dQ?=
 =?utf-8?B?dWZQME5PZ3NhRnNIUUI3K0VIRVQyNkRyVkNkZ3cwTi9vSGlrclFMcEYzTk9E?=
 =?utf-8?B?YmJlVnpZSkpCRWpKWnVWd2Z1UVlRZlFRZU1nTE9aRDVwS044dG1HR1BxWW5L?=
 =?utf-8?B?WlZsdk1YRzkwd2c2VU9sUDlINU1QWWE3Yjd5djlPRGQrbVhRVlA2Q25VWjJu?=
 =?utf-8?B?S0RBdWtudEJxalArOTM4Vjl0cUZuQWtDRGYwOWZHN28ybVRDZzFNVXA1OERO?=
 =?utf-8?B?RTJMZ0pVc3hBWEpqVXFxcEo5S3lTUGNGWWR1STZDSEpJbDRhd3VtY2pEZ0RN?=
 =?utf-8?B?K1BtLzRJWmQxd3YyYytuRmd1SldvZ1VVMEo0RkVHQUxvdDZpbFpVajdxZ3E1?=
 =?utf-8?B?OU9CRjN3Rzh5eTVtZXRaQ3JWTG1uVWpOelhQUnJBeUI1VlVjS2RnVnd4TWlW?=
 =?utf-8?B?d0FkMXBKU08yMnh1TzU0bVFaMUhxMWZ2a05YZTRDMWFaSE9oWElpei81YkhG?=
 =?utf-8?B?RTRON3FyL0MyY1lhOFF4a3lzQk43NlFSMkc0bTd1eHRWczBLT0NNUTZWakJ0?=
 =?utf-8?B?bDJJTHVvQ21oNGJ0ZTlsSWlZeGJxR2Q2QjI5SDdIajhjZWNxZEhkUXRrbEdp?=
 =?utf-8?B?VDBhc1krdmp0RWtjT1BBTjdXeHh5Rkd1OFZ5ZjF4RFpzUWpNbUg1V2hxeGRa?=
 =?utf-8?B?aXdzT3dKbU5WZEtVamdjU3Fsbmt5b0w5YSt6WlFHanFWMStHSHI1aStQRkFj?=
 =?utf-8?B?V2UrRkIwbjhOajhNS0VvNXNVN01RUjVQYkJNN1hkbEZPeFdaOSthSXRGeUNZ?=
 =?utf-8?B?QjVRYTZnZlcySWlycmtiUmpFdE5qRXNpZ1BYNWhnQ1lHaDdhckNqb0hHai9N?=
 =?utf-8?B?VDBUMGt5NDNGc2RjVnBuNm1NYXBmWW5IOCsyem9TRGEwQnZGeFd1K2FtaE5G?=
 =?utf-8?B?OTFSUlk5S1hIQXVMdVZLY3p5OGdOdUU0alYwa3U1WDI1K3dtMmg1SkpMVmJi?=
 =?utf-8?B?dHZqQ3RFUkluVGsySERlQjNCbXNrbE51TGdxYy80c29VaFdsUzhYRzQ3V3U4?=
 =?utf-8?B?OUQ5dVlRWm5qMDM2dkVXWFRScXpCd3Q2N09hcC8wY2FaSFNuZk1LcVhJb2pk?=
 =?utf-8?B?UEROY1pVV2VqOUNGSmIzNE0zV2RxODR6UzgrVXY2dWNvY201M0xqSEMza2lW?=
 =?utf-8?B?T1JQK3F6VHBOK3FkY0pQakRTbEt2TWxXa3p5cDBtT252K0xidHlCTzRUVE92?=
 =?utf-8?B?cGRWWFJ3a1pvcG9PcG8vVWVacnVTYzhRRmhKY3IxZmIrT0w2Mmlhd21nMnIx?=
 =?utf-8?B?eDVhSkw5dnFsdE82VUtoemdKbjg5dWY5ZmQ1Qjc5VEVyQzRTempnb1dwOWta?=
 =?utf-8?B?dzFhM1Q1VmtTclNBa0d6MFhqMDdCeFU0TWJEZFAwNjVnU1NUWXdJdTdsaHR0?=
 =?utf-8?B?U1I1ZUpvU1lpOUtZei9jYnRidWlJNWVFSm5RYzl3MDJxRUVyb2xyVWJoRzQz?=
 =?utf-8?B?cDM0dkVjVFEwaE9KY3B1eXp0d01lb1VWV0RjRjZpSmNkNENEVEhEZE9aTGxx?=
 =?utf-8?B?V09pdHlYcUk2MTJ3WWM5R05NVzF3TTlIQU1FRUxxdi9mSzhWeFFsRUFHT0ds?=
 =?utf-8?B?TzBtZm1GdkRYblFXeGJ0MDZkRFpHTzJ6N2dvZ3J0aHdiVWlnNFdUUFRoUmEr?=
 =?utf-8?B?Uk8zcEVkODdHRCtFdlhxN3oyc21BMUQ1TGRiNWZ4eFZqQVVSUmszNk1WS2Zv?=
 =?utf-8?B?d2pWeGVCdExseWdUbmF6cVpLOE9DWFZIRUNXeDJOcWJHdmJEVUptalUzNzdm?=
 =?utf-8?Q?vJWiZ8RdSU693nFIRw3cN7hLx?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21a3e329-4258-48ad-8136-08dac88740b2
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 10:34:07.2298
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6x4NZ+wxJH3kqduDtla+8sWP69UFBfCHUh5OmP+Qj0ran558ysrJCTtkkjNKIar0ttJGzWh50cbLmK1c1sUA9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6074
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Boris,

On 17-Nov-22 4:00 AM, Borislav Petkov wrote:
> On Mon, May 23, 2022 at 04:03:29PM +0530, Ravi Bangoria wrote:
>> On 21-May-22 12:08 AM, Peter Zijlstra wrote:
>>>
>>> Norbert reported that it's possible to race sys_perf_event_open() such
>>> that the looser ends up in another context from the group leader,
>>> triggering many WARNs.
>>>
>>> The move_group case checks for races against itself, but the
>>> !move_group case doesn't, seemingly relying on the previous
>>> group_leader->ctx == ctx check. However, that check is racy due to not
>>> holding any locks at that time.
>>>
>>> Therefore, re-check the result after acquiring locks and bailing
>>> if they no longer match.
>>>
>>> Additionally, clarify the not_move_group case from the
>>> move_group-vs-move_group race.
>>
>> Tested-by: Ravi Bangoria <ravi.bangoria@amd.com>
>>
>> Below is a quick test to reproduce the issue. It triggers WARN_ON()
>> as normal user. No warnings with the patch.
> 
> Shouldn't this test be in tools/perf/tests/ or so?

The issue was because of multiple event contexts involved. However, it's
no longer the case with reworked event context:

  https://git.kernel.org/tip/tip/c/bd27568117664b

Thanks,
Ravi