Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <98ae206d-c132-7529-1b4c-7f51079d7fa9@redhat.com>
Date:   Thu, 17 Nov 2022 12:03:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH linux-next] selftests/vm: add CATEGORY for
 ksm_functional_tests
Content-Language: en-US
To:     Joel Savitz <jsavitz@redhat.com>, linux-kernel@vger.kernel.org
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Shuah Khan <shuah@kernel.org>,
        David Hildenbrand <dhildenb@redhat.com>,
        Nico Pache <npache@redhat.com>, linux-mm@kvack.org,
        linux-kselftest@vger.kernel.org
References: <20221027170043.2363797-1-jsavitz@redhat.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20221027170043.2363797-1-jsavitz@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27.10.22 19:00, Joel Savitz wrote:
> commit e080ceaa69c1 ("selftests/vm: add KSM unmerge tests") in
> linux-next adds an entry to run_vmtests.sh. I recently submitted
> commit b5ba705c2608 ("selftests/vm: enable running select groups of tests")
> to linux-next which categorizes tests by functionality in order to
> allow more precise selection of which tests are to be run.
> 
> Since this newest test targets ksm and does not require more than one
> numa node, add 'CATEGORY="ksm"' to the invocation to group this test
> with the other ksm tests.
> 
> Signed-off-by: Joel Savitz <jsavitz@redhat.com>
> ---
>   tools/testing/selftests/vm/run_vmtests.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh
> index af35dd3bc589..fff00bb77086 100755
> --- a/tools/testing/selftests/vm/run_vmtests.sh
> +++ b/tools/testing/selftests/vm/run_vmtests.sh
> @@ -252,7 +252,7 @@ CATEGORY="ksm_numa" run_test ./ksm_tests -N -m 1
>   # KSM test with 2 NUMA nodes and merge_across_nodes = 0
>   CATEGORY="ksm_numa" run_test ./ksm_tests -N -m 0
>   
> -run_test ./ksm_functional_tests
> +CATEGORY="ksm" run_test ./ksm_functional_tests
>   
>   # protection_keys tests
>   if [ -x ./protection_keys_32 ]

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb