Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <68df3063-3fa2-9332-1705-631716589450@amd.com>
Date:   Thu, 17 Nov 2022 16:29:31 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH] perf: Fix sys_perf_event_open() race against self
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     Peter Zijlstra <peterz@infradead.org>, nslusarek@gmx.net,
        Linus Torvalds <torvalds@linux-foundation.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20220520183806.GV2578@worktop.programming.kicks-ass.net>
 <700710fc-1ac1-1b39-0e63-eb86adb4b984@amd.com> <Y3Vkmvi2vib7fwHn@zn.tnic>
 <7bf54a3f-07f7-5471-f6c2-88d3d9bc7a5e@amd.com> <Y3YPjo5wdKGVw7c5@zn.tnic>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <Y3YPjo5wdKGVw7c5@zn.tnic>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmdYT2lsMElaOW5lSUhEeWxGRDVBTndMTnljRXo5bEpiR0tZOFJwYk1YM0ZW?=
 =?utf-8?B?Wi9pY3dMR2dhNitGdjVnTlh1UStHbWpPd1VTeklqRkhrNlRoaCs0UHZyanJm?=
 =?utf-8?B?aEYrSlBvcFpubUZHeHE4SEsvc2NKVHhXYXpyTzQrS3dqOFAwYktGK1NiRXFJ?=
 =?utf-8?B?RUtxK1kwQ0c0bHJqUWtWL2Nodk02dlk3NXZiTU5HMVBNTnpXemhCR2hQKzdM?=
 =?utf-8?B?WDJ5Uy91UGtjSGJpSEJyV2RsQUNab0l2QU5OY3cwTVh1RXorMUJGT2x3d0NF?=
 =?utf-8?B?MjkxZVVWRkNQMnNick84aFphMmdrK1MxbEtZTUczUjRZOFRZNnhNVWJ6K3dv?=
 =?utf-8?B?WDFMSEFTVUlveVA1WEtZYjVrcmJBS3pVcDF5ZTBObEZOQVp1MjVUR0lDYW42?=
 =?utf-8?B?eml6VG5sV0JDQjVsNDNIakdUTXNEK1hBdGUrc2FGOTZJTHdCVFl3d0NEL25B?=
 =?utf-8?B?Nm5YWE51clQrd2tFYWllQU4wemhtZkw5QTlLV0hneHhQQUVQb3Znam5oZlRk?=
 =?utf-8?B?aDc1d0xGZkhaeUFuSlpTZTI2OXIyaDJXem4yT1k5QXZGZTZlcHBnb05sMVJQ?=
 =?utf-8?B?SXpDWVl1aUZXVytTZDgreFZCN2VIUnNTYVBQWG40c2Vkb2Q0YVBRNzU3OHIw?=
 =?utf-8?B?MDM1dHNOaG1TSXFhb096UXdveDlGT0xreE9aZWoyR3cycThOeTlKaHBUbkFT?=
 =?utf-8?B?Y0pPc1JFbFVwNEVqOTQvSGRLSk00Rm5xRzJ1eHZxNC9zMjIxMFZ6VGM1QjU4?=
 =?utf-8?B?bnhOL1h1STBIZUZsZ3YyY2o4MzNSRDJ3RjNXOW53Q3Z0NGdCRzhNNjVObGNV?=
 =?utf-8?B?bVl0NEFSdU1HMTBSRXByVUlTeFp1S2s0dnd1c3V5QmRyQlhwV0phdlE1Umh3?=
 =?utf-8?B?ZGQ1MXF1dmVFbXg3WUlhcXA5ZlRUYkM4YkxMcTNVVThEOXlYd0NYLzA1R3Y0?=
 =?utf-8?B?ZnJGc3dWMFFPZU9xa1lxOUdyY3FzOFNnU1lad0tvSElvaXViMER4RkhPd2V0?=
 =?utf-8?B?VEI4YTBWelhJNkZmM1dBY0Rzcjloc21ZWVAxTDdxZXFjVlAzRmtwMlAvOWhN?=
 =?utf-8?B?SCs1ZE1UUUMvZVk2TVlyRnNRbVRwYUpHUGlsNE5NbUhMQ1VMd1lvU0ppK0ZK?=
 =?utf-8?B?RFRwU09jaW54WHM3amdiSCszQlZ2d0s0dm56RFIzVTAvc2JOazRYOExObUtn?=
 =?utf-8?B?T2JhU1JVSloyaWFORC9ZMUtlVVk2UVZ0SGhJY0ZwZm9tRStXNWJSNEZiaUxo?=
 =?utf-8?B?eGtoZHBBeFpGTktnWlZEMzFzUEcrc0hyQnRmc2Z6OWJBekhRVEkvUWtNOUFr?=
 =?utf-8?B?Y1h6ZUtScVUrdm9LMFZjTzhCZXcwR0xJcG5rOTdNMjdmdGhHRjIydG9BUjQ4?=
 =?utf-8?B?dE40T2NOZ0JiekF4R3J5SmswbGJYZ3V5MnByK2JIQy9xaThVUENwK0pOa2ZJ?=
 =?utf-8?B?V0hPRGN0WktsWkVEbUlCWXBvdGFYVlYvSTFMOFd4Q3JQS3plYWpOdlVEVlc5?=
 =?utf-8?B?dUdrbTh4ZEhWdWVUVFJZMzBGUUFSRi96UzNzODdhK0ozblZTS0pVZWNjWWQv?=
 =?utf-8?B?Q2N2YXFmeTBMQ090RnhSNUwvU2tTaHpNYnBNVkJCK1JJV09uNDhUMk55QjFU?=
 =?utf-8?B?alBrYy9VZlM2U1FKVWxEbnpWTlFKd1pvYkluNzgwbFUzbHU5RVR4cllmMnhs?=
 =?utf-8?B?dXBCQTJlVEhOWlV5MFN2MTN5T2tzZURzNy9CK2xiLytKdWhJdHpNeGJlaEFU?=
 =?utf-8?B?Tlkyd3BFMzBNeEJxTFJBQlFTREl6clpiM2lOWDJTK0dLR1ZyQTdPTUkxZ0dr?=
 =?utf-8?B?UTRqY2hVd2xhbThjZVRtOWV5b09keE9Xb1Jlcmgya3psWjN5Q1BVb01DV1Ux?=
 =?utf-8?B?RzczMlBjQVZnK3NTUjVUMWt0M0lNaFFpdVV4VkpIOFA4ZUFhWUN4eDJPUWpV?=
 =?utf-8?B?bnN3RGJERVFjRUFMdGlLNGRTcGRaVkEvVWYyQk13aG1MWUNMYjlRbjk0aWpC?=
 =?utf-8?B?Z3o0aHZsV2d0aUcyOHNDNnJXYUcrdE1EcGo5UjdkV05uVU5jSWg4ZTl3UTgw?=
 =?utf-8?B?N214OWErRVNmaUp6OU5jT2t0NVJVRnRFUXNlVWZFNUswZ1MvN2Y1TjhKSXJK?=
 =?utf-8?Q?9cJjOktMexy9GQZ2iAWnLQZFd?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43c52d88-7846-45d9-17ab-08dac88ad462
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 10:59:42.3723
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Zh/CijR9+RlPXB2spwpsCx68Jhhmaa7Q9sK/6PGVff9gc4iL+dsOgJBMjVIIAB5zAIlc0eFiyGuvRTlmxqQNvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7119
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 17-Nov-22 4:10 PM, Borislav Petkov wrote:
> On Thu, Nov 17, 2022 at 04:03:54PM +0530, Ravi Bangoria wrote:
>> The issue was because of multiple event contexts involved. However,
>> it's no longer the case with reworked event context.
> 
> I got that but it wouldn't hurt to have this test regardless, no?
> 
> More testing is pretty much always better...

I do agree that more tests are always better. Though, this simple program
was to test a _specific race condition_ which no longer exists in kernel.
So even if we add it, what would it test?

Thanks,
Ravi