Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 17 Nov 2022 12:59:06 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Ravi Bangoria <ravi.bangoria@amd.com>
Cc:     Peter Zijlstra <peterz@infradead.org>, nslusarek@gmx.net,
        Linus Torvalds <torvalds@linux-foundation.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: Fix sys_perf_event_open() race against self
Message-ID: <Y3YiCkjsa3NLIpq6@zn.tnic>
References: <20220520183806.GV2578@worktop.programming.kicks-ass.net>
 <700710fc-1ac1-1b39-0e63-eb86adb4b984@amd.com>
 <Y3Vkmvi2vib7fwHn@zn.tnic>
 <7bf54a3f-07f7-5471-f6c2-88d3d9bc7a5e@amd.com>
 <Y3YPjo5wdKGVw7c5@zn.tnic>
 <68df3063-3fa2-9332-1705-631716589450@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <68df3063-3fa2-9332-1705-631716589450@amd.com>
Precedence: bulk

On Thu, Nov 17, 2022 at 04:29:31PM +0530, Ravi Bangoria wrote:
> I do agree that more tests are always better. Though, this simple program
> was to test a _specific race condition_ which no longer exists in kernel.
> So even if we add it, what would it test?

It would make sure that race doesn't happen again. Or are you saying it
will never ever happen so no need? Because we never ever rewrite the
kernel?

Lemme save us some time: this test is dirt cheap. It is good to have so
that multithreaded sys_perf_event_open() is exercised. And once it is
there, someone else might have a look at it and improve it more or reuse
it for another test.

And there are no downsides.

If you're still not convinced, lemme know and I'll turn it into a proper
patch and submit it.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette