Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH net] net/qla3xxx: fix potential memleak in ql3xxx_send()
To:     Leon Romanovsky <leon@kernel.org>
CC:     <GR-Linux-NIC-Dev@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "Paolo Abeni" <pabeni@redhat.com>, Jeff Garzik <jeff@garzik.org>,
        Ron Mercer <ron.mercer@qlogic.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1668675039-21138-1-git-send-email-zhangchangzhong@huawei.com>
 <Y3YdOQYQ5SjdeRpT@unreal>
From:   Zhang Changzhong <zhangchangzhong@huawei.com>
Message-ID: <f68629b9-62f9-5a58-9d5f-f33cb4912bf4@huawei.com>
Date:   Thu, 17 Nov 2022 20:14:51 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <Y3YdOQYQ5SjdeRpT@unreal>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/11/17 19:38, Leon Romanovsky wrote:
> On Thu, Nov 17, 2022 at 04:50:38PM +0800, Zhang Changzhong wrote:
>> The ql3xxx_send() returns NETDEV_TX_OK without freeing skb in error
>> handling case, add dev_kfree_skb_any() to fix it.
> 
> Can you please remind me why should it release?
> There are no paths in ql3xxx_send() that release skb.
> 
> Thanks
> 

If ql_send_map() returns NETDEV_TX_OK, the packet is sent, and
ql_process_mac_tx_intr() releases tx_cb->skb. However, the skb
cannot be released in this error path.

Thanks,
Changzhong

>>
>> Fixes: bd36b0ac5d06 ("qla3xxx: Add support for Qlogic 4032 chip.")
>> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
>> ---
>>  drivers/net/ethernet/qlogic/qla3xxx.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c
>> index 76072f8..0d57ffc 100644
>> --- a/drivers/net/ethernet/qlogic/qla3xxx.c
>> +++ b/drivers/net/ethernet/qlogic/qla3xxx.c
>> @@ -2471,6 +2471,7 @@ static netdev_tx_t ql3xxx_send(struct sk_buff *skb,
>>  					     skb_shinfo(skb)->nr_frags);
>>  	if (tx_cb->seg_count == -1) {
>>  		netdev_err(ndev, "%s: invalid segment count!\n", __func__);
>> +		dev_kfree_skb_any(skb);
>>  		return NETDEV_TX_OK;
>>  	}
>>  
>> -- 
>> 2.9.5
>>
> .
>