Received: by 2002:a05:622a:1442:b0:3a5:28ea:c4b9 with SMTP id v2csp667663qtx; Thu, 17 Nov 2022 04:52:20 -0800 (PST) X-Google-Smtp-Source: AA0mqf6FKYs80kOCAUEaTjfN/QL2HXj2Nv9xNueMw0c/5KmJf1aoYeJ1jQ4tyYxy+HP9dB0pkxDH X-Received: by 2002:a17:906:4f0d:b0:73d:dfb2:d188 with SMTP id t13-20020a1709064f0d00b0073ddfb2d188mr2055850eju.426.1668689540325; Thu, 17 Nov 2022 04:52:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668689540; cv=none; d=google.com; s=arc-20160816; b=cy6cuhuuk7y7Fb2m7vRZPDAumvho/CxTAseNDEu4bK07h4wgin0ILOPOyFAXd6FTcB WL3WH3LjqWbVagUoSgNomYcKV5pRO7Pb1EyjxPb8mB514s/S7LozAcDOPcDMQvdTvDuN LDH/lO+RCff7/N1arnBCPNHyHyyhPrRj/dVwL0eYc2PAxayyqZaC1eHrIlA9307sjZnB j0ampT0hQ+GgfQk42+Qu3IB0XqsgmmiuHwM8HYf9onbHBT/+gTApyIlMkAsyH0uG0UWM 1n11J0L/wYHeYNw93qRLdbjk9SG0zpNPtCMjKPcudbd43uNPUmwo92Ye7KICQE/2+fVw 519w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=ASBsFKuEewNKcc6V+qvTiKWEIdGA8lGcj9oKMILA6C4=; b=ezQdvb0cYQ52UZ2niz9SFgnbtk6YVtFmiM1odfISp37ITakxUx9olJXe1CEmk3nGvM PfZ/vEJbwX/Oo5V3hH8c0ERbC2cfV3ZhNa5aLL5fp0elF1Daq0NVDgDSGYMGMtYJGRlZ eoR5MuVX+/NW0+aYCl8WkxHWyMwjKRNNdSWlQ7pjdTbrGZ7nwvWrf1vsEgBQx2SATAQW JdEIXUlpUc0jKK1I+PQNNO3JECJiH22jzwxUamxtXOJXc2zIP196jKF77joJqICXyqUH yWg5xAGhMH4R5VfE190uthsuhZqKWpxPEXknY0DyRbJmKaEib6wdGO/HeW2LaXCz0TzY 5wVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OizyyH6j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gs9-20020a1709072d0900b007ae832c0b6bsi609670ejc.508.2022.11.17.04.51.58; Thu, 17 Nov 2022 04:52:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OizyyH6j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240055AbiKQMOL (ORCPT + 92 others); Thu, 17 Nov 2022 07:14:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239947AbiKQMOF (ORCPT ); Thu, 17 Nov 2022 07:14:05 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0763F697FB for ; Thu, 17 Nov 2022 04:14:04 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id a29so2448202lfj.9 for ; Thu, 17 Nov 2022 04:14:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ASBsFKuEewNKcc6V+qvTiKWEIdGA8lGcj9oKMILA6C4=; b=OizyyH6jpymDfxwhYPY1ZjQFuGm0wI/ZDUGRXv1NCePlEDzBGbsF41N4kxwKCwOR/2 e5GmFmlcmmGQpgpJBo3/cTLMniH9hKGI4XD2tJQEoqZGDiU7TXlbdrTgDxqbaqR7/DQ6 EBgJwlEKOv2902yamK5JTxU6rPh5xvfL/sY8uq+as8YQK5d2wmjlzqETCctnfvl5Kng+ NM2VmNfUdNxxOskq0jtSjtqClKKGm1Yg+aSa8DBCUbMXwyS8YgGroYDEKJsDMDuMIHW4 vYfgu43ba+XoKO6nSq5Q7Qp2YJr4l59hK5cbYN4TSYVDK9/Z+iHiT4EE+OFus1YuXgeW nf+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ASBsFKuEewNKcc6V+qvTiKWEIdGA8lGcj9oKMILA6C4=; b=nQARO74+nquEmvkGu2lpRrJZujWvB+iBKf1SpX6Uy+xxz+mC27D0LujqxZ8lQokQja 3x+gjWz7wOAfJXdkJZMYrDlJ1z1OPEy0bCrUQDUz9YDObVm1lCAZ0FMQMj6Ku2wU13GL yhmLrCq+IPogcLg3jqxypnloVx3aCJcqvPshIYK16ZE+7wKFo9VS2xhhNPpuVnixYqLy VGdKQcj4CjyO0mGXEmbHU1/w+NXlDuNqSP4JiBDlFW1H2Pfil1+SgwiNROZSlzQfn9rb vWL+OSr85Q4tP7GfHTSTaTf6EZk2FywaOXw8nTuEwNhyzpikp9Ih8vS415cPXanzK1Xz RIrA== X-Gm-Message-State: ANoB5pkwWgIrOrrnQhvd/GJr0E+6m/jhORsAWw88EVLkcSiqRdNEWVXT tGsaQ6oktPsRRcWw7c/LAJ4jaQ== X-Received: by 2002:a05:6512:a93:b0:4a2:6337:872d with SMTP id m19-20020a0565120a9300b004a26337872dmr801504lfu.35.1668687242409; Thu, 17 Nov 2022 04:14:02 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id m12-20020ac24acc000000b004a240eb0217sm118535lfp.251.2022.11.17.04.14.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Nov 2022 04:14:01 -0800 (PST) Message-ID: Date: Thu, 17 Nov 2022 13:14:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4 01/12] dt-bindings: iio: qcom: adc7-pm8350: Allow specifying SID for channels Content-Language: en-US To: Manivannan Sadhasivam Cc: konrad.dybcio@somainline.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, johan+linaro@kernel.org, quic_jprakash@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, steev@kali.org, Dmitry Baryshkov , Rob Herring , andersson@kernel.org References: <20221103095810.64606-1-manivannan.sadhasivam@linaro.org> <20221103095810.64606-2-manivannan.sadhasivam@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20221103095810.64606-2-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/2022 10:57, Manivannan Sadhasivam wrote: > As per the new ADC7 architecture used by the Qualcomm PMICs, each PMIC > has the static Slave ID (SID) assigned by default. The primary PMIC > PMK8350 is responsible for collecting the temperature/voltage data from > the slave PMICs and exposing them via it's registers. > > For getting the measurements from the slave PMICs, PMK8350 uses the > channel ID encoded with the SID of the relevant PMIC. So far, the > dt-binding for the slave PMIC PM8350 assumed that there will be only > one PM8350 in a system. So it harcoded SID 1 with channel IDs. > > But this got changed in platforms such as Lenovo X13s where there are a > couple of PM8350 PMICs available. So to address multiple PM8350s, change > the binding to accept the SID specified by the user and use it for > encoding the channel ID. > > It should be noted that, even though the SID is static it is not > globally unique. Only the primary PMIC has the unique SID id 0. > > Reviewed-by: Dmitry Baryshkov > Reviewed-by: Krzysztof Kozlowski > Acked-by: Rob Herring > Signed-off-by: Manivannan Sadhasivam > --- This was never sent to IIO maintainers, so now next is failing. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Best regards, Krzysztof