Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <05c77221-7457-7829-e5ab-f6115a0dd452@redhat.com>
Date:   Thu, 17 Nov 2022 14:17:40 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH 1/9] platform/x86/intel/sdsi: Add Intel On Demand text
To:     "David E. Box" <david.e.box@linux.intel.com>, markgross@kernel.org,
        andriy.shevchenko@linux.intel.com, srinivas.pandruvada@intel.com
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221101191023.4150315-1-david.e.box@linux.intel.com>
 <20221101191023.4150315-2-david.e.box@linux.intel.com>
Content-Language: en-US, nl
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20221101191023.4150315-2-david.e.box@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 11/1/22 20:10, David E. Box wrote:
> Intel Software Defined Silicon (SDSi) is now officially known as Intel
> On Demand. Add On Demand to the description in the kconfig, documentation,
> and driver source.
> 
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>  .../ABI/testing/sysfs-driver-intel_sdsi       | 37 ++++++++++---------
>  drivers/platform/x86/intel/Kconfig            |  8 ++--
>  drivers/platform/x86/intel/sdsi.c             |  4 +-
>  3 files changed, 25 insertions(+), 24 deletions(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-driver-intel_sdsi b/Documentation/ABI/testing/sysfs-driver-intel_sdsi
> index 96b92c105ec4..9d77f30d9b9a 100644
> --- a/Documentation/ABI/testing/sysfs-driver-intel_sdsi
> +++ b/Documentation/ABI/testing/sysfs-driver-intel_sdsi
> @@ -4,21 +4,21 @@ KernelVersion:	5.18
>  Contact:	"David E. Box" <david.e.box@linux.intel.com>
>  Description:
>  		This directory contains interface files for accessing Intel
> -		Software Defined Silicon (SDSi) features on a CPU. X
> -		represents the socket instance (though not the socket ID).
> -		The socket ID is determined by reading the registers file
> -		and decoding it per the specification.
> +		On Demand (formerly Software Defined Silicon or SDSi) features
> +		on a CPU. X represents the socket instance (though not the
> +		socket ID). The socket ID is determined by reading the
> +		registers file and decoding it per the specification.
>  
> -		Some files communicate with SDSi hardware through a mailbox.
> -		Should the operation fail, one of the following error codes
> -		may be returned:
> +		Some files communicate with On Demand hardware through a
> +		mailbox. Should the operation fail, one of the following error
> +		codes may be returned:
>  
>  		==========	=====
>  		Error Code	Cause
>  		==========	=====
>  		EIO		General mailbox failure. Log may indicate cause.
>  		EBUSY		Mailbox is owned by another agent.
> -		EPERM		SDSI capability is not enabled in hardware.
> +		EPERM		On Demand capability is not enabled in hardware.
>  		EPROTO		Failure in mailbox protocol detected by driver.
>  				See log for details.
>  		EOVERFLOW	For provision commands, the size of the data
> @@ -54,8 +54,8 @@ KernelVersion:	5.18
>  Contact:	"David E. Box" <david.e.box@linux.intel.com>
>  Description:
>  		(WO) Used to write an Authentication Key Certificate (AKC) to
> -		the SDSi NVRAM for the CPU. The AKC is used to authenticate a
> -		Capability Activation Payload. Mailbox command.
> +		the On Demand NVRAM for the CPU. The AKC is used to authenticate
> +		a Capability Activation Payload. Mailbox command.
>  
>  What:		/sys/bus/auxiliary/devices/intel_vsec.sdsi.X/provision_cap
>  Date:		Feb 2022
> @@ -63,17 +63,18 @@ KernelVersion:	5.18
>  Contact:	"David E. Box" <david.e.box@linux.intel.com>
>  Description:
>  		(WO) Used to write a Capability Activation Payload (CAP) to the
> -		SDSi NVRAM for the CPU. CAPs are used to activate a given CPU
> -		feature. A CAP is validated by SDSi hardware using a previously
> -		provisioned AKC file. Upon successful authentication, the CPU
> -		configuration is updated. A cold reboot is required to fully
> -		activate the feature. Mailbox command.
> +		On Demand NVRAM for the CPU. CAPs are used to activate a given
> +		CPU feature. A CAP is validated by On Demand hardware using a
> +		previously provisioned AKC file. Upon successful authentication,
> +		the CPU configuration is updated. A cold reboot is required to
> +		fully activate the feature. Mailbox command.
>  
>  What:		/sys/bus/auxiliary/devices/intel_vsec.sdsi.X/state_certificate
>  Date:		Feb 2022
>  KernelVersion:	5.18
>  Contact:	"David E. Box" <david.e.box@linux.intel.com>
>  Description:
> -		(RO) Used to read back the current State Certificate for the CPU
> -		from SDSi hardware. The State Certificate contains information
> -		about the current licenses on the CPU. Mailbox command.
> +		(RO) Used to read back the current state certificate for the CPU
> +		from On Demand hardware. The state certificate contains
> +		information about the current licenses on the CPU. Mailbox
> +		command.
> diff --git a/drivers/platform/x86/intel/Kconfig b/drivers/platform/x86/intel/Kconfig
> index 794968bda115..d5a33473e838 100644
> --- a/drivers/platform/x86/intel/Kconfig
> +++ b/drivers/platform/x86/intel/Kconfig
> @@ -157,13 +157,13 @@ config INTEL_RST
>  	  as usual.
>  
>  config INTEL_SDSI
> -	tristate "Intel Software Defined Silicon Driver"
> +	tristate "Intel On Demand (Software Defined Silicon) Driver"
>  	depends on INTEL_VSEC
>  	depends on X86_64
>  	help
> -	  This driver enables access to the Intel Software Defined Silicon
> -	  interface used to provision silicon features with an authentication
> -	  certificate and capability license.
> +	  This driver enables access to the Intel On Demand (formerly Software
> +	  Defined Silicon) interface used to provision silicon features with an
> +	  authentication certificate and capability license.
>  
>  	  To compile this driver as a module, choose M here: the module will
>  	  be called intel_sdsi.
> diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel/sdsi.c
> index c830e98dfa38..32793919473d 100644
> --- a/drivers/platform/x86/intel/sdsi.c
> +++ b/drivers/platform/x86/intel/sdsi.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * Intel Software Defined Silicon driver
> + * Intel On Demand (Software Defined Silicon) driver
>   *
>   * Copyright (c) 2022, Intel Corporation.
>   * All Rights Reserved.
> @@ -586,5 +586,5 @@ static struct auxiliary_driver sdsi_aux_driver = {
>  module_auxiliary_driver(sdsi_aux_driver);
>  
>  MODULE_AUTHOR("David E. Box <david.e.box@linux.intel.com>");
> -MODULE_DESCRIPTION("Intel Software Defined Silicon driver");
> +MODULE_DESCRIPTION("Intel On Demand (SDSi) driver");
>  MODULE_LICENSE("GPL");