Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7d830cc8-1463-d3ae-74cb-a908ac19a400@amd.com>
Date:   Thu, 17 Nov 2022 19:08:43 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH] perf: Fix sys_perf_event_open() race against self
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     Peter Zijlstra <peterz@infradead.org>, nslusarek@gmx.net,
        Linus Torvalds <torvalds@linux-foundation.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20220520183806.GV2578@worktop.programming.kicks-ass.net>
 <700710fc-1ac1-1b39-0e63-eb86adb4b984@amd.com> <Y3Vkmvi2vib7fwHn@zn.tnic>
 <7bf54a3f-07f7-5471-f6c2-88d3d9bc7a5e@amd.com> <Y3YPjo5wdKGVw7c5@zn.tnic>
 <68df3063-3fa2-9332-1705-631716589450@amd.com> <Y3YiCkjsa3NLIpq6@zn.tnic>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <Y3YiCkjsa3NLIpq6@zn.tnic>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3RnNFhRd0d1Wk5GL21jTkdpRXJnVnAxeGN1akc1L3d0NHVaRzhFQ00zM0ZU?=
 =?utf-8?B?cVJBZzIweU9obDd6ZFo5bWpSc3ZSRytpOFhyMXYrMTBiQjhMLzEyY0V4cHRR?=
 =?utf-8?B?Y3JDV05QbUpzdHF5VVJNTFFFa3R4RmVlU1JuRHJGcE9hTlZFWGhxSTRxWVFW?=
 =?utf-8?B?RzVMQ0J4Ykc5dnBVYXJPV0RubkNoSm1HN3VRVVFBc2dXbE0xcjlaRTZNeHFY?=
 =?utf-8?B?WTJSVmc0UlVKUnZQUmhhTmFzQmNwYTNkSW1seThmL3JVZUNDQms2OGV2T0F6?=
 =?utf-8?B?eTI4WXltWXpOY3ZLTm9aSG5MVkIwVkE5elNiWFFlUHdkaGpUakg0MnRtakZq?=
 =?utf-8?B?cldGRTRrYWhPaTZMOVlpRWgwNE83REtBd2ZLcjVzaUI4dUJSRURZVEIySkZ0?=
 =?utf-8?B?eStRcXZOY1loVFNjSlJQTUx5NDJwM3V0bURjSmR0cjdsWmowTWViMUlLaHQz?=
 =?utf-8?B?OExhM1dIalFTOFVMemFJTUJZek5VRUxuY2dRL1N3NjlrVTZyTm82ZStKYitY?=
 =?utf-8?B?c3JwMHBLaEE5RGxiNW5mOTBTSTZjVHZTUFRqQkV6aEYrQkxZejkxeHFYZE8r?=
 =?utf-8?B?TGhqRTlEZExhVFVzc2M5ZGFha05aZlFKRFNkb2lpTXlKZDV6VGVFcmExaTMw?=
 =?utf-8?B?YUd3YjJEVXVMc3Q2MjlmWUtaUXJ2d1QwUHpjRGt5OWJrOVl5MHNTQ0F1RUVo?=
 =?utf-8?B?bzcxUE5tSTBRem1vQmF3aDJHanZ6c3ZkNzk1YmxseWMyVnFjUmQ4TlJUMlJW?=
 =?utf-8?B?ekJMTUFFeDVVSW1LS1YwbHFNM0hBalFQYy9zbGVtYWRqWG5MVGJ0VVlIZk0x?=
 =?utf-8?B?Z3hXK2RSUm9hYXVIS2lXVHJ0Zno1bnd1eC9CK0hUUWZvNjBJQnV0SE5iUnAx?=
 =?utf-8?B?bWxJRTV6QVN6SjlLOGFWazFGVG5ia3B3SFh1YWVzM0llb0Zld0JNN3lwWlh6?=
 =?utf-8?B?YjQ1NXhlcjVLbEIzVXh3dldyWHBHdXR4akp3WkV4dklWTXFxVy9Tc1ppQ0Fp?=
 =?utf-8?B?b052MDByTHBxN1BxYmpXazRCWi80Znp3QW9xWFB5cm5qQnlIVWNmY2FpMXpu?=
 =?utf-8?B?YVh5WWtQYmtVSTlhalozSzU5Rm85ZCsremZtcU9oR2YvTVJJWFFQSWpjZjlp?=
 =?utf-8?B?ZHdBYkhvM1hOM1pKMVlwSkhsb29EZldtNUI5VzFDSDQ1ZU0yRDRvZlhsOUs0?=
 =?utf-8?B?bTBicG9Fc2x4YUkra0dKNysrYUpqallkbkx4VHZ3UThVSVg0cEUrOW9SVllZ?=
 =?utf-8?B?M3ptbGdBY05pWFVETEMxNkVSQ29uK2ZQMGd4bnJZcE9JcWQyaFlRU0Z0SGZT?=
 =?utf-8?B?emk2blpRelpwemNwVXF2eFI5RUtwOER6T3lVLytJaTFxZlQzcTBwQ0JvYWc4?=
 =?utf-8?B?MjduWjQ2QlJJTmRxUU83Zk15ZUk3dUl2V1ZuQTNCMDZyL2tHUFV0bmdZMDQ0?=
 =?utf-8?B?SnNsY0lremZMU3ViM0s5bzZNcnJ3RVVJd05GdE5Qam41d3ozbGdjdUpIaEZQ?=
 =?utf-8?B?SFJrMnFKL28zUTVmWmdvRnNEN0FWaUw5VWQ5QVZUMzdHK3Rnc09hbVNqMFBP?=
 =?utf-8?B?dXFMcWhRQWpRYXdtdTlpNkJ4QVUrN0w1bVQvdTZmb1dqNEtoTm9ha2hDM3Bz?=
 =?utf-8?B?TzVmUjJQSkkvYVFLcWovTHpBaXAyRm5jOXFYb0g2T2V6TXhrYlB1VFRWY2J6?=
 =?utf-8?B?Y0ZhYU0vVUNIZ2Z3S3RUd1FSZ0pnL2J4a2lEbmcwK1JDUzdlU1ducHRURzdy?=
 =?utf-8?B?UzdJajgwSys3WS9tV3BYRmV2SFRQQzNEZEExZjlWUkt6V2dNdUl6bkNQWFVQ?=
 =?utf-8?B?bHJOWFdJa2s0a3dnRzJ1NkJKUVU2eTZYZXRBd25Mdkd5dkk5TmFReWRNU3gy?=
 =?utf-8?B?OUtBRm1uTUdSWUFoZkJkRzNMbXBOMUU4bm4wSS9tWHFXeVJRQ0R4dG9QeVpS?=
 =?utf-8?B?Tkp1QUdxR1Q2U3RlTEg4MzhHaTgzRjJpaWkzK2VBYVBIbmhnMHV6WTlyRk9C?=
 =?utf-8?B?RHJyNmZjNnB3ZDltTmV1OVpjMTdvK0dxTU1IbWZKZmg5dW1rN1dzRnRKWHVv?=
 =?utf-8?B?Y3JWMVVUOW1xc1pSZWtiUVJCYmErSFk0VWhIeWVIUytWRy9HSFpzeFV3UFU2?=
 =?utf-8?Q?fuLh3NfDkoB5X1KXFuY39C2i5?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 00a27bd9-11ce-4ba1-477d-08dac8a1115a
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 13:38:53.6671
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pcLewT4MyIDhh++bBBmU66VXEmnGPx4XuyORofKWaF6hAUpyYhCLiliGafdPPYLqjKhHp2zeYzm02jDb1LBuWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6025
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 17-Nov-22 5:29 PM, Borislav Petkov wrote:
> On Thu, Nov 17, 2022 at 04:29:31PM +0530, Ravi Bangoria wrote:
>> I do agree that more tests are always better. Though, this simple program
>> was to test a _specific race condition_ which no longer exists in kernel.
>> So even if we add it, what would it test?
> 
> It would make sure that race doesn't happen again. Or are you saying it
> will never ever happen so no need? Because we never ever rewrite the
> kernel?
> 
> Lemme save us some time: this test is dirt cheap. It is good to have so
> that multithreaded sys_perf_event_open() is exercised. And once it is
> there, someone else might have a look at it and improve it more or reuse
> it for another test.
> 
> And there are no downsides.
> 
> If you're still not convinced, lemme know and I'll turn it into a proper
> patch and submit it.

I'll do it :)

Thanks,
Ravi