Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 17 Nov 2022 06:00:11 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     LKML <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        <linux-pci@vger.kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
        "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Jason Gunthorpe <jgg@mellanox.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Jon Mason <jdmason@kudzu.us>, Allen Hubbe <allenbh@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        <linuxppc-dev@lists.ozlabs.org>,
        "Ahmed S. Darwish" <darwi@linutronix.de>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [patch 01/39] PCI/MSI: Check for MSI enabled in
 __pci_msix_enable()
Message-ID: <Y3Y+a/s/lq0sd2Ej@a4bf019067fa.jf.intel.com>
References: <20221111120501.026511281@linutronix.de>
 <20221111122013.653556720@linutronix.de>
 <Y3UEFBJW1toFJZGn@a4bf019067fa.jf.intel.com>
 <87cz9ln2zu.ffs@tglx>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <87cz9ln2zu.ffs@tglx>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3rY8XKpPg/F81iisymsi5efNwldOflosUqH6jObcWQVQG1J0BivDpx+GqrBK?=
 =?us-ascii?Q?SkyKN/wx5Vq5VOB8LBL+p+Dp5Xp8rEHTaPAUiklRF/HpAJcDft3j8vGlRrVt?=
 =?us-ascii?Q?KIBCSHhFKA93McEXlO6dSDmSlMnlATVBLeX6UKaXtXzlQy9AZ4ligo4W0Gmt?=
 =?us-ascii?Q?xCgF037mSAKXas+7BC9qvKrubdAJz2FHNH/8B3wjr4Kw3vmD241fr7h7FjWi?=
 =?us-ascii?Q?ipnPH5yAnl12tkydxlgCMQcP8u1iAEm7QYcahB363oN0dNtc2enM6f+39La0?=
 =?us-ascii?Q?6Oxh4ypgjUizKlYk86ZV8HkTlvQwczrvmt3ZA1iRkyH9uJmR9KE/gb8S7yU9?=
 =?us-ascii?Q?EZtLKVMjYPzbLlelpFq9u2ZXgD817T4npvr6fR1s+5+3ca5B0PtYCXfTUaYx?=
 =?us-ascii?Q?jafmx4Xom6qqY4aOA2Ae/QQqdyr1I9d9NE6ZYWcoIeea7I70Sn4f6moMsM1C?=
 =?us-ascii?Q?5krdg/8c0BZk4AZHKx2fl1e+ExxK+rf80VDNC+XYa7nBWmD/y29SkrZCboyl?=
 =?us-ascii?Q?sXNLW34j3ApNvAXVmuZTCUl3L9mmpuq7z9PeWABT834/gM2VDtAuXEnJtr9l?=
 =?us-ascii?Q?8h41WYsTDxy7cygT6Um6iFJpC5V3yxLSg6eY4if7HD7eilv/1bNNnIsVZNA7?=
 =?us-ascii?Q?2Vl34g6rLyOXjUH8y9id/xV1drRQp0a12+BiuwoRhGzTXNUMdKiYd0tGVqng?=
 =?us-ascii?Q?MW1QB/bxGcfqiQ3aRXVTN7nYIYCkRB4NTHp1Is1y6xBwSzUTem43QOQS8lmC?=
 =?us-ascii?Q?xYt2Zk0AigdZfrAQZxmwkJZ56HlsI7DIQS850L041nWI6A2I2tkQQ4vYbt63?=
 =?us-ascii?Q?3dpax2eF1nBk64iLfcXAjyysVHupLkojQL4pSczcnuXaOdtNzAsFjrBfrCVU?=
 =?us-ascii?Q?Isp8JSFJq/civ+9TJ6T9rCFeQJvX0hRSCADqCijpcJo+2aOqlIgTESeNlRSG?=
 =?us-ascii?Q?XscZJUMNVne/V6ulNxvPKaNeaQZ39CNY9IxN9/ASJ0hfKqVSbzXrE7+h3UIc?=
 =?us-ascii?Q?PVGIFNSQurtzS5+L+oHS/Gk7895Ycf6k9Jxc5mZ3ONKjv3WvBOvR9SYFKs9v?=
 =?us-ascii?Q?L7Dm+U1NYXR3tTDMMTVWgzeUslNVv5/IZcvpemyfbEuA+uzmZmwrCkq4+JLc?=
 =?us-ascii?Q?acePW9R14ODaEKXr+vMNP/tNoaUka4Eaq9Psaf+AVxqpQPYvtKywBPvA3y1M?=
 =?us-ascii?Q?AISL7LjhvCGIRxvXeNJwv1viy77FlSYhpOejHaqdoMmCCHRGYRqjEnpF9TOW?=
 =?us-ascii?Q?ltvqXVYqwRTVH5yYNVBGZambj/tUEUPItKkhAbDSfkD2Ch0IgzXTlJGJLaRF?=
 =?us-ascii?Q?E73xnZI57944Qno/r3ARss1mOeHLGhezXE0EQlyPlMsOSbqsufLUItw91toZ?=
 =?us-ascii?Q?RAyUvHe993aQ/p5fgxLOLbpWOTpRAZo4JWz6CyRcCyq/DZ4VflvVyg7lyQ1R?=
 =?us-ascii?Q?neols6tyVaLTl96di4AOFzZE011Ao9AIBbWPCe4aK0nXARvdnj6qK2j5RMsq?=
 =?us-ascii?Q?WnsY34cNMMkYQDzwdWnijbeINrDkuSHEO0UecItajY1U1b8IDW6PQIVP2u0V?=
 =?us-ascii?Q?6Fwz5jICRORBsBjTdkkp+VdSGljnB1NAmh+rmbWWrK4H3pagw82Q0nxXuaMr?=
 =?us-ascii?Q?9g=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a0a2fcb-fd23-49ed-7d35-08dac8a40d40
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 14:00:16.6849
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: moF8mpSVxQV10VEdC/aU9aJqocHNQsQq9MhKplG4zn1E1k2v6a+nVfUpXe+ttfbjgXCFsnhaM83BOm97QxNY8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB6046
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 17, 2022 at 02:07:33PM +0100, Thomas Gleixner wrote:
> On Wed, Nov 16 2022 at 07:39, Ashok Raj wrote:
> > On Fri, Nov 11, 2022 at 02:54:15PM +0100, Thomas Gleixner wrote:
> >
> > Can the pre-enabled checks for msi and msix be moved up before any vector
> > range check?
> >
> > not that it matters for how it fails, does EBUSY sound better?
> 
> Does any caller care about the error code or about the ordering in which
> the caller stupity is detected?

No, I don't think so. That's why I prefixed it with "not that it matters" :-)

Just thought it would be good hygiene, but doesn't change anything functionally.