Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Daniel.Machon@microchip.com>
To:     <luwei32@huawei.com>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <Lars.Povlsen@microchip.com>,
        <Steen.Hegelund@microchip.com>, <UNGLinuxDriver@microchip.com>,
        <netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [patch net-next] net: microchip: sparx5: remove useless code in
 sparx5_qos_init()
Thread-Topic: [patch net-next] net: microchip: sparx5: remove useless code in
 sparx5_qos_init()
Thread-Index: AQHY+owNFKsLhwrlhky7iF4RkPp5vK5DLagA
Date:   Thu, 17 Nov 2022 14:21:14 +0000
Message-ID: <Y3ZF6gLy7hjW0KAx@DEN-LT-70577>
References: <20221117145820.2898968-1-luwei32@huawei.com>
In-Reply-To: <20221117145820.2898968-1-luwei32@huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4hhrrW0kLi2LZ2HT6/xVp2Af6bXkrCd0urCMKqVlTJF4EUOOOvvPcF1bFmT1?=
 =?us-ascii?Q?6Sy85feU7t4imVJGxdssIt+geCAsN44a+kDGaK9eNUpOGrHwQyXkrJlDst4d?=
 =?us-ascii?Q?k1DGN5bg83lo9KYupmVwSWXZ6KaAvmqEV17KLbpknTbIN9+TVpdB+32nRYxZ?=
 =?us-ascii?Q?CHS85dxYuZne+PHvUpz4EO/oGQrjDppLWy8vUE4eQdeAdMGsTSLZEemxbnLi?=
 =?us-ascii?Q?6ZAdMns1L5W8JTC/ge9w1EBAVWEB3PQ8DAxPUSUAGr+X2AT1hE9R5clla31R?=
 =?us-ascii?Q?pBPohQrF2M+bHQlpBh1WOeznoLvEVCke8npKtH1ZhtBmyOvCaaFXk584DGPP?=
 =?us-ascii?Q?9XQ2MVBYzrptkcrflHMEcvQQwUcGxPqmz6lCzeU6JlgCKCv3Gmsd+a6lQ5Mw?=
 =?us-ascii?Q?F2IhibDUa+gQgWkJmuRrK5wGd5wtsvANF8rHuvmLWH1n4hvRgch59LR1LUWm?=
 =?us-ascii?Q?XVRadQkGFYbkqBfshRO6WMuKToJhS4hSyllLH+EjjkWXzLSiBPSEJB/uAvc2?=
 =?us-ascii?Q?gH04PRUa4GdwsGEs2n3OIIWkqvmE0rw5C5MO0ioOIXwyX/BVT7c+sv37SXsS?=
 =?us-ascii?Q?7mANDLbbzNfOtKbsPLJn0lVUcRNMbLTU55pUxZ7uiDMC1bN/8fqOWvJj6MC+?=
 =?us-ascii?Q?9X5j0RWgjwLBvwN9N2w4yzXXzIq7mI77Wuhd7Jb5iE/cFit/lPo2csqMkUMs?=
 =?us-ascii?Q?M2p2kEFmJyzlv5RCEIlazX97YS9+fPWbOAuq0w/NwWbDzV9mAxn4Vm1Z45Ak?=
 =?us-ascii?Q?SDAyRZdSeHKRk7umcvDlKCd4N3arL1RSLcppbWHRvsxZeqQxaEw9yze/srCu?=
 =?us-ascii?Q?KIQllJCWgC/eqw43zvyqF03Ai+oBC9h9K+QzQsqsd7Nwk/kXFLZ4IBdKxiwt?=
 =?us-ascii?Q?QQDWBRBc3G0C+32iPENuBpOE9qc0NDOylAxePuQoY497qPrTfLCDITeZMRPf?=
 =?us-ascii?Q?OKoT8ILVU70tLC9ih2RTom2H3YaInNNKYSwnGRm2bQr4xXeN2GfjN/X3vbnO?=
 =?us-ascii?Q?PlClnUlnWBtIiO6NkZ0dOdyc5aUh0+5SNMTdAzpMiu2yUFaPPbmRBAEzrNlC?=
 =?us-ascii?Q?Dx/TA3G0zr/B+KMdbztr0FbNFWkPbSrOsJ1jQO4WxdqRqiAsAgGZjKB3d6O1?=
 =?us-ascii?Q?XNp80Qkf1z24nF8N3clD0S2l5o6X6DPcUSN4dAg+fWaV0OntP9JIhwLFBYVz?=
 =?us-ascii?Q?9ZFEybWzbvwUnAHRtA1vmbArvfPrjDVskVo6D8YKd9nYMGtSdQmVj4aVl7g+?=
 =?us-ascii?Q?8tWB3LhV+ynBSecXblNwRHXqnCc7X5o458iCrpCFPcGDTfIqxTmRYs7pE5Hj?=
 =?us-ascii?Q?vT+QOoaPtHrMbbTWUNjipVS6th9ZuO3mPGr4p0mcozjI3jOUu5/xxttPU79U?=
 =?us-ascii?Q?k4BulSD6XJpDJoN1E2a6bf4LGTgKq0HCQkWAnz3x1XscEj9ghXrRKaZ1whZQ?=
 =?us-ascii?Q?nIzuX3wlIW84x+uKO/3PVEiXf5HoAPJxcpvUcZEzH+0clK5z4XqRUz4/4Ekz?=
 =?us-ascii?Q?0YTJJaDZkb5mzebkMSo0AlqdINwdfO9Ek+pOEw6TKXxaqZGz5cKXInqu1sjh?=
 =?us-ascii?Q?3YT5FDz2C6947nE2hVFsCkXT4720Wqo5ghl8m9yZuVRs7fHQ3bduRprBA66x?=
 =?us-ascii?Q?dAW1P/w0pkUW2B17fIAn8lw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9055AFF4EEB2EC4DAA64C12D0BCC5819@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5569.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77746431-0d78-4ee9-f970-08dac8a6fc4f
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2022 14:21:14.9411
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: l8eMSto1dIYOh2mxd0rhM8im5GAaK43AjboU+4Qavskto7uOBqXbbBRuMHC3iPiqx/JcOKxlZSA74fUUMpIc4ojQ7Vur7K6yGYZUXOahaqY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6615
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Den Thu, Nov 17, 2022 at 10:58:20PM +0800 skrev Lu Wei:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e content is safe
>=20
> There is no need to define variable ret, so remove it
> and return sparx5_leak_groups_init() directly.
>=20
> Signed-off-by: Lu Wei <luwei32@huawei.com>
> ---
>  drivers/net/ethernet/microchip/sparx5/sparx5_qos.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_qos.c b/drivers=
/net/ethernet/microchip/sparx5/sparx5_qos.c
> index 1e79d0ef0cb8..2f39300d52cc 100644
> --- a/drivers/net/ethernet/microchip/sparx5/sparx5_qos.c
> +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_qos.c
> @@ -383,13 +383,7 @@ static int sparx5_leak_groups_init(struct sparx5 *sp=
arx5)
>=20
>  int sparx5_qos_init(struct sparx5 *sparx5)
>  {
> -       int ret;
> -
> -       ret =3D sparx5_leak_groups_init(sparx5);
> -       if (ret < 0)
> -               return ret;
> -
> -       return 0;
> +       return sparx5_leak_groups_init(sparx5);
>  }
>=20
>  int sparx5_tc_mqprio_add(struct net_device *ndev, u8 num_tc)
> --
> 2.31.1
>

sparx5_qos_init() will be expanded in later patch series, as new QoS
features require new initializations - so this is actually somewhat
intentional.

/ Daniel