Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bf577f21-6c3c-8fb3-9150-17e7500c4c7d@nvidia.com>
Date:   Thu, 17 Nov 2022 14:57:20 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] [WAR] hwmon: (ina3221) Apply software WAR to offset shunt
 voltage
Content-Language: en-US
To:     Guenter Roeck <linux@roeck-us.net>,
        Ninad Malwade <nmalwade@nvidia.com>
Cc:     treding@nvidia.com, jdelvare@suse.com, nicolinc@nvidia.com,
        rkasirajan@nvidia.com, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
References: <20221117083226.20027-1-nmalwade@nvidia.com>
 <20221117144709.GD664755@roeck-us.net>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20221117144709.GD664755@roeck-us.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3hDMFk4RGp4K083Q1NSMVlrZWVlVUIxV21USGRodDBOZHU4SFlsSHQxNFVn?=
 =?utf-8?B?UkNDM2R2bzJLWkt1ZlplYkZBd1BvZURxT0k2Z29kODhZZVN4SHNQYmhmeVU4?=
 =?utf-8?B?OFRoT2NMQUREc2U2QUZsR3c3NVRuNWF4QlhmeU9IS1JYc1lweTVFdlZZQmZ2?=
 =?utf-8?B?RlJEZHdmei9qMzJQVk4zdmRYMFdvWm1BdVJwejVlWFV3Mko4MHV1dXQxZVh6?=
 =?utf-8?B?WElpaFBxUnNGV3RvVFlQY2hiam4zQWx2YXV3cDlVdUw5aEpRWmVyWjQ0RDJz?=
 =?utf-8?B?NHRwOUFpQ2p5SXBJU2grYWJrKy9FN3RPRUJRM0N6dWk4VUFOTk9jWDFHd3M5?=
 =?utf-8?B?ZkY5ams1dFVSNFdIS1M4NGl6YmJKcThJUEFLNUtUL2NmQlhKVjcrNlhnbDZt?=
 =?utf-8?B?VXB2SUhLQTJVVWtwUU56d2JyVmxNQ1d6U09wbWtHRVdxY3N6QVNRU2pBZHgw?=
 =?utf-8?B?aTVBRDVwUGdPYm9VblRmTXViNVpoT1FKanNxSkwrNXRBS21tWXI2WXBSNEE2?=
 =?utf-8?B?ZGRzVHVSMWt2czh5eTVQMDhBUXdMYWpDMlFOWVVZcWw5THEvTkdkVGs5SHJM?=
 =?utf-8?B?YTE3djUxdmNvRVBGSU1HRzBGNjZ5SDdMbmdLNlJNcThIWkV3SDd4Q1Z5SUd3?=
 =?utf-8?B?SU9JR0F3NlBnZ0FVUTI1RTBBanBzcXJ4eE9kcktRMkFwU1pKRnZFWktWaU9I?=
 =?utf-8?B?YkJFQnJGR0FjbnlydWNuT0lKdlBaaUFTOHhKbUp1VmFjUC9udFB0TmVDT1Ny?=
 =?utf-8?B?OXF2c3VIbmh0WXNTK2VrN20zVXlJUk9WS05PZ3lkd3hLWWdLbi9OYjZraEtk?=
 =?utf-8?B?b1JwUzRSamx3Ynp4SHp4ck52eU13VWZRNEpCc1FUZWhJRXV5SlIwVHpvdUdn?=
 =?utf-8?B?V04rdjlqZHQ1Q3hSblJlM2VGcFUvQzhCL2NiV2tpblJlVy9VWUJHeEM2aVJU?=
 =?utf-8?B?eWJyaHhrelk1VUN5RGViNXJXS3g4OVFHbU5yV2k1UEhjekpUbjNzekMvd1NB?=
 =?utf-8?B?SXpjQisvdi8rUzNKblJCLzhvZ0pDN0FPMTF2NUpYN3FDcUVQRVcyTUs5K1U2?=
 =?utf-8?B?SnJKeWZhdldhb2d4QUN2SjRDR3dYMEV1YkVIRUFHQ1FYaVI1M0JoTm1sOVFY?=
 =?utf-8?B?Qit3dk5pbE9CNy90Vm5DaUJ3a09KMXVHY2hTS3ZyQWwrZlB2dGE5SDFVckJr?=
 =?utf-8?B?UWN6RlZYOUo1RWJDTmJWc1BsVUk2UE5SSXdMREJtY21JVEpOaEZNTndLa2lT?=
 =?utf-8?B?UWt1OGNDV1ZYUXI4NFB6Y2I3WExHcHVrZ21XVSs0dDZsek1tL0F2bGdSem5z?=
 =?utf-8?B?YlZrNU1aS0hYM3g4ekZhazlpMmEyKzgwWWdWYjgwT0pMVW9WWWQ2YndicjUr?=
 =?utf-8?B?cHFvZlZQNFlQSWZlV01HMHpwRFBJOHdZMGFHeVpOSEE3Zy9ZdC90eEdkNWk4?=
 =?utf-8?B?eE5xaTBJaldGSllSYVZYa2JwMnNQeHVTQ0l6alBpNEM3eGdicmwwVVRBaFhG?=
 =?utf-8?B?eDJnQUt3SG4yUjcrS1F0bVJxT2kyUTl6SGtyUi9Zci9mWlVHMjM0dXA5NVdR?=
 =?utf-8?B?UmE0WHEvUXY0TDRHU3o5bHdUOXNHajJCa3V3VDhuU1dZSkxiM2NxNFpjTkhk?=
 =?utf-8?B?SVc5WEdzbTR4OTBiWXEzVFA4ckVoWnhhK2ZnV0l3dC85Mi9lNDUvU1RheGVs?=
 =?utf-8?B?TDdEOEx0Wk1pNFVCRGpJRGEwK3kwOEd0TTdSNnNGdGhJa0tUZmkvMTlKNzBU?=
 =?utf-8?B?b1VWUkUzR09VRHQxOC9BTHJodE9QZW9kdmZYZkFML3NEeXNUakRlMTY5Q29y?=
 =?utf-8?B?d1p6anhKdU4zWEVXRVY1K1BTQ25xeXlBRDZnRmEwcDZjcy9aaFJMQkFBeFBF?=
 =?utf-8?B?Sko0SGRweXpCZ3FKUWNuQzVIUy9seXBubkJhdTRXWU5kU1dhZUVYZXg4YzZm?=
 =?utf-8?B?TVlZUHFiS0g5emRuQy9XS29KWEpLZ1p0K2NSWWcwck53TUwwUzhwYWsxT0VM?=
 =?utf-8?B?U2VVZktyNWJmRWlxbDdTRWRYejNRQXVvbTFQbkl6ZU9iRWFvZFU1WjAwTkNz?=
 =?utf-8?B?SW01V3VOa3M1MjJCS3ZTWDdZQUd3Vm5JbFg3bURUcndWUHhFZ0QvQXRZRVE0?=
 =?utf-8?B?U0EwYXNwd3hwUVRaSUc0YzNETk5vcmIvYjg2WXNaQ1MyQ2JQV3E0amtCbHRs?=
 =?utf-8?B?RXc9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47033eb9-35b9-45c1-999b-08dac8ac0b20
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 14:57:27.5618
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WIr3iRlJDD7K41oR9XQpsaXeA4pc3cCcXsQF7bA8L6V+kssc8S5in8vH903TU6VSmudt6Lx3zSIYs6egwl4swg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4279
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 17/11/2022 14:47, Guenter Roeck wrote:
> On Thu, Nov 17, 2022 at 04:32:26PM +0800, Ninad Malwade wrote:
>> This is used as a software WAR to offset shunt voltage reading
> 
> What is a software WAR ? Or a WAR in the first place ?
> What is the relevance of the "[WAR]" tag in the subject ?
> 
> None of the definitions at https://acronyms.thefreedictionary.com/WAR
> seem to apply. I am sure it means something for you, and it seems to be
> important enough to use the term repeatedly, but please do not assume
> that others know what it means.

Indeed. I will work with Ninad to correct this.

>> from INA3221 to increase its accuracy. This patch implements a
>> previous downstream feature by reading the offset information
>> from DT and apply it to current readings.
>>
> 
> Where is the devicetree documentation ?

Yes that is also missing. Let me sync up with Ninad offline and get this 
re-worked properly.

Jon

-- 
nvpublic