Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20221117122547.809644-7-tomi.valkeinen@ideasonboard.com>
References: <20221117122547.809644-1-tomi.valkeinen@ideasonboard.com> <20221117122547.809644-7-tomi.valkeinen@ideasonboard.com>
Subject: Re: [PATCH v1 6/8] drm: rcar-du: Add r8a779g0 support
From:   Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc:     Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <robert.foss@linaro.org>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
To:     Geert Uytterhoeven <geert+renesas@glider.be>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Magnus Damm <magnus.damm@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
        devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Date:   Thu, 17 Nov 2022 15:08:38 +0000
Message-ID: <166869771876.50677.1905794243575000038@Monstersaurus>
User-Agent: alot/0.10
Precedence: bulk

Quoting Tomi Valkeinen (2022-11-17 12:25:45)
> From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>=20
> Add support for DU on r8a779g0, which is identical to DU on r8a779a0.
>=20
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> ---
>  drivers/gpu/drm/rcar-du/rcar_du_drv.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>=20
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar=
-du/rcar_du_drv.c
> index d003e8d9e7a2..b1761d4ec4e5 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -524,6 +524,27 @@ static const struct rcar_du_device_info rcar_du_r8a7=
79a0_info =3D {
>         .dsi_clk_mask =3D  BIT(1) | BIT(0),
>  };
> =20
> +static const struct rcar_du_device_info rcar_du_r8a779g0_info =3D {
> +       .gen =3D 3,

Given that this is the V4H ... I wonder if this should be bumped
already. I guess that has knock on effects through the driver though...

Aside from that, Which may need more work to handle correctly:

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>


> +       .features =3D RCAR_DU_FEATURE_CRTC_IRQ
> +                 | RCAR_DU_FEATURE_VSP1_SOURCE
> +                 | RCAR_DU_FEATURE_NO_BLENDING,
> +       .channels_mask =3D BIT(1) | BIT(0),
> +       .routes =3D {
> +               /* R8A779G0 has two MIPI DSI outputs. */
> +               [RCAR_DU_OUTPUT_DSI0] =3D {
> +                       .possible_crtcs =3D BIT(0),
> +                       .port =3D 0,
> +               },
> +               [RCAR_DU_OUTPUT_DSI1] =3D {
> +                       .possible_crtcs =3D BIT(1),
> +                       .port =3D 1,
> +               },
> +       },
> +       .num_rpf =3D 5,
> +       .dsi_clk_mask =3D  BIT(1) | BIT(0),
> +};
> +
>  static const struct of_device_id rcar_du_of_table[] =3D {
>         { .compatible =3D "renesas,du-r8a7742", .data =3D &rcar_du_r8a779=
0_info },
>         { .compatible =3D "renesas,du-r8a7743", .data =3D &rzg1_du_r8a774=
3_info },
> @@ -549,6 +570,7 @@ static const struct of_device_id rcar_du_of_table[] =
=3D {
>         { .compatible =3D "renesas,du-r8a77990", .data =3D &rcar_du_r8a77=
99x_info },
>         { .compatible =3D "renesas,du-r8a77995", .data =3D &rcar_du_r8a77=
99x_info },
>         { .compatible =3D "renesas,du-r8a779a0", .data =3D &rcar_du_r8a77=
9a0_info },
> +       { .compatible =3D "renesas,du-r8a779g0", .data =3D &rcar_du_r8a77=
9g0_info },
>         { }
>  };
> =20
> --=20
> 2.34.1
>