Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a21a7a1b749d0c7e8f7942fe02dd4b6fcd3e97f6.camel@linux.intel.com>
Subject: Re: [PATCH 0/9] Extend Intel On Demand (SDSi) support
From:   "David E. Box" <david.e.box@linux.intel.com>
Reply-To: david.e.box@linux.intel.com
To:     Hans de Goede <hdegoede@redhat.com>, markgross@kernel.org,
        andriy.shevchenko@linux.intel.com, srinivas.pandruvada@intel.com
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 17 Nov 2022 08:00:42 -0800
In-Reply-To: <267ebc83-04a8-4421-732d-7a329bc0fa9a@redhat.com>
References: <20221101191023.4150315-1-david.e.box@linux.intel.com>
         <267ebc83-04a8-4421-732d-7a329bc0fa9a@redhat.com>
Organization: David E. Box
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2022-11-17 at 15:01 +0100, Hans de Goede wrote:
> Hi David,
>=20
> On 11/1/22 20:10, David E. Box wrote:
> > Intel Software Defined Silicon (SDSi) is now known as Intel On Demand. =
The
> > following patches do the following:
> >=20
> > 1. Identify the driver/tools as Intel On Demand. Only text descriptions=
 are
> > changed. Kconfig and filenames remain the same.
> > 2. Perform some attribute cleanup by preventing the showing of files wh=
en
> > features are not supported.
> > 3. Adds support for a new GUID. GUIDs are used to identify the layout o=
f
> > the On Demand registers in sysfs. Layouts are described in the
> > documentation on github [1].
> > 4. Add support for reading On Demand meter certificates in sysfs.
> > 5. The rest of the patches modify the existing tool to support discover=
y
> > and reading of On Demand registers and the meter certificate.
> >=20
> > [1] https://github.com/intel/intel-sdsi/blob/master/os-interface.rst
> >=20
> > David E. Box (9):
> > =C2=A0 platform/x86/intel/sdsi: Add Intel On Demand text
> > =C2=A0 platform/x86/intel/sdsi: Hide attributes if hardware doesn't sup=
port
> > =C2=A0 platform/x86/intel/sdsi: Support different GUIDs
> > =C2=A0 platform/x86/intel/sdsi: Add meter certificate support
> > =C2=A0 tools/arch/x86: intel_sdsi: Add support for reading state certif=
icates
> > =C2=A0 tools/arch/x86: intel_sdsi: Add Intel On Demand text
> > =C2=A0 tools/arch/x86: intel_sdsi: Read more On Demand registers
> > =C2=A0 tools/arch/x86: intel_sdsi: Add support for new GUID
> > =C2=A0 tools/arch/x86: intel_sdsi: Add support for reading meter certif=
icates
>=20
> Thank you, over all this looks good. I have some small remarks
> on patches 4, 8 and 9 see my replies to those.
>=20
> Please prepare a v2 addressing Andy's + my review remarks and get
> that v2 to me no later then next week Tuesday, then I can still
> merge this in time for 6.2 .

Will do. Thanks Hans, Andy.

>=20
> Regards,
>=20
> Hans
>=20
>=20