Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 17 Nov 2022 13:07:24 -0500
From:   Johannes Weiner <hannes@cmpxchg.org>
To:     Chao Xu <amos.xuchao@gmail.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Chao Xu <Chao.Xu9@zeekrlife.com>,
        yu@cmpxchg.org
Subject: Re: [PATCH v1] mm/vmscan: simplify the nr assignment logic for pages
 to scan
Message-ID: <Y3Z4XMKvcBOAwZvU@cmpxchg.org>
References: <20221110113130.284290-1-Chao.Xu9@zeekrlife.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221110113130.284290-1-Chao.Xu9@zeekrlife.com>
Precedence: bulk

On Thu, Nov 10, 2022 at 07:31:30PM +0800, Chao Xu wrote:
> By default the assignment logic of anonymouns or file inactive
> pages and active pages to scan using the same duplicated code
> snippet. To simplify the logic, merge the same part.
> 
> Signed-off-by: Chao Xu <Chao.Xu9@zeekrlife.com>
> ---
>  mm/vmscan.c | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 04d8b88e5216..69e458e51c81 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -5932,14 +5932,11 @@ static void shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc)
>  		 * scan target and the percentage scanning already complete
>  		 */
>  		lru = (lru == LRU_FILE) ? LRU_BASE : LRU_FILE;
> -		nr_scanned = targets[lru] - nr[lru];
> -		nr[lru] = targets[lru] * (100 - percentage) / 100;
> -		nr[lru] -= min(nr[lru], nr_scanned);
> -
> -		lru += LRU_ACTIVE;
> -		nr_scanned = targets[lru] - nr[lru];
> -		nr[lru] = targets[lru] * (100 - percentage) / 100;
> -		nr[lru] -= min(nr[lru], nr_scanned);
> +		for ( ; lru <= lru + LRU_ACTIVE; lru += LRU_ACTIVE) {

As Yu points out, this will loop until lru overflows.

NAK.