Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 17 Nov 2022 10:37:49 -0800
From:   Isaku Yamahata <isaku.yamahata@gmail.com>
To:     "Huang, Kai" <kai.huang@intel.com>
Cc:     "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Yamahata, Isaku" <isaku.yamahata@intel.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "Shahar, Sagi" <sagis@google.com>,
        "Aktas, Erdem" <erdemaktas@google.com>,
        "isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>,
        "dmatlack@google.com" <dmatlack@google.com>,
        "Christopherson,, Sean" <seanjc@google.com>
Subject: Re: [PATCH v10 041/108] KVM: x86/tdp_mmu: refactor kvm_tdp_mmu_map()
Message-ID: <20221117183749.GK2350331@ls.amr.corp.intel.com>
References: <cover.1667110240.git.isaku.yamahata@intel.com>
 <ae532ffde75be94062f03dab8b538fa64d1dfc74.1667110240.git.isaku.yamahata@intel.com>
 <f9dcc09e6569b2d47c039a44bfb83c22e30365bb.camel@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <f9dcc09e6569b2d47c039a44bfb83c22e30365bb.camel@intel.com>
Precedence: bulk

On Wed, Nov 16, 2022 at 09:42:34AM +0000,
"Huang, Kai" <kai.huang@intel.com> wrote:

> On Sat, 2022-10-29 at 23:22 -0700, isaku.yamahata@intel.com wrote:
> > From: Isaku Yamahata <isaku.yamahata@intel.com>
> > 
> > Factor out non-leaf SPTE population logic from kvm_tdp_mmu_map().  MapGPA
> > hypercall needs to populate non-leaf SPTE to record which GPA, private or
> > shared, is allowed in the leaf EPT entry.
> 
> Is this patch still valid/needed since you have changed to use XArray to store
> whether GFN is private or shared?

Because tdp_mmu_populate_nonleaf() won't be touched any more, this patch doesn't
have any benefit. Will drop it.
-- 
Isaku Yamahata <isaku.yamahata@gmail.com>