Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 17 Nov 2022 15:36:30 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Wang Wensheng <wangwensheng4@huawei.com>
Cc:     <linux-kernel@vger.kernel.org>, <mhiramat@kernel.org>,
        <mark.rutland@arm.com>, <xuqiang36@huawei.com>,
        <weiyongjun1@huawei.com>
Subject: Re: [PATCH -next 3/3] ftrace: Delete unused variable
 ftrace_update_time
Message-ID: <20221117153630.4af6a7da@gandalf.local.home>
In-Reply-To: <20221109094434.84046-4-wangwensheng4@huawei.com>
References: <20221109094434.84046-1-wangwensheng4@huawei.com>
        <20221109094434.84046-4-wangwensheng4@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 9 Nov 2022 09:44:34 +0000
Wang Wensheng <wangwensheng4@huawei.com> wrote:

> ftrace_update_time is not used anywhere else after initialization. So
> delete it together with its initial code.

Thanks for the first two patches. They are definitely fixes and I plan on
testing and adding them to my next pull request.

As for this one, this has been more of a reminder for me to one day (I
know, it's been years!) to export this to see from user space. I sometimes
do it manually with a printk(), but it should probably be always shown.
Perhaps in dyn_ftrace_total_info ?

-- Steve