Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221117004356.279422-1-irogers@google.com> <Y3ZV0FDW70ADoIYE@kernel.org>
In-Reply-To: <Y3ZV0FDW70ADoIYE@kernel.org>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Thu, 17 Nov 2022 11:32:10 -0800
Message-ID: <CAEf4BzbZ2-KiM=S6k11+39Y7vQMOmj7YvAd2w59BOXtCacjtFg@mail.gmail.com>
Subject: Re: [PATCH 0/6] Build output clean up
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Ian Rogers <irogers@google.com>,
        Andrii Nakryiko <andrii@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Nicolas Schier <nicolas@fjasle.eu>,
        Masahiro Yamada <masahiroy@kernel.org>,
        linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
        linux-perf-users@vger.kernel.org,
        Stephane Eranian <eranian@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Nov 17, 2022 at 7:40 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Wed, Nov 16, 2022 at 04:43:50PM -0800, Ian Rogers escreveu:
> > Reduce build spam from commands not prefixed with @. Make
> > install_headers targets distinguishable by adding in the library name
> > so:
> > INSTALL headers
> > becomes:
> > INSTALL libapi_headers
> >
> > Ian Rogers (6):
> >   tools lib api: clean up install_headers
> >   tools lib bpf: Avoid install_headers make warning
> >   tools lib symbol: clean up build output
> >   tools lib perf: Make install_headers clearer
> >   tools lib subcmd: Make install_headers clearer
> >   tools lib traceevent: Make install_headers clearer
>
> Andrii, are you ok with that? Can I carry this on my next (perf/core)
> branch?

yep, lgtm. Please take it through your tree, in-kernel Makefile is not
even synced into Github, so there is no downsides in terms of libbpf
sync.

Acked-by: Andrii Nakryiko <andrii@kernel.org>

>
> Testing it now.
>
> - Arnaldo
>
> >  tools/lib/api/Makefile        | 4 ++--
> >  tools/lib/bpf/Makefile        | 1 +
> >  tools/lib/perf/Makefile       | 2 +-
> >  tools/lib/subcmd/Makefile     | 2 +-
> >  tools/lib/symbol/Makefile     | 4 ++--
> >  tools/lib/traceevent/Makefile | 4 ++--
> >  6 files changed, 9 insertions(+), 8 deletions(-)
> >
> > --
> > 2.38.1.431.g37b22c650d-goog
>
> --
>
> - Arnaldo