Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2622657rwb; Thu, 17 Nov 2022 13:34:49 -0800 (PST) X-Google-Smtp-Source: AA0mqf4AbDalgRGnoMa0ecqgdG5u/vHN0d/aMoDzsZ43SWcDXNGa3VN9NkbSGBrQk3c/XIxy7cyZ X-Received: by 2002:a05:6402:2d6:b0:461:8efb:3f84 with SMTP id b22-20020a05640202d600b004618efb3f84mr3768332edx.210.1668720888933; Thu, 17 Nov 2022 13:34:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668720888; cv=none; d=google.com; s=arc-20160816; b=kRoTj3Q/0k6Fep/75JYfssKTz9qZz5bSfMWO9NULWzTeYVulMm+cVS++1y4aTbNsIZ d7zjKVb3Rh4HOVW+voL+aqbemEv4VBVLFIaDU9GaFwitSzJmiqjDCde0ZseOpE2T6frb 0nvUc8CVUMsHtWKiSOKCwd36xfS6EBzoewWN/zqinSFZYQBzedTr4j6HOEC280cYQzPk IOR7TH/n6/c6/xN+zKsy6M5ouJ/bUQ3nCYl7ZTw4q1jAoos2coxFlwq9dNKT29VjTdWv qMEq7Da0/XwMI9rHh9IsoIJbEXawoQzwtQDbFz3WrNfIBt/wPnR5GRRo6HWjef5uPxU/ 2pZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JzBJRWys7hmBHBKeMNHEuFcI/VwS1xwfjIiorP4uTYQ=; b=MGWwXsRA8MylNFWxmDHGj2EXSUPfPK9/JeRPV29Si6/Tp4Z690yIhNUvjd4TGyx9r1 rPbOBQA9OodlJvJsSH91J4YuTwWUDqLV+634FJ0xGruKMoYwTHd9GTYEPm4wWINuNRD7 6LukIHcAe3rPHO9ol6HH6Kr7x8DGwLfkQHTqKLZbvPOF3EBDYM3YSN0rlnsi113xEDsx jEgQMApOIAfonZn8Bw442Y8yZ8SNLwkiu8Kml7psvkkBRrhF3chJQL6lg2jvnPO2D7ct VX6D1Z1tJcukZiG6jnbPq9RExuiReFimEzzTCmqJyAimH3BM7D5LE6eoI5Wg9lErlYTp QGvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=I5gexTUt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dd22-20020a1709069b9600b007ae50c64522si1619467ejc.520.2022.11.17.13.34.16; Thu, 17 Nov 2022 13:34:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=I5gexTUt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240100AbiKQUQB (ORCPT + 92 others); Thu, 17 Nov 2022 15:16:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240319AbiKQUPw (ORCPT ); Thu, 17 Nov 2022 15:15:52 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9DF086A79; Thu, 17 Nov 2022 12:15:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=JzBJRWys7hmBHBKeMNHEuFcI/VwS1xwfjIiorP4uTYQ=; b=I5gexTUtNpp0792tJirhroAPdn LnMo45jQ7mkAHFFcyA6HE0yjkw7HipcbfkBDgTe0k1ttwKEh3VpTZo4i3+iDh2NX+IXqk8TpuDeDj 6EleMdhQ+R6Y8nhlcdPfJR6SNjMAufbctBtFkYLp8cAeKgAvjVt1LUX1PQJ1h0fuLFrE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ovlHS-002j30-5F; Thu, 17 Nov 2022 21:14:38 +0100 Date: Thu, 17 Nov 2022 21:14:38 +0100 From: Andrew Lunn To: Daniel.Machon@microchip.com Cc: luwei32@huawei.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, Lars.Povlsen@microchip.com, Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [patch net-next] net: microchip: sparx5: remove useless code in sparx5_qos_init() Message-ID: References: <20221117145820.2898968-1-luwei32@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > sparx5_qos_init() will be expanded in later patch series, as new QoS > features require new initializations - so this is actually somewhat > intentional. When do you expect such patches to land? If it going to be soon, we can keep the code as it is. If it is going to be a while, the bots are going to keep finding this and what to remove it. Andrew