Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Nov 2022 09:06:36 +1100
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     Daniel Vetter <daniel.vetter@ffwll.ch>,
        Intel Graphics <intel-gfx@lists.freedesktop.org>,
        DRI <dri-devel@lists.freedesktop.org>,
        =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Maxime Ripard <maxime@cerno.tech>, llvm@lists.linux.dev
Subject: Re: linux-next: manual merge of the drm-misc tree with the origin
 tree
Message-ID: <20221118090636.00bfc293@canb.auug.org.au>
In-Reply-To: <Y3ZvffZiR+SgtY6h@dev-arch.thelio-3990X>
References: <20221116105702.746ce3cf@canb.auug.org.au>
        <Y3ZvffZiR+SgtY6h@dev-arch.thelio-3990X>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/cORwCokXw/BRPsMTVykVrdV";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/cORwCokXw/BRPsMTVykVrdV
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Nathan,

On Thu, 17 Nov 2022 10:29:33 -0700 Nathan Chancellor <nathan@kernel.org> wr=
ote:
>
> This resolution is not quite right, as pointed out by clang:
>=20
>     drivers/gpu/drm/vc4/vc4_hdmi.c:351:14: error: variable 'vc4_hdmi' is =
uninitialized when used here [-Werror,-Wuninitialized]
>             mutex_lock(&vc4_hdmi->mutex);
>                         ^~~~~~~~
>     ./include/linux/mutex.h:187:44: note: expanded from macro 'mutex_lock'
>     #define mutex_lock(lock) mutex_lock_nested(lock, 0)
>                                                ^~~~
>     drivers/gpu/drm/vc4/vc4_hdmi.c:322:27: note: initialize the variable =
'vc4_hdmi' to silence this warning
>             struct vc4_hdmi *vc4_hdmi;
>                                      ^
>                                       =3D NULL
>     1 error generated.
>=20
> Obviously, the assignment of vc4_hdmi should be before mutex_lock().

Thanks for pointing that out (silly me :-) ).  I have fixed up the
resolution for today.

--=20
Cheers,
Stephen Rothwell

--Sig_/cORwCokXw/BRPsMTVykVrdV
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmN2sGwACgkQAVBC80lX
0GwqVgf7BKhwAejB2647+YTzGJFG5ESClma/Q+FqHOzAU5APyVxww5lrT7m+1h+w
l+jNOiRIU9g4WG7zOHY7MW/cOYUSCDv1XmuK4JBhI+JnMffY7vt8FxnDYYFvDiE9
VHgYmM/uzu6VgWBjp4pV+bHmqbE0zkMSVeUd9fI8qmkuzydCSWu1wiYx3ihXaTLw
1gWzctWRm+7eQMVgPI09oV2ev1VbDXh5xkzjh11Fuj02he89O0eVUt9XVJkUB0SZ
4MGRrU0SKUx5SulxF7G2ELKYI/fJVz0tTbkPxLVUfY2MGMxQWbgZVHqJwDtZNs2c
y3B3jrqzs40nAcfF7CQ/7qTj18mr6g==
=qG1K
-----END PGP SIGNATURE-----

--Sig_/cORwCokXw/BRPsMTVykVrdV--