Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2683886rwb; Thu, 17 Nov 2022 14:36:00 -0800 (PST) X-Google-Smtp-Source: AA0mqf4kcJffoU7fU9dp3Teo4kDin6nKAy2aDrcOjBnFbDaB8Otp4R730NhkL+OuDRy6j+mx5WRd X-Received: by 2002:a17:902:b094:b0:186:9fb9:1f8c with SMTP id p20-20020a170902b09400b001869fb91f8cmr4635957plr.69.1668724560636; Thu, 17 Nov 2022 14:36:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668724560; cv=none; d=google.com; s=arc-20160816; b=HAspED52/jrZS7CHzhr0rExJqDRVzznRywvyDRngII6C2iyBv2py0IfWpfAgnDmSv7 Iqy4/TRyCsZYHZnQ2FcG7xiLyTf1b/o2GMI1Mr9fcb5Ddg0REcmxiM7L/79WI3Tb4znS f5XLIDFd1qTNX/rEdQcYp75sGLbCKIFIhpe4Hxg6pngxzHXbCO+amMrVwpCEXhbibJ+K wSCgH1F8UmIJktwEgWqvw6gNRjxMF+vcaNZoCKynFjUFI+w1dlAZbd3gYSlTUqORg2w6 J9bx8fRmvv43pT5HW9kYvH2JdRd6tyCxC610oaM/OAMSbcgafKPk2BsPf7hwPG330w2C 83IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=VEdicyo8kKMcDcP6jXDPS7VZPkCWUqa7K7Caag7NcIg=; b=BoPrGZOSRnDlVrDlPpjZtrqDUbaCko9DkZ1sVFzHv3R9poCpI2jgKeqEofHJyRYx0o hr+zoUmG0l3DDG+pHIITyb/qhIWgHvnixmF7Va6klUr1qImjdm88BWXjE0OBmVnkTm+x MFyussPQcC12FNtBrIU3UrJkBwJG4lg/fRt3a6ervPOTa5Rh4Qe3ELiFnPCqRlKV4ZPi iYnaYQbd/awdfIfxf7/OP/Y9iap89YG2l5KyckjZSjuNaeCyoL34H6lFwRnIraboCht9 XjPEFGXs6yU/W3Y8l51rES+Kdw7DZPdaRUf4gy5sjDepN0AUz4/rqiQFkF7nE/mgxIdS hHCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=EUyg1tes; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e14-20020a6558ce000000b0046f5ffcfc1dsi2299894pgu.324.2022.11.17.14.35.48; Thu, 17 Nov 2022 14:36:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=EUyg1tes; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234918AbiKQVLu (ORCPT + 92 others); Thu, 17 Nov 2022 16:11:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233315AbiKQVLs (ORCPT ); Thu, 17 Nov 2022 16:11:48 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2769D22283 for ; Thu, 17 Nov 2022 13:11:48 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id v4-20020a17090a088400b00212cb0ed97eso3168010pjc.5 for ; Thu, 17 Nov 2022 13:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=VEdicyo8kKMcDcP6jXDPS7VZPkCWUqa7K7Caag7NcIg=; b=EUyg1tesRoQPe0SnCnm0UwTABVrLfxyJWbbVMkhrfQLfWZ/tlLjjHIKOuPlwn/71ax +ZhOqBjWguZJv5A0WRj/qoWf5lzr/54yYQu+XwxaJCM1diY9nrXJIyYOgofRoncuz42z HTHJUfwFvZzfZ2pkemb1C0YQJjdKFvwoblMat7y8qG7XtPk+XoTwYPz0ldkk37THfsEW b2ADdG+A3zXHyF0kfeG95rnQxJDe9m8hMF4aomTAoX5/Bwx6ud3LPZAjtztC9Eotnuku V1eLxmEzwcZNcnBQR9aTL35krykVEqK2ohdsC7d55TKBFC+dso9usvXAIawd+Csp4iyp M/YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VEdicyo8kKMcDcP6jXDPS7VZPkCWUqa7K7Caag7NcIg=; b=mrn0OMR0nqbdIEOHrpHw0x5Qefjo6SyozAE3yL7rclD0I/n9ZkfCWQp+qeYG/i4YEv xyDjKOsMdad7AQf7nPSK31PJj6bHIjnEAuaXdftdp3lf9yJRl0/RMGuBaYFXhrT4trqE 6pO0S8iPoYQ9zpa5rO53bfCVGAS/n0gey4Vj6qcN0JHrUayUS+0Y42OzMOQlNNNhrs0u 1NKaEEjomeWSoe5nEU4rSoj6YrI5qpa/EHu1NaUw2nZo3cvKOTNs9EEUyWKUoj4Ke/Hk wW8MBbwNveEMZPKIxwaWabgj/Qc93ArSmuITC+1GtUaxfCCC499T07CQgaKV8KdiTFmz 2Axg== X-Gm-Message-State: ANoB5pk0OGVrTjfMEgMNu3SHstlJtripL6uPDtiqapoww/r+ZFZ9zI+M KZyjvsOTocKKt8S98OeKFtX8Fm1xi2g= X-Received: by 2002:a17:90a:9e2:b0:218:7103:ea94 with SMTP id 89-20020a17090a09e200b002187103ea94mr4887030pjo.215.1668719507517; Thu, 17 Nov 2022 13:11:47 -0800 (PST) Received: from google.com ([2620:15c:211:201:6bbc:b70a:8f80:710d]) by smtp.gmail.com with ESMTPSA id t8-20020a1709027fc800b00186c37270f6sm1894640plb.24.2022.11.17.13.11.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 13:11:47 -0800 (PST) Sender: Minchan Kim Date: Thu, 17 Nov 2022 13:11:45 -0800 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org Subject: Re: [PATCH] zram: remove unused stats fields Message-ID: References: <20221117141326.1105181-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221117141326.1105181-1-senozhatsky@chromium.org> X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 17, 2022 at 11:13:26PM +0900, Sergey Senozhatsky wrote: > We don't show num_reads and num_writes since we removed > corresponding sysfs nodes in 2017. Block layer stats are > exposed via /sys/block/zramX/stat file. > > However, we still increment those atomic vars and store > them in zram stats. Remove leftovers. > > Signed-off-by: Sergey Senozhatsky Acked-by: Minchan Kim