Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <90b6e371-3cc2-ff0c-92fa-51fc9691c1f1@intel.com>
Date:   Thu, 17 Nov 2022 14:44:37 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v3 04/16] platform/x86/intel/ifs: Remove memory allocation
 from load path
To:     Hans de Goede <hdegoede@redhat.com>, <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>, <sohil.mehta@intel.com>
References: <c7414e8b-c113-eff8-b435-ddde705a6f6c@redhat.com>
 <20221117195957.28225-1-jithu.joseph@intel.com>
 <75da80a5-f727-2ef2-f0f5-939cce9b2b87@redhat.com>
Content-Language: en-US
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <75da80a5-f727-2ef2-f0f5-939cce9b2b87@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTl3MGNJeG4zRTVybXZIT0Y3elR2Y0xNTSt4a3pYL3FNVTNyL0NFcDIzc0RN?=
 =?utf-8?B?RXRpMGd6MjdIMHQyR0FjQllhc0V6SHBIYlRiTWpHZGtpS1lhTjFia1ZFRU13?=
 =?utf-8?B?b2dIWHY1NzVXSnNaSElaQUd4YnF1UW5zK3huZzNvSUdwNk5veVJGMWhManVh?=
 =?utf-8?B?ZjNYWU1lbmM0SEdKa3dSUHFVMjhkUzRuOFN5MTBGYWx0YTZPZzBDTzc2NmlP?=
 =?utf-8?B?d0pucW9xei96L2tyZ1Q5WFhLL0JKRzlRTTYvamlNVy83QWdDdzBiVjJ4N2VY?=
 =?utf-8?B?eDNIdVdrTXZuZUtmNGlqSElIeVB1dU1TZXFyQWJTdmlzMlNVMUU5eXpML1h2?=
 =?utf-8?B?RithQlV5Uys1eXc4aW1MUkptbXh1ZGtudUVKWS83T1pFUFVCWUdqQ284cXo1?=
 =?utf-8?B?M1JrMEpST3lzT0ZMUDAyd3ZrQ2J0OTQ0NUVKc1Z2VmZ0QzZmWWhSaXRuZlpl?=
 =?utf-8?B?UzB3T0tQSGViUm5qT1F0UkZDRGNDOW14UFZNZXhVRlpSeWE5NWRXZG1aUzln?=
 =?utf-8?B?RzBVQWdqZ21zK1hPU0pRaTZ5RndMSmt4cktCN3kxeEUzWnFjZnE4V2Q3RUJQ?=
 =?utf-8?B?YWFyekE0ZFJoWUwrQThqN3N5azVXWEllQVhtSVo3Y1hNWDZha1VKUWNQNWs5?=
 =?utf-8?B?eXBYRnh0MmpkQVZ2ODVjbnhYbEdYUlJ4dEpzdnhxd0JvdTQ4aWdyaVBPa1VX?=
 =?utf-8?B?d2t4Wjd6M0ZHQkM3REJUUGYwMC9BTUNQcU9zclhKMkExQWMwMkpVRFJLWlE4?=
 =?utf-8?B?S1VUWk13L29aYVVDZjJEU2JNeWUxVzRiN1BlbmNla04rRGNZTWRoUFJBTzJ2?=
 =?utf-8?B?UGFjcXUxYVJyNkI0VnZNbktURllhREMydFkxQzIxeWpPZWpnbXpuNnp4bUJW?=
 =?utf-8?B?azhYZXFCdHNZbS85Zlh1STRRTFZoQitaa05TdVVaSWcxS0dPTWtCWkp0eG9p?=
 =?utf-8?B?bzJYMWNNQXh2d0xQOERmMGl2aGQzOXlWNG5zckRzMWV2MWhKWG45LzhYZTM1?=
 =?utf-8?B?Smt4M3NKajBoYndraytTNFk5ZUx0YTFxN2wwQlpSZjAzVi8yQ1FUc04wSXNE?=
 =?utf-8?B?RTNMdytnZ2pyUkh2S2g3cTc0WGVlOXRaRWZQK2VnVXNnc3BtcEZvRnY3M3lz?=
 =?utf-8?B?L01VYWQ1b2o2dDdhd2EzNHZpVU1iemtoeVRLSUU1VGkvV1lzYlpIVndkMk5X?=
 =?utf-8?B?VjYyQVFZQ0IwWFhBZXgrRWhIeDU5dm9yeDdDL2NYMjgwbExYRkZteldUZEdl?=
 =?utf-8?B?Y0hSK0c1ajcvcm1oZXhmeVNNU2QrTkw5eG9hSzkrVUZjeUZhL2lpZGRnQ0FU?=
 =?utf-8?B?eCtKekZqOG5ORGlnWUo1ZFNSTmlyOWpEVFNVTXg0bllIMFlpWHlvUzBad1M4?=
 =?utf-8?B?MnhHYk9mLzdmRHNIN1FBbjJDMU5FbHJ3NlFycXJDMjFCYXF1RVZRbVh3R0Ni?=
 =?utf-8?B?SUZiVTlKSGRLWDU2eVdKNHZ1enVJZU5zdmxRN3h1MzNGTVpoNUptOW9XMGxt?=
 =?utf-8?B?c0VXaEZNYUJESnRjYkwxTEpDYmxIa2ZFTyt0c1pmWjRGK0JOeTVpc3FPSS9n?=
 =?utf-8?B?aUtiN0x6N1I5S0Q5Q1VmRzZXM0ZUOFFsUjFHN0FLWjRDY01PYk5DTWFaWG15?=
 =?utf-8?B?Y2NYMHljQ3EzUVNSL0RldGdFbzBQMHBYMlRMM25oNEpJdC8zRktEaTh1S0wy?=
 =?utf-8?B?NUdFSjQ5VXY4azd0RlhNTGQvZXlOMmNRWEIxWW4zdTdhSWJQUThReEJROExj?=
 =?utf-8?B?d3VQaldWTWFnT2Z3dEVjMU9Kcnl6ek5vcEd2SlhKNHdINC9IdTdqaldSNjRq?=
 =?utf-8?B?R2dRVi9kb3ZmQWF2WVE3ckdXbzZlYS9hYnhnRCswU1dZZUJDOU1VQnZDZHo4?=
 =?utf-8?B?a0FKTEtLQzVwTUtqV3k1WEpYME9SVHpXcnVBQWRKdFlFN1hMeEEvZ1pJRCsy?=
 =?utf-8?B?ZGpQVjVCL2p4bGdGQXY4RSt1Q1FOY2NsS2tKUU0xdFJWWTNqTEtLbmJZQ3pO?=
 =?utf-8?B?cmZqWEJ0bWhQTmNhMEVPSjY1UmY3MnBPREdHWTJCMHFBOUxIRmNMYU1MUXA1?=
 =?utf-8?B?QjFLbWNIY3lLREtDaXdYRjl6UFBIUVRwZmt4bUtyU2h0L25FRVlLMFRPb2Ry?=
 =?utf-8?B?cXg1L0EvSEhacWFhWWZXNWtyU005bTl1MXhuQ0NlVFdHTWNhRUF5WHlrYmh2?=
 =?utf-8?B?eWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e00374e-d18c-4e18-8dee-08dac8ed50bc
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 22:44:41.5560
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZlBIowItPZfyco2d2DL4szadBRvwPsCCamiWK38pw17SdAkL/nan1L3+QH0oxJqyczizKY/H/xo1bm4AgcZL3Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6285
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/17/2022 1:13 PM, Hans de Goede wrote:
> Hi,
> 
> On 11/17/22 20:59, Jithu Joseph wrote:
>> IFS requires tests to be authenticated once for each CPU socket
>> on a system.
>>
>> scan_chunks_sanity_check() was dynamically allocating memory
>> to store the state of whether tests have been authenticated on
>> each socket for every load operation.
>>
>> Move the memory allocation to init path and store the pointer
>> in ifs_data struct.
>>
>> Also rearrange the adjacent error checking in init for a
>> more simplified and natural flow.
>>
>> Reviewed-by: Tony Luck <tony.luck@intel.com>
>> Suggested-by: Borislav Petkov <bp@alien8.de>
>> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
>> ---
>>  - Replaced global pkg_auth pointer to struct ifs_data (Hans)
>>  - Rearrange the adjacent error checking flow in ifs_init (Hans)
>>  - With this change there are conflicts in patches 11 and 12 (I will
>>     post the updated 11 and 12 if this is satisfactory)
> 
> Thanks, this patch looks good to me now:
> 
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> 

Thanks for the detailed review and suggestions.
I will now resend patches 11 and 12 which will apply ontop of this revised patch4 . 

Jithu