Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <219dc20d-fd2b-16cc-8b96-efdec5f783c9@seco.com>
Date:   Thu, 17 Nov 2022 18:40:02 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] phy: aquantia: Configure SERDES mode by default
Content-Language: en-US
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
        Eric Dumazet <edumazet@google.com>,
        Tim Harvey <tharvey@gateworks.com>,
        "David S . Miller" <davem@davemloft.net>,
        linux-kernel@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>
References: <20221114210740.3332937-1-sean.anderson@seco.com>
 <20221114210740.3332937-1-sean.anderson@seco.com>
 <20221115223732.ctvzjbpeaxulnm5l@skbuf>
 <3771f5be-3deb-06f9-d0a0-c3139d098bf0@seco.com>
 <20221115230207.2e77pifwruzkexbr@skbuf>
From:   Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <20221115230207.2e77pifwruzkexbr@skbuf>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGlId3N2cTNoRGtLZnNZTDgwYjE2T0p5NVd2NXlpbjEvR1N0Y05YV1RzQmtk?=
 =?utf-8?B?MGROcWF2YWtTdG5NaXExN3BvUDJjSEw1SXovczcvYmJlZGZYSnY0V28yMU9G?=
 =?utf-8?B?WGRXVkp2aHhPZ09TVzVtZHZYUXdsaGJEOFZjbXZhbG5PZVVLMUhWd1FZVElS?=
 =?utf-8?B?Rk5Va3Fobm9jdko5aDFxMEVCZ3VONy9wclpxMzVrZE0zRm1DUEpDcnN3a2dN?=
 =?utf-8?B?RTB6MktMMEhuSXlXN015akI0Smdxa2U3Wm9hNHM0YktTU0c4cnBCTUpUQ0xa?=
 =?utf-8?B?OXR3S3hVRzJCNmtDcW1DWmdRRWJ0YlliQXZ2dDVicTFMc2NORU9MSE1NVEFD?=
 =?utf-8?B?dnpsUjJ5WTFJMEVnVm5NdGhGcUlZRnd5WUxYRjFZU0Q2NFpqUjJDRkJVK1lG?=
 =?utf-8?B?SXpRTnlNU3F6SVVXWW05djkvaFZCUUY3OUxtOXRXa28yemI0NUNTcVU4bnV4?=
 =?utf-8?B?RlV5RmtDcGx1akpVQkZuNFRwNkpRYVhMNGRxSmNyVkxxekZXS3hScmc1UVVU?=
 =?utf-8?B?bTF0dndMRUdLN3VPZVFVUURrczNvWjE3dnIzZ3pMZkNmeWc3em1HQ2lkU2xw?=
 =?utf-8?B?SExGRTBlOWxYeGs4c1ZpNGJxWkp4VnpXRGYwdFZ0NTNZK2xza2wyd0Z2NEUz?=
 =?utf-8?B?MHhCN0hTY00vRlF0U1lhcTdqN09ZenlBaVpqMGxUQkIxSlZGcXVNdGs1N3hY?=
 =?utf-8?B?TGxKY05Iem9vb3BpZ0kyelRSMkZkWHBTQ0lPTTdmZUZHS1RTbm5jVXE1VXB6?=
 =?utf-8?B?bnFMMVk2Z0NDODJaSDRodlpaOHFjVXcvRXhXYitzRUpNNmU0M1JUYTIwclVh?=
 =?utf-8?B?UmJubWx4cjNLenhUcXRYWCtSTjhDcHY1bi9ZK0xFc3R2UUZkZDVybURQVUQr?=
 =?utf-8?B?TWQrV0xKYmNQaTAwMnFUOWhFUGc0WThJRTdtVlVxRWxDOFZjVjBtM3pwS0tE?=
 =?utf-8?B?UDNibm1qQTlWdEl5ZThTeFhLdTM5YWpISFVUS0F4Qit5YURxUTR1ZzBwYjdM?=
 =?utf-8?B?b2o3VmxnNnI4WTYweWNWdkhnRDNTWkFvZEw2Q0IrZ0MrZ1VkdVV6d1Y4djB0?=
 =?utf-8?B?d01JTzcxdDZ4UlAwMjZQNCtKL0JGQURmWGFWVFVOM0VIUFpMcjh5MzY4MHpr?=
 =?utf-8?B?eE9oVlZWT3gxOWlLaTg1NVY3ZCsrM0Z1c3dVbkh1WHJ1bGpMbThxZ2drRkVY?=
 =?utf-8?B?ZCt5THIrMnBGemtHWkt1My9LclNPd0M0R2lSTFYybDdVWjFMc2dreUVWTmNJ?=
 =?utf-8?B?Y2hXcGxkSVQrbWNyTGJNSHREc3F2UWFOY2VSTDY4cWNQd1k1dGkvYVhQczdp?=
 =?utf-8?B?TWNMVFlGd0M4NFpCc1hjY2tJaUdURGRENjk2VlpSQW53UXJhV2hFT2ZiUnFr?=
 =?utf-8?B?UzQ1MXo0NG1PT3U0WUt1ZGVBNUY0cGl4UHR5RnNmRzZmOEFoajg5VDV0Uk0r?=
 =?utf-8?B?Y3RzT0I2VFRoWTdjaWhxY0l0K1lZbzl1TWRLZU51VktpcTZZYUFZWDdzMmY1?=
 =?utf-8?B?NEFIMmVNaDdXOWdMa2hFSElQQ2hRNnp5R0hmdU5LYzFlSGpPUTZFY256QUlw?=
 =?utf-8?B?SWJoRUtBbUhHS2NoTlRncklNR1VsL1JvV0hhbUZ2cHRSNzhpd3F5aHE4M1N3?=
 =?utf-8?B?M2d3VXJYcXUwaklWYXI4NFIyeHp0YlliQUczNGxoUGRXYlU5NmZBdGhTZmlB?=
 =?utf-8?B?aE8vWVA5WkJjbEF1NTRwWGk3aTJZQTRJRm14MmpVa0Vlb1k3N00vODI5UlEv?=
 =?utf-8?B?NkN0UXFUa28yRGNGL3RDRDV4YzU5bmxBUGhmYXd5YTQ0MjVUL093cEdPNUY3?=
 =?utf-8?B?OXphNWVMSDRDcHVUcWZ4TjJMRitTUWYxTVc4WjhQM1IwN2k4dkljOC9XYWlw?=
 =?utf-8?B?SGxvUnRYL3AwVnZsY1cyc1hycHFXb0k4bk1haWQ0REMwMDZ2aEY0bnA4M0M0?=
 =?utf-8?B?U05iNmxROERlRzBSbVNEY1dqVzQyc3lVMzBSeHYvdFBOVmVhZDk2VjZnWDlF?=
 =?utf-8?B?UktsMmxRQzl2d3R6aVNycG54RXRZSVJzZWZtSFduU0Y4a3FQL2pPVmdBOWgx?=
 =?utf-8?B?YkRsK1lWL2NBMks4Zko0SXFDRHdiWTJMbXFZQXczS3p3MTBVSFVoVTZ3ZWdK?=
 =?utf-8?B?dHFNZ3JVckJCOCtrWUFlMGxZWnZlRk9NclBhcWxtZCtyTDFSSVpyR2djMHFm?=
 =?utf-8?B?Y0E9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2be505e0-8e12-4221-4752-08dac8f50ecd
X-MS-Exchange-CrossTenant-AuthSource: DB9PR03MB8847.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 23:40:08.7544
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: coPhCg6aK4N3LIPT2Y4G5EeopP319U3s+m+Yj2ngt+FahiSeNmexMoCl9zLxFQoTjdQwNd6ugWqvoCsoj19Dnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR03MB6330
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/15/22 18:02, Vladimir Oltean wrote:
> On Tue, Nov 15, 2022 at 05:46:54PM -0500, Sean Anderson wrote:
>> On 11/15/22 17:37, Vladimir Oltean wrote:
>> > Was this patch tested and confirmed to do something sane on any platform
>> > at all?
>> 
>> This was mainly intended for Tim to test and see if it fixed his problem.
> 
> And that is stated where? Does Tim know he should test it?
> If you don't have the certainty that it works, do maintainers know not
> to apply it, as many times unfortunately happens when there is no review
> comment and the change looks innocuous?

Sorry, I should have done a better job communicating this (probably by
marking it RFC).

> Even if the change works, why would it be a good idea to overwrite some
> random registers which are supposed to be configured correctly by the
> firmware provided for the board?

They're not random registers. They happen to be exactly the same registers
we use to determine if rate adaptation is enabled.

> If the Linux fixup works for one board
> with one firmware, how do we know it also works for another board with
> the same PHY, but different firmware?

How do we know if a fix on one board for any hardware works on another board?

> Are you willing to take the risk to break someone's system to find out?

I hope it doesn't come to that. I would much rather get some feedback/testing
so I can be more confident in whatever we end up doing (or not).

Well, part of my goal in sending out this patch is to get some feedback
on the right thing to do here. As I see it, there are three ways of
configuring this phy:

- Always rate adapt to whatever the initial phy interface mode is
- Switch phy interfaces depending on the link speed
- Do whatever the firmware sets up

On my system, the last option happens to be the same as the first.
However, on Tim's system it's not. I had originally considered doing
this kind of configuration in my initial rate adaptation patch. However,
I deferred it since nothing needed to be configured for me.

The problem here is that if we advertise like we are in the first mode,
but we are not actually, then we can end up negotiating a link mode
which we don't support.

I think there are a few ways to address this:

- Always enable rate adaptation, since that's what we tell phylink we
  do. This is what this patch does. It's a bit risky (since it departs
  from "do whatever the firmware does"). It's also a bit rigid (what if 
- We can check all the registers to ensure we are actually going to rate
  adapt. If we aren't, we tell phylink we don't support it. This is the
  least risky, but we can end up not bringing up the link even in
  circumstances where we could if we configured things properly. And we
  generally know the right way to configure things.
- Add a configuration option (devicetree? ethtool?) on which option
  above to pick. This is probably what we will want to do in the long
  term, but I feel like we have enough information to determine the
  right thing to do most of the time (without needing manual
  intervention).

> As long as the Aquantia PHY driver doesn't contain all the necessary
> steps for bringing the PHY up from a clean slate, but works on top of
> what the firmware has done, changes like this make me very uncomfortable
> to add any PHY ID to the Aquantia driver. I'd rather leave them with the
> Generic C45 driver, even if that means I'll lose interrupt support, rate
> matching and things like that.

I think these registers should be viewed as configuration for the phy as
a whole, rather than as guts which should be configure by firmware. At
least for the fields we're working with, it seems clear to me what's
going on.

--Sean