Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2791213rwb; Thu, 17 Nov 2022 16:28:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf4caagfzTLx8x6pg6lAQf2JXjztUxatIw48yiwyja0tOdXNlmJr8KJU2GL2KiZZAvBjWTCh X-Received: by 2002:a17:906:9d12:b0:78a:d075:98d8 with SMTP id fn18-20020a1709069d1200b0078ad07598d8mr4115410ejc.324.1668731307896; Thu, 17 Nov 2022 16:28:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668731307; cv=none; d=google.com; s=arc-20160816; b=uX6ovikiss0mIJDRbZeAfgO+TxgjnnUTrbXGdz0dXppdEx8KUVKhR+X9GPelQOndD5 H+BnWnqctLSjPFPp93Li3W6IJdRwefWxkUkuI7PIzSmZ3ppVUePHLNy7JxAUwf+lJ5L2 wZR/cNUv364sK2NqC4lP/z3ian/fNsNF3kYtAdpOfQukji0UyaKRUvXM3cZJdxgWwjWj 7F21EGGtxf5Zedhi+ryIQ0aikXaVfJxm6KaJ0PfLcdxjk5dUpe9NqajWOR1jCOAoYDeB +N3XgWBZcsbhT/tBl46bnrr6ijweRi4JJFFUu9Ugk870eqpxCKuKPnSFDnwF6inpi4S3 +QmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WaULKejZt+35jAOfOtVnAcClVJpXKCwVJ0JC4+/Un9s=; b=qcG4Hd/GPXBG0HtnQWSzN0LeJsVweblkkY8HgXs3F7pYdu9/DdSgAdVbGaLd4TOKTp MSYmdwM3NGKL953l9BfLEQvUOH1J3iGjCc3uHaN7Un8VfXo1qL1Cv1XYFd0BpKMEMuXK ByHbuHYuG+kd+12+O6t8hAjBNsF9xs6cOTEF4fOGTj9/I0QQMVIX8NJLOfIXT+Wwqclt AFvqOBWN+6vtEAy0RdD5S/8poIVAaG/zqeaFdxXfJiyS9ybCEZRjBVohIbo/SL7mpFRE 0vUgl2Jmszibo9hcXNtkTFAaOcxF3WGR3NxGmRkaQV6aGtulYG5hLfD0KTRdWj0zcEOy /g1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=HhDunirG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o7-20020a056402038700b004674c93ecb8si1900784edv.326.2022.11.17.16.28.05; Thu, 17 Nov 2022 16:28:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=HhDunirG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235033AbiKRAET (ORCPT + 92 others); Thu, 17 Nov 2022 19:04:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234918AbiKRADl (ORCPT ); Thu, 17 Nov 2022 19:03:41 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0C09BD3; Thu, 17 Nov 2022 16:03:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=WaULKejZt+35jAOfOtVnAcClVJpXKCwVJ0JC4+/Un9s=; b=HhDunirGrzcsSeWJBbUj1pexEr 5fFwpOKn9fMYE265/AIRk0Y/bKpRGVAM8MWetRzIKRrCEUQUE1o0e7xj2U3lbF8r8qZx8lK0xoH2j +Km1+X5Vd9fOnuxpNl7JSyAwzuq12emIIJP2luHWZF5ogJD7kOn+FHLNWZXMJkU1JhPQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ovopx-002k78-If; Fri, 18 Nov 2022 01:02:29 +0100 Date: Fri, 18 Nov 2022 01:02:29 +0100 From: Andrew Lunn To: Sean Anderson Cc: Vladimir Oltean , Heiner Kallweit , Russell King , netdev@vger.kernel.org, Eric Dumazet , Tim Harvey , "David S . Miller" , linux-kernel@vger.kernel.org, Paolo Abeni , Jakub Kicinski Subject: Re: [PATCH] phy: aquantia: Configure SERDES mode by default Message-ID: References: <20221114210740.3332937-1-sean.anderson@seco.com> <20221114210740.3332937-1-sean.anderson@seco.com> <20221115223732.ctvzjbpeaxulnm5l@skbuf> <3771f5be-3deb-06f9-d0a0-c3139d098bf0@seco.com> <20221115230207.2e77pifwruzkexbr@skbuf> <219dc20d-fd2b-16cc-8b96-efdec5f783c9@seco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <219dc20d-fd2b-16cc-8b96-efdec5f783c9@seco.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Well, part of my goal in sending out this patch is to get some feedback > on the right thing to do here. As I see it, there are three ways of > configuring this phy: > > - Always rate adapt to whatever the initial phy interface mode is > - Switch phy interfaces depending on the link speed > - Do whatever the firmware sets up My understanding of the aQuantia firmware is that it is split into two parts. The first is the actual firmware that runs on the PHY. The second is provisioning, which seems to be a bunch of instructions to put value X in register Y. It seems like aQuantia, now Marvell, give different provisioning to different customers. What this means is, you cannot really trust any register contains what you want, that your devices does the same as somebody elses' device in its reset state. So i would say, "Do whatever the firmware sets up" is the worst choice. Assume nothing, set every register which is important to the correct value. Andrew