Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2876924rwb; Thu, 17 Nov 2022 18:06:15 -0800 (PST) X-Google-Smtp-Source: AA0mqf4ekKVC2xo0G/h7SH6zboRCi6omJMUHGYa9HG/MWuZX2gXdaDgMwoRtW9CTecSRwC0Ihv45 X-Received: by 2002:a17:903:1109:b0:186:cb27:4e01 with SMTP id n9-20020a170903110900b00186cb274e01mr5366899plh.139.1668737174937; Thu, 17 Nov 2022 18:06:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668737174; cv=none; d=google.com; s=arc-20160816; b=VTfQTVIRVU0HPH4h+Dhy+XfPe3v++xyMt7avRX008vcTKT/GxmNY8eZj4l0OBb468a vdKDoTXGe6YbYelKPPWIQqNVRUSHD32c84FTYMWPWGAxQ+8C9H3XDjHInMVbY7tAoDAa tTNSxWTC8yGG2Pd3AK4lzC3iWPNlrQwct4tFROkf9OBhnLVF1kXVvCHD0asOwaJcv40V agYLx8/6ZEJaKwTrmAlyMT9LQSMtFcfEmbNq1CwREPaXif87YwYPP/pe4f0WDauYd59Z MLSYem09Q6JU01BBdJV/S/wDDTfHlp31FHF9+7sS8IakDeSEIfH+kirg9/85o/Fmw5rm NpRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=n4+3CUE3iLdfQjuG3xliVKFmDGRGztUFw8Xbx8ZTbyE=; b=GZPRKQl0c2hwGC3Yg64aIqNOhi3k+4ic2HZDBijSwItcCx58ZBzA4ozJxmy1NLEkXJ rN73eiGJvA9W0e9RsgYalbol3TOtViJeSxIyiG9ayIaI+PGZ84bVlPkWcI7Ugttse4Td eqjiOmSxHkhEEDdcV5i5sMFtWLkZMFlPzV0vv8lAtSzr7igIDYV2KNCQ+r2NfgOC0PWn tNOH5f0r1POfWQhL9+pjjleU1JyOh6Tm9ybMSseX+ow/U1BSjAE0WCrd7K/OEDMmgXs6 RIf0smFGv7cHl6c128HiWdCiDITsgvo2WgVYtXQsaK3xtNMXE6jDHSJuJyz9Rgf8Xd56 TpIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kKBqbaXg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v8-20020a634648000000b0046f55fec417si2481391pgk.650.2022.11.17.18.06.01; Thu, 17 Nov 2022 18:06:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kKBqbaXg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240825AbiKRBkT (ORCPT + 92 others); Thu, 17 Nov 2022 20:40:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234794AbiKRBkS (ORCPT ); Thu, 17 Nov 2022 20:40:18 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B05C8B50 for ; Thu, 17 Nov 2022 17:40:17 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6188DB82266 for ; Fri, 18 Nov 2022 01:40:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 083D5C433C1; Fri, 18 Nov 2022 01:40:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668735615; bh=iCbgOnNn/yVg5FX1hHmLBR0hboHD1/UUrrApiVRUky0=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=kKBqbaXgbD1ee6r3hSKGhBWQx6t1iNnup6UtWNDI6vfb03IY6/GVcsJEa3a8V2BPP +sR79hDVEPQsSxxKfrBevYjoE92LLZMGNRU3YHVpkWfm/9J2qsDu5F1lz3vLDymd2d 3vi4tpS9yHTFfqpOXPzA6Qe5OPX3WXkLHGdY5oUxTCdTYhBnBCKtbZwt36d401/ru0 MbxvbXoCSOePZ8/Ej9TDsaApPgTwUbE0ubHgslZXQszYqNlz3LNoyKlibByxjWr4qe wRk5Rcg5ypY89Lju2SGm/ul0PDcd/4kTUdM1Elo1HAa7y9edqA+sV5m4Bpc5IJw7vg Guy+1GBd8nEGQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id D8F26C395F0; Fri, 18 Nov 2022 01:40:14 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] platform/chrome: cros_ec_lpc: Force synchronous probe From: patchwork-bot+chrome-platform@kernel.org Message-Id: <166873561488.28831.7438048035126651837.git-patchwork-notify@kernel.org> Date: Fri, 18 Nov 2022 01:40:14 +0000 References: <20221111231302.3458191-1-briannorris@chromium.org> In-Reply-To: <20221111231302.3458191-1-briannorris@chromium.org> To: Brian Norris Cc: bleung@chromium.org, groeck@chromium.org, tzungbi@kernel.org, dmitry.torokhov@gmail.com, swboyd@chromium.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to chrome-platform/linux.git (for-next) by Tzung-Bi Shih : On Fri, 11 Nov 2022 15:13:01 -0800 you wrote: > This reverts commit bd88b965ae8c ("platform/chrome: cros_ec_lpc: Mark > PROBE_PREFER_ASYNCHRONOUS"), and then some. > > It has been reported that there are issues with 'cros-ec-keyb' devices > that are children of this. As noted in the initial patch for its ACPI > support (commit ba0f32141bc5 ("Input: cros_ec_keyb - handle x86 > detachable/convertible Chromebooks")), it's possible to probe an ACPI > child device before its parent is probed -- hence the need for > EPROBE_DEFER. Unfortunately, poking your parent's dev_get_drvdata() > isn't safe with asynchronous probe, as there's no locking, and the > ordering is all wrong anyway (drvdata is set before the device is > *really* ready). > > [...] Here is the summary with links: - platform/chrome: cros_ec_lpc: Force synchronous probe https://git.kernel.org/chrome-platform/c/ca821c1f4ec1 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html