Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp10169rwb; Thu, 17 Nov 2022 19:19:15 -0800 (PST) X-Google-Smtp-Source: AA0mqf4cMrICSIsm5NLt8PChJ1f+XmFqb47zwmsh6o8WSYQkA/XT3oX/MdvoInNusB4sobRVNjkB X-Received: by 2002:a63:5641:0:b0:470:48c2:3aa1 with SMTP id g1-20020a635641000000b0047048c23aa1mr4876088pgm.45.1668741554719; Thu, 17 Nov 2022 19:19:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668741554; cv=none; d=google.com; s=arc-20160816; b=uCgVOkac+zxIht7puPJBT1nlb29+1As+eru6DCkTaPNthsDAUdiGRjN/+KY9AnQx5Z Dz2ATcA8wixWQRpaGWcE6dfB8kam2rZSxQsPFXlgiBd9Q5PX9W9Ad0Lf6QLmJm/Hxtrd jWwfh/+Wxb/sds7ugLS2A87ImC7wqygow/MHdZ3J1q5At3sfq4S3f5pvUMOoqZ7Ciuy9 wieP/IcNMK/a7tNLLWAjw6xu8CEMrSE6a5srGwynH+2j+TUV+0FHRYu/FIEOQvYklduJ ArqqLJjHdVYAsoUl0Z1nTxdwoLOwMykNTNfLR8rEQmVAXH4usLGKv1pybz4F3g1y1uNe hv0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=OQmYBT6P/2H3zDKUuL1fe32vXFPlDlBRe16RHFc1eoY=; b=VP95uqqQvu8CIogB9P3rW3pF0XILik+yRbIiJBGlLi23C2NYfP5KyUTcWz/MwcpEZ8 78lbhVWDAOxo2q8svjA2hNOSxLvLzu7513RVueHnm4Kt91YOPVW8fWfZidNteZvXgR8x VYzWCt9wFNKrbwt4p4Ic0mB4Lj7wIvETRc9DjSBNdQSf2lV9xRCM2XiyVyByMWDYuXDC 4400WrbQ8vdpWrOaEKUR5cQU5Y6OpS5G3B4ZY0tHUfhg5Xpv5/1gTwRMkQvEwYeGua23 zOA3l0FWfg3jYxGEyH4++9HbfqvPD399JtC2HQgYvQA2OezGAFpbR95JS8gswYbFKrp9 8IgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nN1z2tvR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e10-20020a63544a000000b00476fc220c97si2624628pgm.648.2022.11.17.19.19.00; Thu, 17 Nov 2022 19:19:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nN1z2tvR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240720AbiKRCuA (ORCPT + 91 others); Thu, 17 Nov 2022 21:50:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235035AbiKRCt6 (ORCPT ); Thu, 17 Nov 2022 21:49:58 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 129E119001; Thu, 17 Nov 2022 18:49:58 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A469A62312; Fri, 18 Nov 2022 02:49:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8B09C433D6; Fri, 18 Nov 2022 02:49:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668739797; bh=OQmYBT6P/2H3zDKUuL1fe32vXFPlDlBRe16RHFc1eoY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nN1z2tvRBiLyKjsys3UI6W9oq47wakCVQfdQAiddMlt0JA9JbtsMRdJYzk1FQLUeH 7xs3kQdiWRxpwtzbvxhOcq/Y7fGhgyUDBwqZF3pPhdMY6OshBLMTLWA0qNhnmQhPSd SBcNof4Z4qATlaEDIfClS/uP2y6j3qI6pS1XqCvrV/ox6grGCTu9+nqeY1w/J1B9eh Gt1th5G1WpdJJX9nD08BKwOEdT0u22IudI0e4tINleQZozxFViXtulLfMFVVGXBjuY PU2uMIwppQBP6PHYo1UVtZVzMyedYb91YlkjCqevoDQnV2MVlxREARzNqv33jaR99R dcQEPqNfeiRgQ== Date: Thu, 17 Nov 2022 18:49:55 -0800 From: Saeed Mahameed To: YueHaibing Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, atenart@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] macsec: Fix invalid error code set Message-ID: References: <20221118011249.48112-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20221118011249.48112-1-yuehaibing@huawei.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18 Nov 09:12, YueHaibing wrote: >'ret' is defined twice in macsec_changelink(), when it is set in macsec_is_offloaded >case, it will be invalid before return. > >Fixes: 3cf3227a21d1 ("net: macsec: hardware offloading infrastructure") >Signed-off-by: YueHaibing I have the same exact patch lined up in my internal queue. this needs to go to net: so for next time please tag [PATCH net]. Reviewed-by: Saeed Mahameed