Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dd1fbe2d-585e-8298-bd36-56b3bd4a9ae1@ti.com>
Date:   Fri, 18 Nov 2022 11:18:54 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [EXTERNAL] Re: [PATCH v8 1/6] dt-bindings: remoteproc: Add PRU
 consumer bindings
Content-Language: en-US
To:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        Rob Herring <robh@kernel.org>
CC:     MD Danish Anwar <danishanwar@ti.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Suman Anna <s-anna@ti.com>, Roger Quadros <rogerq@kernel.org>,
        "Andrew F . Davis" <afd@ti.com>, <nm@ti.com>, <vigneshr@ti.com>,
        <srk@ti.com>, <linux-remoteproc@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
References: <20221116121634.2901265-1-danishanwar@ti.com>
 <20221116121634.2901265-2-danishanwar@ti.com>
 <20221116160948.GA169555-robh@kernel.org> <20221116180949.GC61935@p14s>
From:   Md Danish Anwar <a0501179@ti.com>
In-Reply-To: <20221116180949.GC61935@p14s>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Mathieu,

On 16/11/22 23:39, Mathieu Poirier wrote:
> On Wed, Nov 16, 2022 at 10:09:48AM -0600, Rob Herring wrote:
>> On Wed, Nov 16, 2022 at 05:46:29PM +0530, MD Danish Anwar wrote:
>>> From: Suman Anna <s-anna@ti.com>
>>>
>>> Add DT schema binding for PRU consumers. The binding includes
>>> all the common properties that can be used by different PRU consumer
>>> or application nodes and supported by the PRU remoteproc driver.
>>> These are used to configure the PRU hardware for specific user
>>> applications.
>>>
>>> The application nodes themselves should define their own bindings.
>>>
>>> Co-developed-by: Tero Kristo <t-kristo@ti.com>
>>> Co-developed-by: Suman Anna <s-anna@ti.com>
>>> Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
>>> Co-developed-by: Puranjay Mohan <p-mohan@ti.com>
>>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>>
>> Run checkpatch.pl and fix the warnings with the tags.
> 
> My bad - I asked Danish to remove the SoBs to lighten the changelog
> presentation.  Danish, do you absolutely need to list everyone that touched that
> patchset?  If so I suppose just listing the SoBs would be a compromise.
> 

I started working on this patch series after version 5. In the first version of
this patch series below were the tags.

Co-developed-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>

I am not sure whom to drop and whom to keep that's why I have been keeping all
the tags that were present from the beginning.

In the next version I'll keep only the SoBs tags of the the people listed above.

>>
>> You didn't add review/ack tags either.
> 
> Those are important.  
> 
> Please send another patchset that clears checkpatch with review/acks and I'll
> look at it.
> 

I am really sorry for that, I was not aware about adding review tags as I am
very new to upstreaming.

I will share new version after fixing checkpatch errors/warnings and adding
review tags.

Thanks,
Danish.

> Thanks,
> Mathieu
> 
>>
>>> ---
>>>  .../bindings/remoteproc/ti,pru-consumer.yaml  | 60 +++++++++++++++++++
>>>  1 file changed, 60 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml