Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bdcd2071-8f56-b829-7e78-3fc9efec09fc@wolfvision.net>
Date:   Fri, 18 Nov 2022 08:03:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [linux-next-v2 1/5] arm64: dts: rockchip: Fix gmac phy mode to
 rgmii on Rock 3A SBC.
Content-Language: en-US
To:     Anand Moon <linux.amoon@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>
Cc:     Chukun Pan <amadeus@jmu.edu.cn>, Peter Geis <pgwipeout@gmail.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20221116200150.4657-1-linux.amoon@gmail.com>
 <20221116200150.4657-2-linux.amoon@gmail.com>
From:   Michael Riesch <michael.riesch@wolfvision.net>
Organization: WolfVision GmbH
In-Reply-To: <20221116200150.4657-2-linux.amoon@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q3NqWWw5blM3Y0EzY21tSEUvL3NuUGtNY0tVTXVKM2lNaW5pSnFUZ2lNWVJj?=
 =?utf-8?B?UkM3OEhwTks5U1JDQjdFQzJYbjM1Vm0zWkhMekF6QnN3Rk93cmVDL3RnTmV3?=
 =?utf-8?B?UG5rYWFZNjR2OURvL29Ja1RESXkvcTM5eUFYS01VaG5oekg2MklwelRQandJ?=
 =?utf-8?B?c3IydS8wdlgxSUx2c1hYekVSVTU1NTRMQ3psUms0TU03WFBJT3ZkWGRUWUxo?=
 =?utf-8?B?a2tHL0hqU1p5T0VydkhyWTB4VjdDRGlTUGVOV2xkWG40YmpyN3h5RXF4T0F1?=
 =?utf-8?B?dnJCZUZxYXBOT3dESjVzczVSdC9MY0FnQnRITkZvOVlocWNkRUpZU1ovMWxz?=
 =?utf-8?B?MGxWR0tRK2hKSDdXNXkrVStiNjhwMDltVFJncHdyVHZhckRpbE1PUW91emlo?=
 =?utf-8?B?MVJ3R2hmKy9aTFhGbHFhbU5MZ3pNWEJJNTJ5TkdsM0s2S1ZMY2lBRWZ1ay9F?=
 =?utf-8?B?Rm9mVHEvY2NZZE82MTZxVlBZQkJWcFgvcnJxNFZud0dndlcwcHdsVUpndDJw?=
 =?utf-8?B?ZG5ramFlZmV6SFNpeHBCSFVLSmdhTlZlTkNCMDBRR0ZNS0NGbm9WM3lHeFlS?=
 =?utf-8?B?WnNRZ3ZBUWNQWktXd1ZVQlpaQ3pEditpL2FTQ0k5b2doY1I3TUFFaVNjcHdS?=
 =?utf-8?B?Y2RLcXNURUxYNE0xWVBIZENIYnpZdHFjM0N5aXoycmFoSC9OWTF2THRJNW5r?=
 =?utf-8?B?THBVdUR4Rnlta0p5VHo5MUh5UUk4amc3NHNKOFdSazVIRmlaQmhmWkNRZ0hK?=
 =?utf-8?B?VndOdkZURDJuTWE1bU54L0RhRXplV0JFeEQwcHNwOHNGZVNLWHRYVC9nSzFX?=
 =?utf-8?B?UTFsUnNNRXVpV08zcWw5MHE4bis4RnZkYngvQ1FuY3BZaTdpUnFTb1MyVWdw?=
 =?utf-8?B?Vzd0d0J6OHRaM3JoRDk0QlVlQ3kvaFErUVh4WEF1bEE2TnB1TE83QWthOW1i?=
 =?utf-8?B?VFB2VVBWQi9abnlNWU0vTFpjSytSV2RZWVFrZGQ3NndQek5OK0pXeGtNU1Ux?=
 =?utf-8?B?V2pnc0NTOXU2SGwyZ2F3S3NqdWtDcUc4Sk9zT05WRjZ5WGdFWUVadmJUOGNF?=
 =?utf-8?B?Q3JtZDEzaXRxQXJpQ3RaV3N2TWkrejViSWFHT2FBWUF6b3g4WkRJK05kbDdJ?=
 =?utf-8?B?RG8xc1dyblFJckkzb1hFaVRnNmZwblUvZHBTM3F3djhUL3BwVzdZSWZmYnVS?=
 =?utf-8?B?VEJnL2JzZTJHbCsvemg2emRFU0VxVkRDT2gxenNqWldjQ3U3amRWOE13VXpF?=
 =?utf-8?B?OGJ0M0t1UGRoQ2o4RFhGOWZWNU8yQnhQSWcvT1N3WUlVYXkxa3BtOHVYZi9P?=
 =?utf-8?B?d0prdDNIWmw5aWdzSU0zWDVNajBPUy9MVmR2eHR6cVdRL3FtcFdEcDVqd3FV?=
 =?utf-8?B?aGRZQjU1ckp1UmFNRWY3MkZUc3BMZjZlRXVxUEJmWDFUY1ZTbUY1S0l1Z0dq?=
 =?utf-8?B?RGxGNHpBQUo3KzYrNzZlVlpjMEhPWXBSSmV0c1dMa2hvREpNdmZXblpEbkhi?=
 =?utf-8?B?KzJWcDhlcVVGbUVFZVJNamxIbEs1L01ITXZHYkRSdmNWYzhVL1VYbWZES0VJ?=
 =?utf-8?B?a3p5STBrMHM5TW1qUVZUakVqMG1JVDUvNDAzM01xT1FrTmVkR0RlamxQSFM5?=
 =?utf-8?B?ejY3dUQrREtFWUhuaHVtWjdiNUlVdG91aGdMQ2dmdTZHSVJERzV2aWRLek9T?=
 =?utf-8?B?TzlrdHUrRkdjUWp4bmlpSnVHV2VrNGxOK2o5bnF4a09JeUY1cTNQTjZVenVU?=
 =?utf-8?B?YWJKK0ZxbjJzS1h0T2RJSlBPRDJPamgyUzBDbmVZSGF1aU5qZ2lGbHRTNHZE?=
 =?utf-8?B?RVVkZ0tWam10dXV5Unl6MUh6MVBXT1h6eG14Mi9vNFFuTlZVbWVxdGIzWldX?=
 =?utf-8?B?WDJoMitZQmxpVnAwWThjOGVNM2xTNEtGMHlVVUppMWRNeEJVcTd2TWgvSlha?=
 =?utf-8?B?dWsydDV6NkZaUkE0emhLMzN5L3QwbFkrZkU0UmgyRGRPL3JzUWNxNndtNHlU?=
 =?utf-8?B?WXN5dlBoMUtpVDZQUUo0K1k0SHpTR0hrN3FJMzQ3V3Vydk9YK3lIR3ZOaU15?=
 =?utf-8?B?Y3pLaGE2Njc3aHQwMmoxSTh1K2JCVlVOejM0NXl5ajRFamJ6SkVlUnRkV1Nq?=
 =?utf-8?B?OHlPaGhiY0VsdFc1L2MwMGpBUVZjaWYwRVZ3NXZIVjloOXhCelhUSHlGLzNx?=
 =?utf-8?B?M0E9PQ==?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: e9403ec0-0059-438c-cb73-08dac93309d0
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 07:03:47.3258
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4rNbIyW+ghprJoOeOFT6R2/4aNXovoZjX5rmiGCamRjo8XpNa3MZnWyUTq+7DaPdAe5N0qHEpnfXQRl7T4xwKFbXRYcgaf2TeFtfMn0zmPE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8833
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Anand,

On 11/16/22 21:01, Anand Moon wrote:
> On rk356x ethernet phy support reduced media independent interface (RMII)
> and reduced gigabit media independent interface (RGMII).
> So set the phy mode to rgmii to support clock delay, also
> add TX and RX delay for phy-mode.

Based on this commit message I still don't understand what you are
actually trying to fix here. If you encounter network problems/stability
issues, please let me know what test triggers the faulty behavior.
Please describe the problem you are facing in detail here or in the
cover letter.

> Fix following warning
> 
> [    7.365215] rk_gmac-dwmac fe010000.ethernet: Can not read property: tx_delay.
> [    7.365219] rk_gmac-dwmac fe010000.ethernet: set tx_delay to 0x30
> [    7.365224] rk_gmac-dwmac fe010000.ethernet: Can not read property: rx_delay.
> [    7.365228] rk_gmac-dwmac fe010000.ethernet: set rx_delay to 0x10

If the only purpose of this patch is to get rid of this warnings, it may
make sense to set them to dev_dbg as Peter pointed out.

Best regards,
Michael

> 
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> V2: Fix commit message and added the RX and TX clock delay.
> ---
>  arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> index ea74ba32fbbd..e1c75532dcee 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> @@ -253,13 +253,16 @@ &gmac1 {
>  	assigned-clock-rates = <0>, <125000000>;
>  	clock_in_out = "output";
>  	phy-handle = <&rgmii_phy1>;
> -	phy-mode = "rgmii-id";
> +	phy-mode = "rgmii";
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&gmac1m1_miim
>  		     &gmac1m1_tx_bus2
>  		     &gmac1m1_rx_bus2
>  		     &gmac1m1_rgmii_clk
>  		     &gmac1m1_rgmii_bus>;
> +
> +	tx_delay = <0x4f>;
> +	rx_delay = <0x26>;
>  	status = "okay";
>  };
>