Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ecd9d251-8941-b2db-71b2-e4ac06f860a3@amd.com>
Date:   Fri, 18 Nov 2022 09:01:44 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] drm/amdgpu: add mb for si
Content-Language: en-US
To:     Zhenneng Li <lizhenneng@kylinos.cn>,
        Alex Deucher <alexander.deucher@amd.com>
Cc:     Xinhui.Pan@amd.com, David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20221118074810.380368-1-lizhenneng@kylinos.cn>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20221118074810.380368-1-lizhenneng@kylinos.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVo1VW94YkF1N1l6ZDljZ055dzFmMkMzNGV1Q2ljQWx6NHJ4QjVmWUFqK01j?=
 =?utf-8?B?QUxYZzREQ211bmt1Z3VLRVRXSlNNRGR2cSthZnNoeEJnb2dVSnhUaEZUb09X?=
 =?utf-8?B?KzZJbVhzZ1NlRjhHOGczMXp4NFk4cGkyVDZ5bERKaXpnZFRMNkt2REJtak5V?=
 =?utf-8?B?c2svZXJJT2t1N2VEeXJXdndHcHlLYW8rancrdWRrQ3B4bDEyWGJxV1g2cXY4?=
 =?utf-8?B?cVpaUWd5WHE4WkRmWnpUV2hNbjR4anE5YnVJVHIvV0lqNjNMeXRlSUJNRU1w?=
 =?utf-8?B?aUlmZTRKU0lZSnNjYUZmTVB2dDAxZHUxTFV6MG81SXVLL3lIOGxEUk1zbjhF?=
 =?utf-8?B?KzNuem5lTGpza3NyNjlCdWtsYzZycDdqYU1taXk4UHVTQ3FYTVRQY3JBaE85?=
 =?utf-8?B?ZUhxMlVCci8vd3lTWE9ldFc3NElkUFdvUXdSZld1amg5eU9iQi8zUGZwRzk2?=
 =?utf-8?B?R0UwLzNUMEVlVkJGVE5KLys1UW1CNVBFQkpLdlR6NElGWGxHV2dwMkVtMWVP?=
 =?utf-8?B?KzE0RzR6Qm1zSXZFdndRQkJLRmZKaXcyd3dhb3pBMzc5Z3JzZ3pKaGVvdTFu?=
 =?utf-8?B?V2dWMkhhV1JnaURUTk9yWGlhdHZFRmRIQm0vVE5yZXVlNzlaQlZBNlpjSnRu?=
 =?utf-8?B?SEZTUHZyN2ZTT0NIRHFYSWNqVTcxVDE1THFxMHBvWXAxbnN6eDNOTVU0NDN4?=
 =?utf-8?B?WXdsRjVtQ1NEUUkyVDF2ZEZZVkhqSmpiV2NNbUd2ajNvaE9HNk8zcm02SW1t?=
 =?utf-8?B?dEx5SXRhbEcwWHRaRUpISlUwd0x2bmQ2d1d3ckhxcFI5TlhvTGVYUDhKWFJ5?=
 =?utf-8?B?UmRlWUFaYmFyOUFSVGZMU0Zvd0IrSjE1WGdsTnViZCsyMTBKV3ZVM3BMQS9L?=
 =?utf-8?B?YXVoRStLSUdVZ0VDY1JkOU5ya0tXbnRJUmx0R0lLSzM3ekhXTGhFdjZuaG9p?=
 =?utf-8?B?TzJobC9kcUloZmQ5ODlWeTVIajg0dEtxV1lRbWJXejZkeitONVVnOXJWNHo5?=
 =?utf-8?B?V3RqVUE1T3NJSHpMb2pqTUJoRXpYaUVVOXZHTEJBUEhXK3R5c3ZQS3cxbTNV?=
 =?utf-8?B?c21KN0FDa1oxV1hyYnVIa0ZpZjZMQUFzTmJPblRtUmpZcTB6UzM3c3BNWEFY?=
 =?utf-8?B?Ym9iQ1dsZzFnZGlZeDhick1oQS95eEtZYmhsMVFJVDRqdUNrMlJ3TXo4VlBU?=
 =?utf-8?B?akJhdXR3TGJxS0hUQWJZd2htVEFDcWhDdUxURU5QUFI4c3VVYlFRNGlVU0JZ?=
 =?utf-8?B?RVA1N0tkTm5XZW53M2FFZ0ZVVVNmZmt4L2NLTWF0V1NJUHBoWStkRzgxQmRK?=
 =?utf-8?B?cVZNNTVRSFdYNFNrN1hlMmMyZHBlTGxieXdNVkxMbHRSME8xdkw4OS9SVDQx?=
 =?utf-8?B?c0lBOUhhdmptRFVLMGtlcm14U0lCcGJuT1hZMkUxTUwrcDVFeGlrck15L2Nl?=
 =?utf-8?B?bFM4Y3hRSWM3cHN5cEsyZDJUU0M4WjJ6aytGUlcxN2k5Z3VyQy9CZVpMZVYx?=
 =?utf-8?B?Tkc1N2dEODdWTklBa3lRdk8rUVpmdEsxQmhVQjhWa1gwSDRRUUcyL3RHV3gx?=
 =?utf-8?B?OUNwSWp1bGVBNW9rOWQzeWN6VHh3WjlBT3RiTmt2bXBXL0NhMEM4dGEyUzNy?=
 =?utf-8?B?Z1k0Vytic3dLSTVYTU85SmE4MmErR0IwQWlKcTBRTlpaWXpFU0xUTmlHeFc4?=
 =?utf-8?B?U2dZcnpiQllDOTluSnh3Z0hnbTFYODJFaU1vbFhqV2N0Y0RoOWd2T3pMbUNG?=
 =?utf-8?B?YjZ5NVJTVzNuZXBiNGNzQVk5ZGUrZFBQZGFDOTVZdUxzcUVOR0NRWGJ6SGRk?=
 =?utf-8?B?YVNVb2ZPYnlQTVVhbEt1bXViRVZTU0E5THB6ZTdzM3RYbTkyWjY4Qkh3VW1n?=
 =?utf-8?B?em8wbnBiSHJpTGU4enhLZE8yQ1liQkhNRzdmVFUzZUFxZytOYXQ3S1VtYVp6?=
 =?utf-8?B?d055Q29VdzE3VGxPUnZRVjdDK2xQcElhazR4V1pRN3hqSFJnYzhQUWRVTUdY?=
 =?utf-8?B?UXpoY0Zxek9ZYTRuR0N4Q2JZQWhhc0xZZ3RvWjlCMWxFV1Nkc0VBczZ2dDE2?=
 =?utf-8?B?M21Fbk5qUVRzUFlmOUtxTUxFaDBNNnpBZ1BDY3pPU1pzbFNpTjZ2MnYvWHdV?=
 =?utf-8?B?ZXVDeXlzd0RtV09teHo0M2tMQmgyV3JyTitQM2QzT055L3lINU1BYllIeUI3?=
 =?utf-8?Q?ufEEJitXRphcph4nJ/8re4wrb0p6sMjwF/x5x/0IYAfA?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8798576e-7372-4cb0-db23-08dac93b249f
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 08:01:48.3243
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UGtT/rPP/p/X8V4sCVmhPns9uQRJsx9PR5m/RKwuEJsOWuNRRSDSjw/WViRzWx94
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4512
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 18.11.22 um 08:48 schrieb Zhenneng Li:
> During reboot test on arm64 platform, it may failure on boot,
> so add this mb in smc.
>
> The error message are as follows:
> [    6.996395][ 7] [  T295] [drm:amdgpu_device_ip_late_init [amdgpu]] *ERROR*
> 			    late_init of IP block <si_dpm> failed -22
> [    7.006919][ 7] [  T295] amdgpu 0000:04:00.0: amdgpu_device_ip_late_init failed
> [    7.014224][ 7] [  T295] amdgpu 0000:04:00.0: Fatal error during GPU init

Memory barries are not supposed to be sprinkled around like this, you 
need to give a detailed explanation why this is necessary.

Regards,
Christian.

>
> Signed-off-by: Zhenneng Li <lizhenneng@kylinos.cn>
> ---
>   drivers/gpu/drm/amd/pm/legacy-dpm/si_smc.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/si_smc.c b/drivers/gpu/drm/amd/pm/legacy-dpm/si_smc.c
> index 8f994ffa9cd1..c7656f22278d 100644
> --- a/drivers/gpu/drm/amd/pm/legacy-dpm/si_smc.c
> +++ b/drivers/gpu/drm/amd/pm/legacy-dpm/si_smc.c
> @@ -155,6 +155,8 @@ bool amdgpu_si_is_smc_running(struct amdgpu_device *adev)
>   	u32 rst = RREG32_SMC(SMC_SYSCON_RESET_CNTL);
>   	u32 clk = RREG32_SMC(SMC_SYSCON_CLOCK_CNTL_0);
>   
> +	mb();
> +
>   	if (!(rst & RST_REG) && !(clk & CK_DISABLE))
>   		return true;
>