Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp263831rwb; Fri, 18 Nov 2022 00:46:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf5AQwN4BJzMru8RDnLtCMyv5EYU9mcNsjkYsTHAc6fZ9VMCIzERSCJGPlHU6St2Q19VV6Dr X-Received: by 2002:a17:90a:c78c:b0:213:bbb4:13ce with SMTP id gn12-20020a17090ac78c00b00213bbb413cemr6534397pjb.246.1668761202648; Fri, 18 Nov 2022 00:46:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668761202; cv=none; d=google.com; s=arc-20160816; b=TLtlX7vfUG0m0KP/lUbicHxo9GLgXVp4Xfs67AhokZGtJxqhICGt1yN7POeZJlFTVU YXXPM0ESgFVkXM5WgP/9UqSwi9tvYs5Kdtcx/VUkxRgSU/iEZ3sG6TGB9oddSudRDmTs Kwassc8fj0/JE6D8XiBxGbx/LqmWcbrxWLgK0eXe+BmonG1uUWxKZM+HIldbeFUgS3Dr /GWIYSiVCzlqEvgkUt6gz0sy7X41Jsk97P7Vse/G6VqBY4xDaOzYftD8w7FQ5nbhyIcM rxtobY6z2GdlMhYKVXhM4QSFl5O51iRCV6bpgfk2g9eoLHXJbOEeT9GRSbPbzVL8LsYP YrKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=HaWMsgxGWqZPEhgSQ9nAKO50YG2kKg2THkFp9v6suUY=; b=HvbPPvWX4msuyTshR+CBNPH1BFEOqJwEn33+k52FxFkvwFWGHL5zolaGtpdQrO1RJn OegMJFgwqIruUh9Xbw6am6zUkw2ftUTan9Wfiw/oKZfVPrLhIuw4W3MQAkczteLT9MVL BQcK7yBpavviJzQO+hhNwtNk3IHhEqwWiW8rHQmRDLzIWSaJSFBnMwQCm80w3Z+plj8U yPTnkdkBCYvRcmP/oa+OGDaOBEmWInAsc3s+0wjR6M70tk78F9xPNYNMzx4v2ysq+hpJ 5ucv9sVg/751Q8gWpQ3oN2VrRChi8yUMKV+pbsPhcWGm1q53Rm8YzrrZKp0QFHGrF9hx G8ew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x24-20020a63db58000000b0046b1dabcb34si3317449pgi.765.2022.11.18.00.46.21; Fri, 18 Nov 2022 00:46:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241544AbiKRIjM (ORCPT + 90 others); Fri, 18 Nov 2022 03:39:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241349AbiKRIjB (ORCPT ); Fri, 18 Nov 2022 03:39:01 -0500 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D09825803B; Fri, 18 Nov 2022 00:38:39 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id B8A23807E; Fri, 18 Nov 2022 08:28:33 +0000 (UTC) Date: Fri, 18 Nov 2022 10:38:37 +0200 From: Tony Lindgren To: Dario Binacchi Cc: linux-kernel@vger.kernel.org, Amarula patchwork , michael@amarulasolutions.com, Allison Randal , Greg Kroah-Hartman , Jakob Koschel , Julia Lawall , Len Baker , Liang He , Miaoqian Lin , Michael Turquette , Rob Herring , Stephen Boyd , Tero Kristo , Thomas Gleixner , linux-clk@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v4 1/2] clk: ti: change ti_clk_register[_omap_hw]() API Message-ID: References: <20221113181147.1626585-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221113181147.1626585-1-dario.binacchi@amarulasolutions.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Dario Binacchi [221113 18:01]: > The ti_clk_register() and ti_clk_register_omap_hw() functions are always > called with the parameter of type "struct device" set to NULL, since the > functions from which they are called always have a parameter of type > "struct device_node". Replacing "struct device" type parameter with > "struct device_node" will allow you to register a TI clock to the common > clock framework by taking advantage of the facilities provided by the > "struct device_node" type. Further, adding the "of_" prefix to the name > of these functions explicitly binds them to the "struct device_node" > type. Looks good to me, nice clean-up: Reviewed-by: Tony Lindgren Tested-by: Tony Lindgren