Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756250AbXHISog (ORCPT ); Thu, 9 Aug 2007 14:44:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752460AbXHISoY (ORCPT ); Thu, 9 Aug 2007 14:44:24 -0400 Received: from namei.org ([69.55.235.186]:41313 "EHLO us.intercode.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751621AbXHISoW (ORCPT ); Thu, 9 Aug 2007 14:44:22 -0400 X-Greylist: delayed 1599 seconds by postgrey-1.27 at vger.kernel.org; Thu, 09 Aug 2007 14:44:22 EDT Date: Thu, 9 Aug 2007 11:42:53 -0700 (PDT) From: James Morris X-X-Sender: jmorris@us.intercode.com.au To: David Howells cc: torvalds@osdl.org, akpm@osdl.org, steved@redhat.com, trond.myklebust@fys.uio.no, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/14] CacheFiles: Permit an inode's security ID to be obtained [try #2] In-Reply-To: <21381.1186683681@redhat.com> Message-ID: References: <20070809160438.17906.76348.stgit@warthog.cambridge.redhat.com> <20070809160535.17906.59852.stgit@warthog.cambridge.redhat.com> <21381.1186683681@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 924 Lines: 29 On Thu, 9 Aug 2007, David Howells wrote: > James Morris wrote: > > > > + u32 (*inode_get_secid)(struct inode *inode); > > > > To maintain API consistency, please return an int which only acts as an > > error code, and returning the secid via a *u32 function parameter. > > Does that apply to *all* the functions, irrespective of whether or not they > return an error? LSM is theoretically an API, so we generally don't know if a security module will return an error or not. If they were simply calls directly into SElinux, where we could always know the semantics, then that would be a different story. - James -- James Morris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/