Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760777AbXHISwn (ORCPT ); Thu, 9 Aug 2007 14:52:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752423AbXHISwI (ORCPT ); Thu, 9 Aug 2007 14:52:08 -0400 Received: from namei.org ([69.55.235.186]:41567 "EHLO us.intercode.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757188AbXHISwG (ORCPT ); Thu, 9 Aug 2007 14:52:06 -0400 Date: Thu, 9 Aug 2007 11:50:57 -0700 (PDT) From: James Morris X-X-Sender: jmorris@us.intercode.com.au To: Casey Schaufler cc: David Howells , torvalds@osdl.org, akpm@osdl.org, steved@redhat.com, trond.myklebust@fys.uio.no, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/14] CacheFiles: Permit an inode's security ID to be obtained [try #2] In-Reply-To: <162335.27499.qm@web36605.mail.mud.yahoo.com> Message-ID: References: <162335.27499.qm@web36605.mail.mud.yahoo.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 28 On Thu, 9 Aug 2007, Casey Schaufler wrote: > This is SELinux specific functionality. It should not be an LSM > interface. As long as the security labels are themselves not being exported to the kernel to be used e.g. for display or transport, then I agree, and we should avoid passing them around outside the LSM entirely if possible. Usually, they're attached to a significant kernel object, which you typically pass around as part of the interface anyway. David, I've looked at the code and can't see that you need to access the label itself outside the LSM. Could you instead simply pass the inode pointer around? (I know it's not always possible, but much preferred). - James -- James Morris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/