Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     "Bolboaca, Ramona" <Ramona.Bolboaca@analog.com>,
        "jic23@kernel.org" <jic23@kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "Bolboaca, Ramona" <Ramona.Bolboaca@analog.com>
Subject: RE: [PATCH v3 01/10] iio: adis: add '__adis_enable_irq()'
 implementation
Thread-Topic: [PATCH v3 01/10] iio: adis: add '__adis_enable_irq()'
 implementation
Thread-Index: AQHY+ygrDzGBI4Cxq0uzp1+y71+ps65EdfJA
Date:   Fri, 18 Nov 2022 10:13:25 +0000
Message-ID: <SJ0PR03MB6778660019C2553E5E18F8EC99099@SJ0PR03MB6778.namprd03.prod.outlook.com>
References: <20221118083118.9641-1-ramona.bolboaca@analog.com>
 <20221118083118.9641-2-ramona.bolboaca@analog.com>
In-Reply-To: <20221118083118.9641-2-ramona.bolboaca@analog.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?bAz728hHLrwiigxoQpBW7RRWtf/GbYFkNQPpr9SMLsU95vj4f8ovf8Ld3A?=
 =?iso-8859-1?Q?CffDuXR6eGTvLXA5H6TYsWXzwT6zmBjvfteiuF00gkQYFZyoKtyCLOSloX?=
 =?iso-8859-1?Q?aZyTbQM4UKmMcKyFlj3JgWncHqWlfg5fOoeB2viYAcaDpfBTGRyuzp+jXi?=
 =?iso-8859-1?Q?dGZnoAb8Swy7c/GL3FwBgqP9D+9eave+hWQDZG3Rt/Nsx1JVa5SGySruUi?=
 =?iso-8859-1?Q?wt0oNe07N8TgdWm0S75vQp7QC7Z4gcV+Dl5oPoEAb0IoEWgR+qvF4+vXK5?=
 =?iso-8859-1?Q?Grs99R2IpPd7pRtPkvhoWCStGZhLgU8VuSUlHquGBo6gyir/j2V9Hbj/KT?=
 =?iso-8859-1?Q?NJUEKBbAIoU1vc3KPvqBL6FGFMoaLdBY0kP1Hzqo/k8UdCoYdI43ljeL7j?=
 =?iso-8859-1?Q?825FZrAbkcrdtB7+uZEqq0wUuHjwZEjhxLtNycBTx8/zV09U54uffhWT9e?=
 =?iso-8859-1?Q?NhOby75kSfVV3gKWpqDXiS/QDT1ImweRtZq9ctkrfVletY7UsfN/2vmYmL?=
 =?iso-8859-1?Q?AP8lpZuGbABDnppCDewBWkjQRS/ZR8jyG0ooy3XI8p9H8KKDYIUd9TQyXj?=
 =?iso-8859-1?Q?WeOGhR8NW6Jgx/MqUzcjcGfJeiMIa2ukDzgZjBHZCgtzlnykkIpcb6LxSa?=
 =?iso-8859-1?Q?7qqIopLqstd95d4U+2sKoVOJheu2MJykowbcghUg7pElcR/5xRdG7uWWmU?=
 =?iso-8859-1?Q?Q9GznilUGkrZvXfwrTGit/e3dhlSLeuvfTxgRQL8oEwFdvupaCVgoV8eiL?=
 =?iso-8859-1?Q?d1NcChpxpLF7GP35rPYCQief2NFdk1lk4kPd/a6gMjcTuCL9kLtmEr/9cK?=
 =?iso-8859-1?Q?mo8bYU5GsZ7SvmI9BIDmqyJGwpBVhIeY4RZnWdlm5a5UcxjvpNreNVDEY+?=
 =?iso-8859-1?Q?EY5T6lPEVn6CYMbH/oYCIRZV7rkXwOCmWnAolqJFy/Mx894orgYXXonLwz?=
 =?iso-8859-1?Q?HMaQhSh9frPCCm2Dy2bmaP+qSKU3NBqJovq5fXYVKXSIdNwhEEIZjyDPSF?=
 =?iso-8859-1?Q?LMw8KB/pjMcv49Xi9eCJ9/rbwy9h68xf1mmtt5wspLK0twxvcOuVfbszAW?=
 =?iso-8859-1?Q?rgePlgDBNJx9ubMXbkL5dIminuyqSVh3a6Uxf7/barxgmMBif7oxIO/k53?=
 =?iso-8859-1?Q?PJP059+zHeaqhTR8al2Ofi34tBKiWEUxWeO5eLqU3DBrNVRuwgmiOaUSGX?=
 =?iso-8859-1?Q?FlTJ2gleuVY9aaCPAQAGBBHDhqpwQz4SwygYd2QYYnJtVlndqAxJw0BD5N?=
 =?iso-8859-1?Q?xOxsIMBYcAexIsbddDPfB8o3Q3rP8a0CmPilILcosPXECwDukWJSnZLLEN?=
 =?iso-8859-1?Q?7Addd6qGs803M2wH5s6y7qzyEZawalercC5hxymxYSgSleAmjr10R+77En?=
 =?iso-8859-1?Q?riBWjKpGVx/j+MhB3fpITh3pjItLW57eGmkUG7wYwfPO7wPt9BttDFI51Y?=
 =?iso-8859-1?Q?vhglqO9djSBfmp8nUKrMpHhLooZC4vg/G/H4AZZWE2Azu/mGkcz8Y76d7a?=
 =?iso-8859-1?Q?qdGPtPPVI7rFaT5F22idKNPNJwUTL47CR8qaMU0RKKHi65pbTDy2BH2ln4?=
 =?iso-8859-1?Q?CWPtIqcBZTRBstMZeTQlcp0UXW0FGaUVC8K8Tg03ijEnowaYlVGcuZ2m1T?=
 =?iso-8859-1?Q?/zz5QA6AVZp78=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6778.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1884c3c4-34d9-4d05-d5a4-08dac94d87fa
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2022 10:13:25.6749
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wCbE93OkjCkdfRLwTa9NBrK0clj3uFJa5Ck0cofTnLNDMfZpRHZXJKLqZJVHFl7yESxGPeW4b6lQpIGXGw8pIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5757
X-Proofpoint-ORIG-GUID: XQt7qcNc1zgO3ZESwgYRUenob4vLbpNa
X-Proofpoint-GUID: XQt7qcNc1zgO3ZESwgYRUenob4vLbpNa
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-17_06,2022-11-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=892
 priorityscore=1501 adultscore=0 suspectscore=0 phishscore=0 mlxscore=0
 malwarescore=0 spamscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0
 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2211180061
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Ramona Bolboaca <ramona.bolboaca@analog.com>
> Sent: Friday, November 18, 2022 9:31 AM
> To: jic23@kernel.org; Sa, Nuno <Nuno.Sa@analog.com>; linux-
> iio@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Bolboaca, Ramona <Ramona.Bolboaca@analog.com>
> Subject: [PATCH v3 01/10] iio: adis: add '__adis_enable_irq()' implementa=
tion
>=20
> Add '__adis_enable_irq()' implementation which is the unlocked
> version of 'adis_enable_irq()'.
>=20
> Signed-off-by: Ramona Bolboaca <ramona.bolboaca@analog.com>
> ---
> changes in v3:
>  - new patch
>  drivers/iio/imu/adis.c       | 26 +++++++++-----------------
>  include/linux/iio/imu/adis.h | 12 +++++++++++-
>  2 files changed, 20 insertions(+), 18 deletions(-)
>=20
> diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c
> index f7fcfd04f659..cfcb4abeb5db 100644
> --- a/drivers/iio/imu/adis.c
> +++ b/drivers/iio/imu/adis.c
> @@ -270,23 +270,19 @@ EXPORT_SYMBOL_NS(adis_debugfs_reg_access,
> IIO_ADISLIB);
>  #endif
>=20
>  /**
> - * adis_enable_irq() - Enable or disable data ready IRQ
> + * __adis_enable_irq() - Enable or disable data ready IRQ (unlocked)
>   * @adis: The adis device
>   * @enable: Whether to enable the IRQ
>   *
>   * Returns 0 on success, negative error code otherwise
>   */
> -int adis_enable_irq(struct adis *adis, bool enable)
> +int __adis_enable_irq(struct adis *adis, bool enable)
>  {
> -	int ret =3D 0;
> +	int ret;

This change was not really needed as long as we 'return ret'
In the ' unmasked_drdy' case. Anyways, not a big deal for me...

- Nuno S=E1